Merge pull request #172 from StackStorm/fix/unhandled-rejection

Exit hubot on unhandled promise rejections and other unrecoverable errors

Author: armab

CHANGELOG.rst

@@ -3,6 +3,7 @@ Changelog
 
 in development
 --------------
+* Exit hubot on unhandled promise rejections and uncaught exceptions, usually caused by unrecoverable errors (bug fix)
 
 0.9.3
 -----

scripts/stackstorm.js

@@ -99,6 +99,29 @@ var TWOFACTOR_MESSAGE = "This action requires two-factor auth! Waiting for your
 module.exports = function(robot) {
   slack_monkey_patch.patchSendMessage(robot);
 
+  // Makes the script crash on unhandled rejections instead of ignoring them and keep running.
+  // Usually happens when trying to connect to a nonexistent instances or similar unrecoverable issues.
+  // In the future Node.js versions, promise rejections that are not handled will terminate the process with a non-zero exit code.
+  process.on('unhandledRejection', function(err) {
+    throw err;
+  });
+
+  // Handle uncaught exceptions, log error and terminate hubot if one occurs
+  robot.error(function(err, res) {
+    if (err) {
+      robot.logger.error(err.stack || JSON.stringify(err));
+    }
+    if (res) {
+      res.send(JSON.stringify({
+        "status": "failed",
+        "msg": "An error occurred trying to post the message:\n" + err
+      }));
+    }
+
+    robot.logger.info('Hubot will shut down ...');
+    robot.shutdown();
+  });
+
   var self = this;
 
   var promise = Promise.resolve();