Skip to content

untangle LocalClient #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
Panaetius opened this issue Aug 11, 2021 · 1 comment
Closed
6 tasks done

untangle LocalClient #2254

Panaetius opened this issue Aug 11, 2021 · 1 comment

Comments

@Panaetius
Copy link
Member

Panaetius commented Aug 11, 2021

LocalClient is pretty much a horrible god object at the moment, being composed of several mixins that directly access properties of the other mixins, so they can only work if all the mixins are combined together.

We should replace this as much as possible with business layer logic, one class per concern/use-case, that don't directly depend on each other and can be used independently.

This entails moving functionality out of the LocalClient mixins to dedicated classes, changing the places it was used to use the new logic, refactor out common/global settings (like renku path) to an appropriate interface&implementation combo that can get injected and to also keep a close eye on if there's any logic in the mixin that is not actually business logic but might be domain logic or an external implementation detail and moving it to the appropriate place

@Panaetius
Copy link
Member Author

Timeboxed to 1 day, write epic/tasks to slowly do this.

@Panaetius Panaetius moved this from Backlog to Ready in renku-python Jul 26, 2022
@Panaetius Panaetius moved this from Ready to In Progress in renku-python Aug 12, 2022
@Panaetius Panaetius self-assigned this Aug 12, 2022
@Panaetius Panaetius added the Epic label Aug 12, 2022
@Panaetius Panaetius moved this from In Progress to Done in renku-python Aug 24, 2022
@Panaetius Panaetius removed their assignment Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants