Skip to content

Commit c07b307

Browse files
committed
fix(TCOMP-2260): merge TCOMP-2407
1 parent 6405480 commit c07b307

File tree

11 files changed

+599
-146
lines changed

11 files changed

+599
-146
lines changed

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,4 +61,7 @@ documentation/rebuildpdf.bat
6161

6262
# release process
6363
.build/
64-
.build_source/
64+
.build_source/
65+
# direnv
66+
.envrc
67+
.env

.jenkins/scripts/docker_build.sh

Lines changed: 23 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,32 @@ set -xe
2020
# Parameters:
2121
# $1: docker tag version
2222
# $2: should tag as latest
23+
# $3: requested image, if not given, all will be pushed
2324

24-
tag="${1?Missing tag}"
25-
latest="${2:-false}"
25+
_TAG="${1?Missing tag}"
26+
_IS_LATEST="${2-'false'}"
27+
_ONLY_ONE_IMAGE="${3-''}"
2628

2729
dockerBuild() {
28-
echo ">> Building and pushing $1:${tag}"
29-
cd "images/${1}-image"
30-
mvn package jib:build@build -Ddocker.talend.image.tag=${tag}
31-
if [[ ${latest} == 'true' ]]; then
32-
mvn package jib:build@build -Ddocker.talend.image.tag=latest
30+
_IMAGE="${1}"
31+
echo ">> Building and push $_IMAGE:${_TAG}"
32+
33+
mvn package jib:build@build \
34+
--file "images/${_IMAGE}-image/pom.xml" \
35+
--define docker.talend.image.tag="${_TAG}"
36+
37+
if [[ ${_IS_LATEST} == 'true' ]]; then
38+
mvn package jib:build@build \
39+
--file "images/${_IMAGE}-image/pom.xml" \
40+
--define docker.talend.image.tag=latest
3341
fi
34-
cd ../..
3542
}
3643

37-
dockerBuild "component-server"
38-
dockerBuild "component-starter-server"
39-
dockerBuild "remote-engine-customizer"
44+
if [[ -n "${_ONLY_ONE_IMAGE}" ]]; then
45+
dockerBuild "${_ONLY_ONE_IMAGE}"
46+
else
47+
dockerBuild "component-server"
48+
dockerBuild "component-starter-server"
49+
dockerBuild "remote-engine-customizer"
50+
fi
51+

Jenkinsfile

Lines changed: 477 additions & 107 deletions
Large diffs are not rendered by default.

ci/Jenkinsfile-scan

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ final def veracodeCredentials = usernamePassword(
2121
final def nexusCredentials = usernamePassword(
2222
credentialsId: 'nexus-artifact-zl-credentials',
2323
usernameVariable: 'NEXUS_USER',
24-
passwordVariable: 'NEXUS_PASSWORD')
24+
passwordVariable: 'NEXUS_PASS')
2525

2626
String git_branch_name = ""
2727

component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/MavenRepositoryResolverTest.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import static org.junit.jupiter.api.Assertions.assertEquals;
1919
import static org.junit.jupiter.api.Assertions.assertNotNull;
20-
import static org.talend.sdk.component.runtime.manager.service.MavenRepositoryResolver.M2_REPOSITORY;
2120
import static org.talend.sdk.component.runtime.manager.service.MavenRepositoryResolver.STUDIO_MVN_REPOSITORY;
2221
import static org.talend.sdk.component.runtime.manager.service.MavenRepositoryResolver.TALEND_COMPONENT_MANAGER_M2_REPOSITORY;
2322
import static org.talend.sdk.component.runtime.manager.service.MavenRepositoryResolver.TALEND_COMPONENT_MANAGER_M2_SETTINGS;
@@ -39,6 +38,8 @@
3938

4039
class MavenRepositoryResolverTest {
4140

41+
static String M2_REPOSITORY = ".m2" + File.separator + "repository";
42+
4243
private final MavenRepositoryResolver resolver = new MavenRepositoryDefaultResolver();
4344

4445
final MavenRepositoryDefaultResolver mavenSettingsOnlyResolver = new MavenRepositoryDefaultResolver() {
@@ -63,7 +64,7 @@ public Path get(final String path) {
6364
}
6465
};
6566

66-
private final String fallback = System.getProperty("user.home") + "/" + M2_REPOSITORY;
67+
private final String fallback = System.getProperty("user.home") + File.separator + M2_REPOSITORY;
6768

6869
private final Path repository = Paths.get(new File("target/test-classes").getAbsolutePath());
6970

@@ -164,7 +165,8 @@ void discoverFromSettingsWindowsPath() {
164165
mavenSettingsOnlyResolver.setHandler(handlerNoExistCheck);
165166
final Path m2 = mavenSettingsOnlyResolver.discover();
166167
assertNotNull(m2);
167-
assertEquals("C:/Users/maven/repository", m2.toString());
168+
assertEquals("C:" + File.separator + "Users" + File.separator + "maven" + File.separator + "repository",
169+
m2.toString());
168170
System.clearProperty(TALEND_COMPONENT_MANAGER_M2_SETTINGS);
169171
}
170172

@@ -174,7 +176,8 @@ void discoverFromSettingsTildePath() {
174176
mavenSettingsOnlyResolver.setHandler(handlerNoExistCheck);
175177
final Path m2 = mavenSettingsOnlyResolver.discover();
176178
assertNotNull(m2);
177-
assertEquals(System.getProperty("user.home") + "/mvn_home_dev/repository", m2.toString());
179+
assertEquals(System.getProperty("user.home") + File.separator + "mvn_home_dev" + File.separator + "repository",
180+
m2.toString());
178181
System.clearProperty(TALEND_COMPONENT_MANAGER_M2_SETTINGS);
179182
}
180183

@@ -184,7 +187,8 @@ void discoverFromSettingsUserHomeProperty() {
184187
mavenSettingsOnlyResolver.setHandler(handlerNoExistCheck);
185188
final Path m2 = mavenSettingsOnlyResolver.discover();
186189
assertNotNull(m2);
187-
assertEquals(System.getProperty("user.home") + "/mvn_home_dev/repository", m2.toString());
190+
assertEquals(System.getProperty("user.home") + File.separator + "mvn_home_dev" + File.separator + "repository",
191+
m2.toString());
188192
System.clearProperty(TALEND_COMPONENT_MANAGER_M2_SETTINGS);
189193
}
190194

documentation/src/main/antora/modules/ROOT/pages/_partials/generated_changelog.adoc

Lines changed: 26 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,17 @@
11

22

3+
== Version 1.56.0
4+
5+
=== Bug
6+
7+
- link:https://jira.talendforge.org/browse/TCOMP-2355[TCOMP-2355^]: Error on language support for xx_YY language files link:search.html?query=component-server[component-server^,role='dockey']
8+
9+
10+
11+
=== Work Item
12+
13+
- link:https://jira.talendforge.org/browse/TCOMP-2405[TCOMP-2405^]: Upgrade snakeyaml to 2.0 link:search.html?query=build[build^,role='dockey']
14+
315
== Version 1.55.0
416

517
=== Bug
@@ -702,6 +714,14 @@
702714

703715

704716

717+
718+
719+
720+
== Version 1.38.9
721+
722+
=== Work Item
723+
724+
- link:https://jira.talendforge.org/browse/TCOMP-2412[TCOMP-2412^]: Upgrade tomcat to 9.0.69 link:search.html?query=component-server[component-server^,role='dockey']
705725

706726
== Version 1.38.8
707727

@@ -1481,12 +1501,6 @@
14811501

14821502

14831503

1484-
1485-
== Version 1.1.15.2
1486-
1487-
=== Work Item
1488-
1489-
- link:https://jira.talendforge.org/browse/TCOMP-1752[TCOMP-1752^]: Make component-runtime class loader find classes in RemoteEngine JobServer
14901504

14911505
== Version 1.1.15
14921506

@@ -1521,6 +1535,12 @@
15211535
- link:https://jira.talendforge.org/browse/TCOMP-1578[TCOMP-1578^]: Upgrade asciidoctor-pdf to v1.5.0-beta.7
15221536
- link:https://jira.talendforge.org/browse/TCOMP-1581[TCOMP-1581^]: Support JUnit5 meta annotations for our extensions
15231537

1538+
== Version 1.1.15.2
1539+
1540+
=== Work Item
1541+
1542+
- link:https://jira.talendforge.org/browse/TCOMP-1752[TCOMP-1752^]: Make component-runtime class loader find classes in RemoteEngine JobServer
1543+
15241544
== Version 1.1.15.1
15251545

15261546
=== New Feature

documentation/src/main/antora/modules/ROOT/pages/_partials/generated_contributors.adoc

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"name":"Romain Manni-Bucau"
99
},
1010
{
11-
"commits":689,
11+
"commits":695,
1212
"description":"Software engineer @Talend.\r\n\r\nComponents team member.\n\nBlog: undx.github.io",
1313
"gravatar":"https://avatars.githubusercontent.com/u/265575?v=4",
1414
"id":"undx",
@@ -50,7 +50,7 @@
5050
"name":"ypiel"
5151
},
5252
{
53-
"commits":27,
53+
"commits":28,
5454
"description":"",
5555
"gravatar":"https://avatars.githubusercontent.com/u/7742508?v=4",
5656
"id":"yyin-talend",
@@ -70,6 +70,13 @@
7070
"id":"wwang-talend",
7171
"name":"wang wei"
7272
},
73+
{
74+
"commits":15,
75+
"description":"QA Automation @ Talend Nantes",
76+
"gravatar":"https://avatars.githubusercontent.com/u/1255625?v=4",
77+
"id":"acatoire",
78+
"name":"Axel CATOIRE"
79+
},
7380
{
7481
"commits":10,
7582
"description":"",
@@ -98,13 +105,6 @@
98105
"id":"jsomsanith-tlnd",
99106
"name":"Jimmy Somsanith"
100107
},
101-
{
102-
"commits":8,
103-
"description":"QA Automation @ Talend Nantes",
104-
"gravatar":"https://avatars.githubusercontent.com/u/1255625?v=4",
105-
"id":"acatoire",
106-
"name":"Axel CATOIRE"
107-
},
108108
{
109109
"commits":8,
110110
"description":"",

documentation/src/main/antora/site-template.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ content:
5050
- '!component-runtime-1.38.5'
5151
- '!component-runtime-1.38.6'
5252
- '!component-runtime-1.38.7'
53+
- '!component-runtime-1.38.8'
5354
- '!component-runtime-1.39.0'
5455
- '!component-runtime-1.39.1'
5556
- '!component-runtime-1.39.2'
@@ -70,6 +71,10 @@ content:
7071
- '!component-runtime-1.50.3'
7172
- '!component-runtime-1.51.0'
7273
- '!component-runtime-1.51.1'
74+
- '!component-runtime-1.52.0'
75+
- '!component-runtime-1.52.1'
76+
- '!component-runtime-1.53.0'
77+
- '!component-runtime-1.54.0'
7378
branches:
7479
- HEAD
7580
start_path: documentation/src/main/antora

images/component-server-image/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@
231231
<TALEND_COMPONENT_SERVER_MAVEN_REPOSITORY>${TALEND_HOME}/connectors</TALEND_COMPONENT_SERVER_MAVEN_REPOSITORY>
232232
<TALEND_VAULT_CACHE_VAULT_DECRYPT_ENDPOINT>v1/tenants-keyrings/decrypt/{x-talend-tenant-id}</TALEND_VAULT_CACHE_VAULT_DECRYPT_ENDPOINT>
233233
<CLASSPATH>${docker.talend.dir.base}component-kit/custom/*:${docker.talend.dir.base}custom/*:${TALEND_HOME}/extensions/*:${docker.talend.dir.app}resources:${docker.talend.dir.app}classes</CLASSPATH>
234-
<JDK_JAVA_OPTIONS>--add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.nio=ALL-UNNAMED -Dlog4j.configurationFile=${docker.talend.dir.app}conf/log4j2-component-server-TEXT.xml</JDK_JAVA_OPTIONS>
234+
<JDK_JAVA_OPTIONS>--add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/sun.net.nio=ALL-UNNAMED -Dlog4j.configurationFile=${docker.talend.dir.app}conf/log4j2-component-server-TEXT.xml</JDK_JAVA_OPTIONS>
235235
</environment>
236236
<labels>
237237
<com.talend.docker.cmd>docker run -d -p ${docker.image.port}:${docker.image.port} ${docker.image.to}</com.talend.docker.cmd>

pom.xml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1746,6 +1746,19 @@
17461746
</build>
17471747

17481748
<profiles>
1749+
<profile>
1750+
<id>private_repository</id>
1751+
<!--
1752+
This profile is used by the CI or for development branch deployment.
1753+
Its overwrite the snapshotRepository with a private one.
1754+
-->
1755+
<distributionManagement>
1756+
<snapshotRepository>
1757+
<id>talend.snapshots</id>
1758+
<url>https://artifacts-zl.talend.com/nexus/content/repositories/snapshots</url>
1759+
</snapshotRepository>
1760+
</distributionManagement>
1761+
</profile>
17491762
<profile>
17501763
<id>travis</id>
17511764
<properties>

0 commit comments

Comments
 (0)