Skip to content

Commit b098c22

Browse files
fix(solid-query): Use rollup-preset-solid (#5565)
1 parent a4d753b commit b098c22

File tree

6 files changed

+48
-27
lines changed

6 files changed

+48
-27
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@
8585
"rollup-plugin-node-externals": "^6.1.0",
8686
"rollup-plugin-preserve-directives": "^0.2.0",
8787
"rollup-plugin-visualizer": "^5.9.0",
88+
"rollup-preset-solid": "^2.0.1",
8889
"semver": "^7.5.1",
8990
"solid-js": "^1.6.13",
9091
"stream-to-array": "^2.3.0",

packages/query-devtools/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
},
5454
"devDependencies": {
5555
"@tanstack/query-core": "^5.0.0-alpha.43",
56-
"rollup-preset-solid": "^2.0.1",
5756
"vite-plugin-solid": "^2.5.0"
5857
}
5958
}

packages/solid-query/package.json

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,35 +11,37 @@
1111
"url": "https://github.com/sponsors/tannerlinsley"
1212
},
1313
"type": "module",
14-
"types": "build/lib/index.d.ts",
15-
"main": "build/lib/index.cjs",
16-
"module": "build/lib/index.js",
14+
"types": "dist/types/index.d.ts",
15+
"main": "dist/cjs/index.cjs",
16+
"module": "dist/esm/index.js",
1717
"exports": {
1818
".": {
19-
"types": "./build/lib/index.d.ts",
20-
"solid": "./build/lib/index.js",
21-
"import": "./build/lib/index.js",
22-
"require": "./build/lib/index.cjs",
23-
"default": "./build/lib/index.cjs"
19+
"types": "./dist/types/index.d.ts",
20+
"solid": "./dist/source/index.jsx",
21+
"import": "./dist/esm/index.js",
22+
"browser": {
23+
"import": "./dist/esm/index.js",
24+
"require": "./dist/cjs/index.cjs"
25+
},
26+
"require": "./dist/cjs/index.cjs",
27+
"node": "./dist/cjs/index.cjs"
2428
},
2529
"./package.json": "./package.json"
2630
},
2731
"sideEffects": [
2832
"./src/setBatchUpdatesFn.ts"
2933
],
3034
"scripts": {
31-
"clean": "rimraf ./build && rimraf ./coverage",
35+
"clean": "rimraf ./dist && rimraf ./coverage",
3236
"test:eslint": "eslint --ext .ts,.tsx ./src",
3337
"test:types": "tsc --noEmit",
3438
"test:lib": "vitest run --coverage",
3539
"test:lib:dev": "pnpm run test:lib --watch",
3640
"test:build": "publint --strict",
37-
"build": "pnpm build:rollup && pnpm build:types",
38-
"build:rollup": "rollup --config rollup.config.js",
39-
"build:types": "tsc --emitDeclarationOnly"
41+
"build": "rollup --config rollup.config.js"
4042
},
4143
"files": [
42-
"build",
44+
"dist",
4345
"src"
4446
],
4547
"dependencies": {

packages/solid-query/rollup.config.js

Lines changed: 28 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,31 @@
11
// @ts-check
22

33
import { defineConfig } from 'rollup'
4-
import { buildConfigs } from '../../scripts/getRollupConfig.js'
5-
6-
export default defineConfig(
7-
buildConfigs({
8-
name: 'solid-query',
9-
outputFile: 'index',
10-
entryFile: './src/index.ts',
11-
}),
12-
)
4+
import withSolid from 'rollup-preset-solid'
5+
6+
export function createSolidQueryConfig() {
7+
const solidRollupOptions = /** @type {import('rollup').RollupOptions} */ (
8+
withSolid({
9+
input: `./src/index.ts`,
10+
targets: ['esm', 'cjs'],
11+
external: ['@tanstack/query-core'],
12+
})
13+
)
14+
15+
const outputs = !solidRollupOptions.output
16+
? []
17+
: Array.isArray(solidRollupOptions.output)
18+
? solidRollupOptions.output
19+
: [solidRollupOptions.output]
20+
21+
outputs.forEach((output) => {
22+
if (output.format === 'cjs') {
23+
output.entryFileNames = '[name].cjs'
24+
output.chunkFileNames = '[name]-[hash].cjs'
25+
}
26+
})
27+
28+
return solidRollupOptions
29+
}
30+
31+
export default defineConfig(createSolidQueryConfig())

packages/solid-query/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"compilerOptions": {
44
"jsx": "preserve",
55
"jsxImportSource": "solid-js",
6-
"outDir": "./build/lib",
6+
"outDir": "./dist",
77
"types": ["vitest/globals"]
88
},
99
"include": ["src"]

pnpm-lock.yaml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)