refactor: cacheTime-zero

since every fetch triggers a new gc cycle, we don't need to do this in a loop anymore
also, reset isFetchingOptimistic after every fetch

Author: TkDodo

src/core/query.ts

@@ -195,12 +195,8 @@ export class Query<
   }
 
   protected optionalRemove() {
-    if (!this.observers.length) {
-      if (this.state.fetchStatus === 'idle') {
-        this.cache.remove(this)
-      } else {
-        this.scheduleGc()
-      }
+    if (!this.observers.length && this.state.fetchStatus === 'idle') {
+      this.cache.remove(this)
     }
   }
 
@@ -449,9 +445,10 @@ export class Query<
         this.cache.config.onSuccess?.(data, this as Query<any, any, any, any>)
 
         if (!this.isFetchingOptimistic) {
-          // Remove query after fetching
+          // Schedule query gc after fetching
           this.scheduleGc()
         }
+        this.isFetchingOptimistic = false
       },
       onError: (error: TError | { silent?: boolean }) => {
         // Optimistically update state if needed
@@ -471,9 +468,10 @@ export class Query<
         }
 
         if (!this.isFetchingOptimistic) {
-          // Remove query after fetching
+          // Schedule query gc after fetching
           this.scheduleGc()
         }
+        this.isFetchingOptimistic = false
       },
       onFail: () => {
         this.dispatch({ type: 'failed' })

src/core/queryObserver.ts

@@ -312,10 +312,7 @@ export class QueryObserver<
       .build(this.client, defaultedOptions)
     query.isFetchingOptimistic = true
 
-    return query.fetch().then(() => {
-      query.isFetchingOptimistic = false
-      return this.createResult(query, defaultedOptions)
-    })
+    return query.fetch().then(() => this.createResult(query, defaultedOptions))
   }
 
   protected fetch(