chore: turn on no-unnecessary-type-assertion (#5057)

* chore: turn on no-unnecessary-type-assertion

* chore: disable linter on false-positive

* more false positives

* the last one

* hah, a couple more real ones

Author: TkDodo

.eslintrc

@@ -40,6 +40,7 @@
     "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/no-non-null-assertion": "off",
     "@typescript-eslint/no-unnecessary-condition": "error",
+    "@typescript-eslint/no-unnecessary-type-assertion": "error",
     "@typescript-eslint/no-inferrable-types": [
       "error",
       {

packages/query-async-storage-persister/src/index.ts

@@ -89,7 +89,7 @@ export const createAsyncStoragePersister = ({
           return
         }
 
-        return deserialize(cacheString) as PersistedClient
+        return deserialize(cacheString)
       },
       removeClient: () => storage.removeItem(key),
     }

packages/query-core/src/mutation.ts

@@ -209,7 +209,7 @@ export class Mutation<
         this as Mutation<unknown, unknown, unknown, unknown>,
       )
 
-      await this.options.onSuccess?.(data, variables, this.state.context!)
+      await this.options.onSuccess?.(data, variables, this.state.context)
 
       await this.options.onSettled?.(data, null, variables, this.state.context)
 

packages/query-core/src/mutationObserver.ts

@@ -103,9 +103,7 @@ export class MutationObserver<
 
     this.#currentMutation = this.#client
       .getMutationCache()
-      .build(this.#client, {
-        ...this.options,
-      })
+      .build(this.#client, this.options)
 
     this.#currentMutation.addObserver(this)
 

packages/query-core/src/query.ts

@@ -458,7 +458,7 @@ export class Query<
           return
         }
 
-        this.setData(data as TData)
+        this.setData(data)
 
         // Notify cache callback
         this.#cache.config.onSuccess?.(data, this as Query<any, any, any, any>)

packages/query-core/src/queryObserver.ts

@@ -648,10 +648,10 @@ export class QueryObserver<
       // First trigger the configuration callbacks
       if (notifyOptions.onSuccess) {
         this.options.onSuccess?.(this.#currentResult.data!)
-        this.options.onSettled?.(this.#currentResult.data!, null)
+        this.options.onSettled?.(this.#currentResult.data, null)
       } else if (notifyOptions.onError) {
         this.options.onError?.(this.#currentResult.error!)
-        this.options.onSettled?.(undefined, this.#currentResult.error!)
+        this.options.onSettled?.(undefined, this.#currentResult.error)
       }
 
       // Then trigger the listeners

packages/query-core/src/subscribable.ts

@@ -9,7 +9,7 @@ export class Subscribable<TListener extends Function = Listener> {
   }
 
   subscribe(listener: TListener): () => void {
-    this.listeners.push(listener as TListener)
+    this.listeners.push(listener)
 
     this.onSubscribe()
 

packages/query-sync-storage-persister/src/index.ts

@@ -76,7 +76,7 @@ export function createSyncStoragePersister({
           return
         }
 
-        return deserialize(cacheString) as PersistedClient
+        return deserialize(cacheString)
       },
       removeClient: () => {
         storage.removeItem(key)

packages/react-query-devtools/src/__tests__/devtools.test.tsx

@@ -720,9 +720,9 @@ describe('ReactQueryDevtools', () => {
       initialIsOpen: true,
     })
 
-    const positionSelect = (await screen.findByLabelText(
+    const positionSelect: HTMLSelectElement = await screen.findByLabelText(
       'Panel position',
-    )) as HTMLSelectElement
+    )
 
     expect(positionSelect.value).toBe('bottom')
   })
@@ -748,9 +748,9 @@ describe('ReactQueryDevtools', () => {
       panelPosition: 'left',
     })
 
-    const positionSelect = (await screen.findByLabelText(
+    const positionSelect: HTMLSelectElement = await screen.findByLabelText(
       'Panel position',
-    )) as HTMLSelectElement
+    )
 
     expect(positionSelect.value).toBe('left')
 
@@ -783,9 +783,9 @@ describe('ReactQueryDevtools', () => {
       initialIsOpen: true,
     })
 
-    const positionSelect = (await screen.findByLabelText(
+    const positionSelect: HTMLSelectElement = await screen.findByLabelText(
       'Panel position',
-    )) as HTMLSelectElement
+    )
 
     expect(positionSelect.value).toBe('bottom')
 

packages/react-query/src/useInfiniteQuery.ts

@@ -29,6 +29,7 @@ export function useInfiniteQuery<
 ): UseInfiniteQueryResult<TData, TError> {
   return useBaseQuery(
     options,
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
     InfiniteQueryObserver as typeof QueryObserver,
     queryClient,
   ) as UseInfiniteQueryResult<TData, TError>

packages/solid-query/src/createInfiniteQuery.ts

@@ -31,6 +31,7 @@ export function createInfiniteQuery<
 ): CreateInfiniteQueryResult<TData, TError> {
   return createBaseQuery(
     createMemo(() => options()),
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
     InfiniteQueryObserver as typeof QueryObserver,
     queryClient,
   ) as CreateInfiniteQueryResult<TData, TError>

packages/svelte-query/src/createInfiniteQuery.ts

@@ -31,6 +31,7 @@ export function createInfiniteQuery<
 ): CreateInfiniteQueryResult<TData, TError> {
   return createBaseQuery(
     options,
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
     InfiniteQueryObserver as typeof QueryObserver,
     queryClient,
   ) as CreateInfiniteQueryResult<TData, TError>

packages/vue-query/src/useInfiniteQuery.ts

@@ -89,7 +89,9 @@ export function useInfiniteQuery<
   >,
   queryClient?: QueryClient,
 ): UseInfiniteQueryReturnType<TData, TError> {
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
   const result = useBaseQuery(
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
     InfiniteQueryObserver as typeof QueryObserver,
     options,
     queryClient,