You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issues received by the users when structuralSharing did not exist are this kind of issues "I want this feature", example: #430
The issues received by the users when structuralSharing was implemented and set to true by default are this kind of issues: "I have a bug and I don't know what is happening", examples: #1633 #1657 (comment)
"I want this feature" vs "I have a bug"... I think it's easy to decide, having a bug consumes a lot of time. Features that are enabled by default should be the ones that does not generate hard to debug issues or "gotchas". Also the warning for this is well hidden on the documentation, which is not friendly.
The text was updated successfully, but these errors were encountered:
We're always open to improving the documentation, but for now the plan is to stick with the default structuralSharing. The side-effects of turning this off could be much worse than most anticipate. The expectation for data structures to remain constant from render to render is a very very common one in the React ecosystem, which was the first motivator for this feature, among many others. Removing this default would effectively start mal-triggering every single useEffect or === change detection mechanism in every single app that uses React Query.
Converting this to a discussion so we can continue to keep tabs and discuss it.
The issues received by the users when structuralSharing did not exist are this kind of issues "I want this feature", example:
#430
The issues received by the users when structuralSharing was implemented and set to true by default are this kind of issues: "I have a bug and I don't know what is happening", examples:
#1633
#1657 (comment)
"I want this feature" vs "I have a bug"... I think it's easy to decide, having a bug consumes a lot of time. Features that are enabled by default should be the ones that does not generate hard to debug issues or "gotchas". Also the warning for this is well hidden on the documentation, which is not friendly.
The text was updated successfully, but these errors were encountered: