Skip to content

rename useErrorBoundary #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TkDodo opened this issue Dec 23, 2022 · 1 comment · Fixed by #4697
Closed

rename useErrorBoundary #4677

TkDodo opened this issue Dec 23, 2022 · 1 comment · Fixed by #4697
Assignees
@Moshyfawn
Labels
v5
Milestone
v5

Comments

@TkDodo
Copy link
Collaborator

TkDodo commented Dec 23, 2022

context

A property that starts with the prefix use is unfortunately named, as use usually indicates a hook in React. ErrorBoundary might also be a quite react specific term.

Renaming the property to e.g. throwError would more accurately describe what is happening: the error will be thrown. In React, it will be picked up by the nearest error boundary.

proposal

  • rename useErrorBoundary to throwError
@TkDodo TkDodo added the v5 label Dec 23, 2022
@TkDodo TkDodo added this to the v5 milestone Dec 23, 2022
@Moshyfawn Moshyfawn mentioned this issue Dec 23, 2022
Merged
@TkDodo TkDodo mentioned this issue Dec 25, 2022
Closed
@Moshyfawn
Copy link
Contributor

Moshyfawn commented Dec 28, 2022 •
edited
Loading

Should this issue be assigned to me then?

@TkDodo TkDodo closed this as completed Dec 30, 2022
@TkDodo TkDodo mentioned this issue Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Moshyfawn Moshyfawn

Labels
v5
Projects
None yet
Milestone
v5
Development

Successfully merging a pull request may close this issue.

refactor: rename useErrorBoundar option to throwError
2 participants
@TkDodo @Moshyfawn