Skip to content

Commit feb73bc

Browse files
committed
💚 Update static-analysis Python version to 3.9
Manually disabling spurious error message arising from a bug in pylint for Python 3.9, i.e., ``` pylint...............................................................................Failed - hook id: pylint - exit code: 2 -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) ************* Module structlog_sentry_logger._config structlog_sentry_logger/_config.py:240:18: E1136: Value 'Union' is unsubscriptable (unsubscriptable-object) ------------------------------------------------------------------ Your code has been rated at 9.52/10 (previous run: 9.52/10, +0.00) -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) ``` see: [[Python 3.9] Value 'Optional' is unsubscriptable (unsubscriptable-object) (also Union) #3882](pylint-dev/pylint#3882)
1 parent 99365f7 commit feb73bc

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- uses: "actions/checkout@v2"
2020
- uses: "actions/setup-python@v2"
2121
with:
22-
python-version: "3.8"
22+
python-version: "3.9"
2323
- name: "Install package"
2424
run: |
2525
pip install --constraint=.github/workflows/constraints.txt poetry

.gitlab-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ stages:
5050

5151
static-analysis:
5252
<<: *quality
53-
image: python:3.8
53+
image: python:3.9
5454

5555
dependency-security-vulnerability-analysis:
5656
<<: *install-dev-deps

structlog_sentry_logger/_config.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,9 @@ def __init__( # pylint: disable=too-many-arguments
237237
breadcrumb_level: int = logging.INFO,
238238
active: bool = True,
239239
as_extra: bool = True,
240-
tag_keys: Union[List[str], str] = None,
240+
tag_keys: Union[ # pylint: disable=unsubscriptable-object
241+
List[str], str
242+
] = None,
241243
) -> None:
242244
self.breadcrumb_level = breadcrumb_level
243245
super().__init__(

0 commit comments

Comments
 (0)