Skip to content

Commit a5390c4

Browse files
Windows: Rework kernel32 apis
To facilitate ziglang#19037, this commit slims `std.windows.kernel32` to only have the functions needed by the standard library. Since this will break projects that relied on these, I offer two solutions: - Make an argument as to why certain functions should be added back in. Note that they may just be wrappers around `ntdll` APIs, which would go against ziglang#19037. If necessary I'll add them back in *and* make wrappers in `std.windows` for it. - Maintain your own list of APIs. This is the option taken by bun[1], where they wrap functions with tracing. - Use `zigwin32`. I've also added TODO comments that specify which functions can be reimplemented using `ntdll` APIs in the future. Other changes: - Group functions into groups (I/O, process management etc.). - Synchronize definitions against Microsoft documentation to use the proper parameter types/names. - Break all functions with parameters over multiple lines.
1 parent bf3a54c commit a5390c4

File tree

2 files changed

+425
-323
lines changed

2 files changed

+425
-323
lines changed

lib/std/debug.zig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1906,7 +1906,7 @@ pub const DebugInfo = struct {
19061906
@memcpy(name_buffer[0..4], &[_]u16{ '\\', '?', '?', '\\' });
19071907

19081908
const process_handle = windows.kernel32.GetCurrentProcess();
1909-
const len = windows.kernel32.K32GetModuleFileNameExW(
1909+
const len = windows.kernel32.GetModuleFileNameExW(
19101910
process_handle,
19111911
module.handle,
19121912
@ptrCast(&name_buffer[4]),

0 commit comments

Comments
 (0)