Skip to content

Improve package organizations #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eduardogr opened this issue Oct 9, 2018 · 5 comments · Fixed by #325
Closed

Improve package organizations #36

eduardogr opened this issue Oct 9, 2018 · 5 comments · Fixed by #325

Comments

@eduardogr
Copy link

There's a lot of main packages in this project

sorts/selection_sort.go:1:package main
sorts/Heapsort.go:1:package main
....
....
other/PasswordGenerator.go:5:package main
other/PrimeNumbers.go:1:package main

We can improve this package organization to let each package have its place

@localleon
Copy link
Contributor

+1

This would also fix all the failed golangci-lint test. Currently they fail because multiple people use the package main.

@vdnhi
Copy link
Contributor

vdnhi commented Oct 8, 2020

It's a good idea. I'm trying to fix this (both package and filename convention). I'm starting with sorts. You're welcome to help with other parts.

@eduardogr
Copy link
Author

How is this going? Do you need help with this?

@vedantmamgain
Copy link
Contributor

@eduardogr That would be great if you can improve the package organization.

@tjgurwara99
Copy link
Member

tjgurwara99 commented Mar 2, 2021

I believe this issue has been resolved with the PR #266. Now it only remains for us to add tests for each function so that everything works as the implementor expects it to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants