Skip to content

Including a space after "templateUrl" causes the router to throw "Failed to load <template>" #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sky-coding opened this issue Jun 28, 2016 · 3 comments · Fixed by #11

Comments

@sky-coding
Copy link
Contributor

Including a space after templateUrl, e.g. templateUrl : './home.template.html' instead of templateUrl: './home.template.html' causes the router to throw Failed to load about.template.html at runtime.

Obviously this can be worked around, but a coworker who prefers spaces after his properties was about ready to flip his keyboard today when trying to load a template, and this could be a gotcha for other developers unaware of this restriction.

PatrickJS/PatrickJS-starter#733 (comment)

@TheLarkInn
Copy link
Owner

Nice catch. I'll take a PR, only cause I'm swamped I can look Into this in a few days.

@TheLarkInn
Copy link
Owner

Ohhhhhhh regex...

@sky-coding
Copy link
Contributor Author

Done, thanks for creating and maintaining this loader!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants