Skip to content

Commit 65441ba

Browse files
AvasamToufool
andauthored
Hooked new settings window to actual values (#151)
* Initial UI update for 2.0.0. Add settings window. * hooked new settings window to actual values * Better "seconds remaining" text * Undo split goes to the end of the group Co-authored-by: Austin <[email protected]>
1 parent bbb257f commit 65441ba

19 files changed

+532
-432
lines changed

.flake8

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ per-file-ignores=
1212
__init__.pyi:Q000
1313
; PyQt methods
1414
ignore-names=closeEvent,paintEvent,keyPressEvent,mousePressEvent,mouseMoveEvent,mouseReleaseEvent
15-
; McCabe max-complexity is also taken care of by Pylint and doesn't fail teh build there
15+
; McCabe max-complexity is also taken care of by Pylint and doesn't fail the build there
1616
; So this is the hard limit
1717
max-complexity=32
1818
inline-quotes="

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ This program can be used to automatically start, split, and reset your preferred
116116
- {d} dummy split image. When matched, it moves to the next image without hitting your split hotkey.
117117
- {b} split when similarity goes below the threshold rather than above. When a split image filename has this flag, the split image similarity will go above the threshold, do nothing, and then split the next time the similarity goes below the threshold.
118118
- {p} pause flag. When a split image filename has this flag, it will hit your pause hotkey rather than your split hokey.
119-
- A pause flag and a dummy flag `{pd}` cannot be used together
120119
- Filename examples:
121120
- `001_SplitName_(0.9)_[10].png` is a split image with a threshold of 0.9 and a pause time of 10 seconds.
122121
- `002_SplitName_(0.9)_[10]_{d}.png` is the second split image with a threshold of 0.9, pause time of 10, and is a dummy split.
@@ -156,9 +155,9 @@ Given these splits: 1 dummy, 2 normal, 3 dummy, 4 dummy, 5 normal, 6 normal.
156155
In this situation you would have only 3 splits in LiveSplit/wsplit (even though there are 6 split images, only 3 are "real" splits). This basically results in 3 groups of splits: 1st split is images 1 and 2. 2nd split is images 3, 4 and 5. 3rd split is image 6.
157156

158157
- If you are in the 1st or 2nd image and press the skip key, it will end up on the 3rd image
159-
- If you are in the 3rd, 4th or 5th image and press the undo key, it will end up on the 1st image
158+
- If you are in the 3rd, 4th or 5th image and press the undo key, it will end up on the 2nd image
160159
- If you are in the 3rd, 4th or 5th image and press the skip key, it will end up on the 6th image
161-
- If you are in the 6th image and press the undo key, it will end up on the 3rd image
160+
- If you are in the 6th image and press the undo key, it will end up on the 5th image
162161

163162
### Loop Split Images
164163

pyproject.toml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@ aggressive = 3
1515
[tool.pyright]
1616
pythonPlatform = "Windows"
1717
typeCheckingMode = "strict"
18+
# Extra strict
19+
reportPropertyTypeMismatch=true
20+
reportUninitializedInstanceVariable=true
21+
reportCallInDefaultInitializer=true
22+
reportImplicitStringConcatenation=true
1823
ignore = [
1924
# Auto generated
2025
"src/gen/",

res/design.ui

Lines changed: 41 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<ui version="4.0">
3-
<class>main_window</class>
4-
<widget class="QMainWindow" name="main_window">
3+
<class>MainWindow</class>
4+
<widget class="QMainWindow" name="MainWindow">
55
<property name="geometry">
66
<rect>
77
<x>0</x>
@@ -37,7 +37,7 @@
3737
<string>AutoSplit</string>
3838
</property>
3939
<property name="windowIcon">
40-
<iconset resource="../../Auto-Split/res/resources.qrc">
40+
<iconset resource="resources.qrc">
4141
<normaloff>:/resources/icon.ico</normaloff>:/resources/icon.ico</iconset>
4242
</property>
4343
<property name="whatsThis">
@@ -93,6 +93,9 @@
9393
</property>
9494
</widget>
9595
<widget class="QPushButton" name="reset_button">
96+
<property name="enabled">
97+
<bool>false</bool>
98+
</property>
9699
<property name="geometry">
97100
<rect>
98101
<x>650</x>
@@ -108,7 +111,10 @@
108111
<string>Reset</string>
109112
</property>
110113
</widget>
111-
<widget class="QPushButton" name="undo_button">
114+
<widget class="QPushButton" name="undo_split_button">
115+
<property name="enabled">
116+
<bool>false</bool>
117+
</property>
112118
<property name="geometry">
113119
<rect>
114120
<x>650</x>
@@ -124,7 +130,10 @@
124130
<string>Undo</string>
125131
</property>
126132
</widget>
127-
<widget class="QPushButton" name="skip_button">
133+
<widget class="QPushButton" name="skip_split_button">
134+
<property name="enabled">
135+
<bool>false</bool>
136+
</property>
128137
<property name="geometry">
129138
<rect>
130139
<x>712</x>
@@ -196,6 +205,9 @@
196205
<property name="text">
197206
<string/>
198207
</property>
208+
<property name="alignment">
209+
<set>Qt::AlignCenter</set>
210+
</property>
199211
</widget>
200212
<widget class="QLabel" name="current_split_image">
201213
<property name="geometry">
@@ -212,6 +224,9 @@
212224
<property name="text">
213225
<string/>
214226
</property>
227+
<property name="alignment">
228+
<set>Qt::AlignCenter</set>
229+
</property>
215230
</widget>
216231
<widget class="QLabel" name="current_image_label">
217232
<property name="geometry">
@@ -265,7 +280,7 @@
265280
</rect>
266281
</property>
267282
<property name="text">
268-
<string>9999</string>
283+
<string/>
269284
</property>
270285
</widget>
271286
<widget class="QSpinBox" name="width_spinbox">
@@ -332,7 +347,7 @@
332347
</rect>
333348
</property>
334349
<property name="text">
335-
<string>Image Filename</string>
350+
<string>-</string>
336351
</property>
337352
<property name="alignment">
338353
<set>Qt::AlignCenter</set>
@@ -507,7 +522,7 @@
507522
</rect>
508523
</property>
509524
<property name="text">
510-
<string>Window Name</string>
525+
<string>-</string>
511526
</property>
512527
<property name="alignment">
513528
<set>Qt::AlignCenter</set>
@@ -516,8 +531,8 @@
516531
<widget class="QLabel" name="image_loop_label">
517532
<property name="geometry">
518533
<rect>
519-
<x>450</x>
520-
<y>309</y>
534+
<x>451</x>
535+
<y>313</y>
521536
<width>67</width>
522537
<height>20</height>
523538
</rect>
@@ -796,8 +811,8 @@
796811
<widget class="QLabel" name="start_image_status_label">
797812
<property name="geometry">
798813
<rect>
799-
<x>450</x>
800-
<y>345</y>
814+
<x>449</x>
815+
<y>344</y>
801816
<width>98</width>
802817
<height>16</height>
803818
</rect>
@@ -809,8 +824,8 @@
809824
<widget class="QLabel" name="start_image_status_value_label">
810825
<property name="geometry">
811826
<rect>
812-
<x>551</x>
813-
<y>345</y>
827+
<x>550</x>
828+
<y>344</y>
814829
<width>98</width>
815830
<height>16</height>
816831
</rect>
@@ -822,17 +837,20 @@
822837
<widget class="QLabel" name="image_loop_value_label">
823838
<property name="geometry">
824839
<rect>
825-
<x>519</x>
826-
<y>309</y>
840+
<x>520</x>
841+
<y>313</y>
827842
<width>131</width>
828843
<height>20</height>
829844
</rect>
830845
</property>
831846
<property name="text">
832-
<string>x/x</string>
847+
<string>N/A</string>
833848
</property>
834849
</widget>
835850
<widget class="QPushButton" name="previous_image_button">
851+
<property name="enabled">
852+
<bool>false</bool>
853+
</property>
836854
<property name="geometry">
837855
<rect>
838856
<x>449</x>
@@ -852,6 +870,9 @@
852870
</property>
853871
</widget>
854872
<widget class="QPushButton" name="next_image_button">
873+
<property name="enabled">
874+
<bool>false</bool>
875+
</property>
855876
<property name="geometry">
856877
<rect>
857878
<x>744</x>
@@ -874,8 +895,8 @@
874895
<zorder>select_region_button</zorder>
875896
<zorder>start_auto_splitter_button</zorder>
876897
<zorder>reset_button</zorder>
877-
<zorder>undo_button</zorder>
878-
<zorder>skip_button</zorder>
898+
<zorder>undo_split_button</zorder>
899+
<zorder>skip_split_button</zorder>
879900
<zorder>check_fps_button</zorder>
880901
<zorder>fps_label</zorder>
881902
<zorder>current_image_label</zorder>
@@ -1027,7 +1048,7 @@
10271048
<tabstop>height_spinbox</tabstop>
10281049
</tabstops>
10291050
<resources>
1030-
<include location="../../Auto-Split/res/resources.qrc"/>
1051+
<include location="resources.qrc"/>
10311052
</resources>
10321053
<connections/>
10331054
</ui>

0 commit comments

Comments
 (0)