Skip to content

Commit 8838db0

Browse files
committed
Fixed some blocking typing and linting issues
1 parent d665b5c commit 8838db0

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

src/AutoSplit.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,13 @@ def __init__(self, parent: QWidget | None = None): # pylint: disable=too-many-s
149149
self.action_about_qt_for_python.triggered.connect(about_qt_for_python)
150150
self.action_check_for_updates.triggered.connect(lambda: check_for_updates(self))
151151
self.action_settings.triggered.connect(lambda: open_settings(self))
152-
self.action_save_profile.triggered.connect(lambda: user_profile.save_settings(self))
153-
self.action_save_profile_as.triggered.connect(lambda: user_profile.save_settings_as(self))
152+
# PyQt6 typing is wrong
153+
self.action_save_profile.triggered.connect(
154+
lambda: user_profile.save_settings(self), # pyright: ignore[reportGeneralTypeIssues]
155+
)
156+
self.action_save_profile_as.triggered.connect(
157+
lambda: user_profile.save_settings_as(self), # pyright: ignore[reportGeneralTypeIssues]
158+
)
154159
self.action_load_profile.triggered.connect(lambda: user_profile.load_settings(self))
155160

156161
# Shortcut context can't be set through the designer because of a bug in pyuic6 that generates invalid code

src/capture_method/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ def __contains__(self, other: str):
4848
self(other) # pyright: ignore [reportGeneralTypeIssues] pylint: disable=no-value-for-parameter
4949
except ValueError:
5050
return False
51-
else:
52-
return True
51+
return True
5352

5453

5554
@unique

src/menu_bar.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,10 @@ def __set_readme_link(self):
211211
# HACK: This is a workaround because custom_image_settings_info_label
212212
# simply will not open links with a left click no matter what we tried.
213213
self.readme_link_button.clicked.connect(
214-
lambda: webbrowser.open(f"https://github.com/{GITHUB_REPOSITORY}#readme"),
214+
# PyQt6 typing is wrong
215+
lambda: webbrowser.open( # pyright: ignore[reportGeneralTypeIssues]
216+
f"https://github.com/{GITHUB_REPOSITORY}#readme",
217+
),
215218
)
216219
self.readme_link_button.setStyleSheet("border: 0px; background-color:rgba(0,0,0,0%);")
217220

0 commit comments

Comments
 (0)