Skip to content

Commit a963ae1

Browse files
committed
test: tune test-uv-threadpool-schedule
test-uv-threadpool-schedule has been failing consistently in node-daily-master CI. It also fails consistently on my personal laptop. These changes make it pass consistently with current master but fail consistently with Node.js 10.11 (which was the last release in the 10.x line before the fix that the test is for). It succeeds/fails as expected whether or not I am connected to the network. Fixes: nodejs#25305
1 parent 728505a commit a963ae1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/internet/test-uv-threadpool-schedule.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const assert = require('assert');
1515

1616
const start = Date.now();
1717

18-
const slowIOmax = 100;
18+
const slowIOmax = 10;
1919
let slowIOcount = 0;
2020
let fastIOdone = false;
2121
let slowIOend, fastIOend;
@@ -37,7 +37,7 @@ function onResolve() {
3737
// highly load / platform dependent, so don't be very greedy.
3838
const fastIOtime = fastIOend - start;
3939
const slowIOtime = slowIOend - start;
40-
const expectedMax = slowIOtime / 100;
40+
const expectedMax = slowIOtime / 10;
4141
assert.ok(fastIOtime < expectedMax,
4242
'fast I/O took longer to complete, ' +
4343
`actual: ${fastIOtime}, expected: ${expectedMax}`);

0 commit comments

Comments
 (0)