Skip to content

Turing fails to precompile due to deprecated method dispatches with v1.10 #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChrisRackauckas opened this issue Jul 31, 2024 · 6 comments · Fixed by #2297
Closed

Turing fails to precompile due to deprecated method dispatches with v1.10 #2296

ChrisRackauckas opened this issue Jul 31, 2024 · 6 comments · Fixed by #2297
Assignees

Comments

@ChrisRackauckas
Copy link
Collaborator

  [fce5fe82] Turing v0.33.2
ERROR: LoadError: Wrapping `Vararg` directly in UnionAll is deprecated (wrap the tuple instead).
You may need to write `f(x::Vararg{T})` rather than `f(x::Vararg{<:T})` or `f(x::Vararg{T}) where T` instead of `f(x::Vararg{T} where T)`.

Stacktrace:
  [1] UnionAll(v::TypeVar, t::Any)
    @ Core ./boot.jl:256
  [2] top-level scope
    @ ~/.julia/packages/Turing/axR9Q/src/mcmc/gibbs.jl:69
  [3] include(mod::Module, _path::String)
    @ Base ./Base.jl:495
  [4] include(x::String)
    @ Turing.Inference ~/.julia/packages/Turing/axR9Q/src/mcmc/Inference.jl:1
  [5] top-level scope
    @ ~/.julia/packages/Turing/axR9Q/src/mcmc/Inference.jl:533
  [6] include(mod::Module, _path::String)
    @ Base ./Base.jl:495
  [7] include(x::String)
    @ Turing ~/.julia/packages/Turing/axR9Q/src/Turing.jl:1
  [8] top-level scope
    @ ~/.julia/packages/Turing/axR9Q/src/Turing.jl:50
  [9] include
    @ ./Base.jl:495 [inlined]
 [10] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::String)
    @ Base ./loading.jl:2222
 [11] top-level scope
    @ stdin:3

in expression starting at /home/runner/.julia/packages/Turing/axR9Q/src/mcmc/gibbs.jl:69
in expression starting at /home/runner/.julia/packages/Turing/axR9Q/src/mcmc/Inference.jl:1
in expression starting at /home/runner/.julia/packages/Turing/axR9Q/src/Turing.jl:1

https://github.com/SciML/EasyModelAnalysis.jl/actions/runs/10149953788/job/28065979320?pr=263#step:6:1198

@ChrisRackauckas
Copy link
Collaborator Author

https://github.com/TuringLang/Turing.jl/blob/master/src/mcmc/gibbs.jl#L70

This kind of dispatch is not allowed.

@sunxd3
Copy link
Member

sunxd3 commented Jul 31, 2024

@ChrisRackauckas how do I trigger this error?

If I just do

it precompiles with no error on 1.10.4

@ChrisRackauckas
Copy link
Collaborator Author

Are you running with julia --depwarn=error?

@sunxd3
Copy link
Member

sunxd3 commented Jul 31, 2024

no I wasn't, thanks

@ChrisRackauckas
Copy link
Collaborator Author

Can this get a quick patch release so it can unblock downstream? Thanks.

@sunxd3
Copy link
Member

sunxd3 commented Jul 31, 2024

👍 started the releasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants