Skip to content

tsconfig files list makes source control checkin difficult #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
park9140 opened this issue Apr 17, 2015 · 1 comment
Closed

tsconfig files list makes source control checkin difficult #266

park9140 opened this issue Apr 17, 2015 · 1 comment

Comments

@park9140
Copy link
Contributor

filesGlob is a nice way to reduce churn on file lists in the tsconfig. However, after adding it atom updates the tsconfig ever time you add a file to complete the files list.

I would love to use tsconfig as part of our build process, but having a change to this file every time a new file is added to the project creates massive churn and constant merge conflicts.

Can we make it so the file list cache is posted into a cache file instead that can be separately git ignored?

@basarat
Copy link
Member

basarat commented Apr 18, 2015

file list cache is posted into a cache file

Its not a cache. We evaluate filesGlob irrespective of what files says. The reason why files exist is because the official spec only supports files : https://github.com/TypeStrong/atom-typescript/blob/master/docs/tsconfig.md#tsconfigjson So we actively keep files in match with filesGlob so that you can use the project with stuff like sublime text. Sadly files needs to be in tsconfig.json even though we actually don't care to use it in presence of filesGlob. 🌹

@basarat basarat closed this as completed Apr 18, 2015
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants