Skip to content

Non-standard tsconfig.json keys, group under atom-typescript key? #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Meligy opened this issue Oct 13, 2015 · 3 comments
Closed

Non-standard tsconfig.json keys, group under atom-typescript key? #662

Meligy opened this issue Oct 13, 2015 · 3 comments

Comments

@Meligy
Copy link

Meligy commented Oct 13, 2015

I noticed the key externalTranspiler (#475) in the FAQ and was very happy about it. It got me quite confused when I ran tsc from terminal though I got different results

So, you see, this is an awesome feature (and I really mean it), but it introduces confusion, because its using what looks like TypeScript configuration tsconfig.json.

Would it make sense to move the keys like externalTranspiler under a new root key like atom-typescript?

It would also apply to options (#521), and any other non tsc keys.

@basarat
Copy link
Member

basarat commented Oct 14, 2015

This has been discussed before. But its a breaking change that isn't planed in the near future. Sorry 🌹

@Meligy
Copy link
Author

Meligy commented Oct 14, 2015

Is it possible to consider a depreciation cycle?

Deprecate the old option for a release or 2 and encourage users to move to the new keys, and eventually kill the old keys?

Thanks a lot.

@basarat
Copy link
Member

basarat commented Oct 14, 2015

There is a concern about making these features locked into atom-ts, e.g. filesGlob is fairly widely supported (because it is something that really should be in tsconfig to begin with).

See previous discussion : #594 (comment) 🌹

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants