Auto import feature

[cevek]

Webstorm have cool feature like auto import entities from indexed files

for example we are typing: new Foo() and WS prompt "import Foo from 'foo.ts'?" if we says yes, then it append to header import {Foo} from './deep/folder/path/foo'

[basarat]

Cool. Some guidance : https://github.com/TypeStrong/atom-typescript/blob/master/docs/quickfix.md

⚠️ Its hard stuff that needs close attention ... so instead of marking up for grabs marking as wishlist as I value contributor time and effort 🌹

[cevek]

Great!
But why import foo = require('../foo') instead of import {foo} from '../foo'?

[basarat]

why import foo = require('../foo') instead of import {foo} from '../foo'?

import foo = is not the same as import {foo}. it is more like import * as foo 🌹

[jschwarty]

I have a PR (#791) submitted that adds a quick fix option for an "import from" statement.

[ambition-consulting]

I got a missing dependency "Cannot find name ", but get no quick fix suggestion. I am on version 7.16.1. Any advice?

Thanks for your work - this feature is much needed.

[basarat]

@amb-it-ion can you share the code snippet. Might be the canProvideFix check is not valid for your code https://github.com/TypeStrong/atom-typescript/pull/791/files#diff-8fa30ff973791698c79754125ec84700R39

[dawidk92]

+1

[Regaddi]

+1

[sharpmachine]

+1

[basarat]

Please note that the TypeScript team is investigating a QuickFix api similar to Refactor api. Everyone is ofcourse is free to do whatever, this was just info 🌹

[satanworker]

Sorry, guys but is it working right now?
really want to use atom with TS, but without auto import feature like in Webstrom, feels really akward :)

[gvlekke]

+1

[jonaskello]

+1 This is the reason I stay with Webstorm. There is a package that does this for regular js. Could it be ported to work for ts?

[fernandogomesdf]

+1

[tuliogoiania]

please 👍

[jonaskello]

If I understand correctly this PR adds this feature to the TS language service. If that is true I guess it is just a matter of connecting it.

[dogancana]

+1

I"m a noob in atom but maybe https://atom.io/packages/typescript-modules-helper this one could be helpful.

[ctretyak]

i need it!

[guncha]

I need it too!! 😄

[elvnthaus]

please please +1

[harrydroid]

Please I need it too, I had switched to VisualCode Studio

[Goodwine]

@dogancana, This package does help but it's not good enough.
For example in my tsconfig I have paths:{ "asd": [ "../a/s/d" ] }, files: "../a/s/d/F.ts"
Then when I try to use F, instead of adding import F from 'asd/F' I would get import F from '../../../../../a/s/d/F'

[guncha]

Codefix support that lets you do this sort of thing is now in the latest atom-typescript. To use: put the cursor on identifier where you see the "Cannot find name 'foo'", then press ctrl+enter to show available codefixes. It works with paths option in tsconfig.json, but only if you have specified a single path, not multiple.

[Drabc]

Is there anything special I need to do to set this up? I just tried it and it didn't work
atom 1.18.0
os Fedora 24
atom-typescript 11.0.4

[guncha]

@Drabc There isn't any special setup required, you just need a fairly recent Typescript version. It also might not work because you're trying to auto-import something from node_modules. This only works for imports from files in your project.

[Goodwine]

Same, it does work for me but my binding is alt-enter, try pressing Ctrl-Shift-P and look for "intentions: show" maybe you have it bound to different keys.

[guncha]

Right, I wasn't clear that ctrl+enter is the default for OSX only. For Linux and Windows, it's alt+enter. This is the package we're using for the GUI part of this: https://atom.io/packages/intentions

[AndrewBogushevich]

Using atom 1.18.0 x64 on windows7
atom-typescript 11.0.6
alt+enter => nothing happens
ctrl+shift+p => intentions: show => nothing.
what can be the reason?
@guncha

There isn't any special setup required, you just need a fairly recent Typescript version

what do you mean under install typescript, install atom-typescript package in atom, npm i -g typescript?
P.S. linter errors also doesn't show intentions on alt+enter

[klesun]

Just for info, 2.1.5 < "fairly recent Typescript version" <= 2.4.2

[AndrewBogushevich]

$ npm list -g typescript
+-- @angular/[email protected]
| `-- [email protected]
+-- [email protected]
`-- [email protected]
  `-- [email protected]
    `-- [email protected]

package.json contains angular-cli version of TS(2.2.2)

[xiaobaker]

this is awesome! btw do we support single quote instead of double quote in the autofix?

[kevinlinhaw]

@AndrewBogushevich
Did you get it to work on Windows?
I tried on atom 1.20.0 x64 on both Windows10 and Windows8, no dice.
neither shortcut key and intentions: show command works....

on mac it works perfectly though, any ideas?

[AndrewBogushevich]

@kevinlinhaw
Nope. I've just installed VSCode.

[eugensunic]

Come on guys WHY ISN'T THERE STILL A PACKAGE FOR THIS?!?!

[guncha]

@eugensunic, because you haven't built it.

[juanlet]

this would be super nice