Skip to content

Moving @types from dependencies to dev dependencies #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnman opened this issue Feb 10, 2017 · 4 comments
Closed

Moving @types from dependencies to dev dependencies #418

johnman opened this issue Feb 10, 2017 · 4 comments
Labels
wontfix Declining to implement

Comments

@johnman
Copy link

johnman commented Feb 10, 2017

Hi,

Is it required to have @types in the dependencies of package.json?

Some npm servers do not support @types and this means that it prevents typedoc from being downloaded. As they seem to be types used by typedoc itself is it o.k. to move them to dev dependencies so the npm client doesn't try to down load them when installing typedoc?

Thanks,

John

@blakeembrey
Copy link
Member

blakeembrey commented Feb 10, 2017

Please search existing issues before opening a new one. As for the NPM support, I'd need more information. Seems improbable to just force someone else's restrictions on everyone else.

@blakeembrey blakeembrey added duplicate wontfix Declining to implement labels Feb 10, 2017
@johnman
Copy link
Author

johnman commented Feb 11, 2017

Hi, was 413 the duplicate you mentioned? I checked through them all and that was the closest one although that was talking about an @types issue when trying to use typedoc, my one was a question related to trying to install typedoc and if the @types listed in the dependencies were just dev dependencies and if so would there be an issue moving them to the dev dependencies of package.json. If the move has no impact on the project but helps out enterprises (even if it is a small %) I thought it would be helpful to suggest it. Thanks

@blakeembrey
Copy link
Member

It impacts the project because anyone using it from TypeScript would no longer be able to without manually going through the Typedoc dependency list and installing the @types dependencies themselves.

@blakeembrey
Copy link
Member

To find duplicates, you should search through closed issues also. For instance, there's #408 which you can follow along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix Declining to implement
Projects
None yet
Development

No branches or pull requests

2 participants