Skip to content

Options from plugins not processed in Application#bootstrap #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rbuckton opened this issue Oct 5, 2018 · 2 comments
Closed

Options from plugins not processed in Application#bootstrap #875

rbuckton opened this issue Oct 5, 2018 · 2 comments

Comments

@rbuckton
Copy link

rbuckton commented Oct 5, 2018

In #610 a change was made to Application#bootstrap. In this change, the argument to this.options.read was changed from options to this.options.getRawValues(), however getRawValues only returns the options that were already successfully parsed. At the point those options were parsed, plugins had not yet been loaded (since they depend on Prefetch), so custom options added by plugins are ignored if they are passed as part of the options object.

While this doesn't negatively impact parsing CLI arguments, it means that custom options passed to gulp-typescript are not parsed correctly.

@NeKJ
Copy link

NeKJ commented Jan 30, 2019

I agree, this is a regression for plugins that work with gulp-typedoc and should be fixed. I am afraid it is not easy though as the fix for the CLI case should be kept but find a workaround to make this work gulp-typedoc too. Maybe if the setValue() of Options, added the values regardless if they were declared or not, so the getRawValues() will return all passed-in values and on the second call will be able to retrieve the values of the declared options from plugins?

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 12, 2020

This has now been fixed, see #1016. Will be released in v0.16.0

@Gerrit0 Gerrit0 closed this as completed Jan 12, 2020
@Gerrit0 Gerrit0 removed the bug label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants