-
Notifications
You must be signed in to change notification settings - Fork 41
Towards the first standalone release of netcdftime #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks @jhamman and @dopplershift, that sounds great; indeed I would be happy to help out in wrapping up my open issues. |
I can create a netcdf4-python branch with netcdftime removed. |
I created a nonetcdftime branch in netcdf4-python. I did not remove the utilities that use netcdftime, but they now will raise an ImportError it they are used and netcdftime is not installed. I didn't remove the tests that use netcdftime either, but they are not run if netcdftime is not installed. |
I noticed that one of the tests is failing in master (test_parse_date_tz). I think this is related to issue #17. This needs to be fixed before the first standalone release. |
Folks, I think we're close here. Really, the only blocker to a release is the documentation. @dopplershift - do you think you'll be keen to help with that? We probably also want a Appveyor CI test suite, so I just opened #21. |
pull request #22 is needed for all the netcdf4-python tests to pass. Also, shouldn't _netcdftime.c be generated on the fly and removed from the repo? (this was done in netcdf4-python a release or two ago). It makes development easier, since developers don't need to remember to update _netcdftime.c, but it does add cython as a build-time dependency. Actually, I see in setup.py that _netcdftime.c is being regnerated anyway, so I think it can just be removed from the repo. I went ahead an removed _netcdftime.c in pull request #22. |
@jhamman Yeah, I just need to get in my scipy abstracts first, then I should be good to go. |
Alright, I think we are code complete for an initial release. I'd like to issue a alpha release so we can setup conda-forge and pypi. That will give @dopplershift time to jump in on the documentation stuff. Any objections to tagging |
It might actually make sense to start with a 1.0 release. netcdftime is pretty mature from its development inside netCDF4-Python. |
I guess the real question is: is anyone intending to break the existing interfaces? |
1.0 is fine by me. Any objections? If not, I'll probably make a |
Not that I'm aware of. The main motivation for this split is to drop the dependency of netcdf. My vision, at least in the short term, is for the API to remain as is. |
Then I’d say 1.0 is fine. |
alpha tag has been made: https://github.com/Unidata/netcdftime/releases/tag/v1.0.0a1 pypi upload: https://pypi.org/project/netcdftime/ conda-forge staged recipe: conda-forge/staged-recipes#5189 |
@jswhit Is there any source material for the |
I'm going to make a second release candidate tag. |
anyone opposed to making another cftime tag? |
@jhamman I'm biased, but I say go for it. I have some commits that finish up pydata/xarray#1252 that I'll wait to push until the latest |
New release has been issued. We may be able to issue the full 1.0.0 release after this circulates for a few days/weeks. |
netcdf4-python 1.4.0 is released, the first release that depends on the unbundled cftime. |
Thanks @jswhit - let's try to get a full release of cftime out next week. |
This issue has served us well. Closing now since I just made the 1.0.0 tag, github release, and pypi release. Conda forge is coming soon. Thanks to all who contributed to the port of netcdftime and getting cftime up and going! |
My apologies for getting this started and then letting it slide for so long. I'd like to aim for getting a first release of this package by the end of February.
I have created a milestone on the issue tracker for this release. Some other things to consider:
cc @dopplershift, @spencerkclark, @jswhit
from @dopplershift:
If you could help get the documentation working, I can spend some cycles on getting the test infrastructure working again. I'm hoping @spencerkclark can help wrap up his open issues in that time frame.
The text was updated successfully, but these errors were encountered: