You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we should add netcdftime as a hard dependency to netCDF4-python. The removal of netcdftime in #756 removed the code and the top level API. I'm proposing two changes,
add netcdftime to the install_requires block in setup.py:
Most netcdf4-python users probably want netcdftime, too, and this will ease the transition to a separate package. Otherwise a number of downstream projects will suddenly break when they upgrade to a newer release of netcdf4-python.
If you want to eventually remove the hard dependency on netcdftime, that would be fine, but it would be good to issue warnings for some time so users have time to adapt.
pull request #765. My main concern is that we have binary wheels for all the platforms that netcdf4-python has, so the installation is transparent. Don't want this to generate a whole bunch of netcdf4-python support requests.
I think we should add netcdftime as a hard dependency to netCDF4-python. The removal of netcdftime in #756 removed the code and the top level API. I'm proposing two changes,
install_requires
block insetup.py
:netcdf4-python/setup.py
Lines 6 to 7 in b5aa84e
_netCDF4.pyx
:instead of:
netcdf4-python/netCDF4/_netCDF4.pyx
Lines 1015 to 1019 in b5aa84e
This would also allow for the removal of the wrapper functions from
_netCDF4.pyx
.cc @shoyer
xref pydata/xarray#1933
The text was updated successfully, but these errors were encountered: