Adding UI feedback for incomplete/invalid recorder settings.

Author: jasonm-unity

source/FrameRecorder/Core/Engine/InputSettings.cs

@@ -10,14 +10,15 @@ namespace UnityEngine.FrameRecorder
     public abstract class  RecorderInputSetting : ScriptableObject
     {
         public abstract Type inputType { get; }
+        public abstract bool isValid { get; }
     }
 
     /// <summary>
     /// What is this: 
     /// Motivation  : 
     /// Notes: 
     /// </summary>    
-    public class InputSettings<TInput> : RecorderInputSetting
+    public abstract class InputSettings<TInput> : RecorderInputSetting
     {
         public override Type inputType
         {

source/FrameRecorder/Core/Engine/RecorderSettings.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 
 namespace UnityEngine.FrameRecorder
 {
@@ -70,7 +71,19 @@ public bool fixedDuration
 
         public virtual bool isValid
         {
-            get { return m_FrameRate > 0; }
+            get
+            {
+                if (m_FrameRate == 0)
+                    return false;
+
+                if (m_SourceSettings != null)
+                {
+                    var valid = m_SourceSettings.All(x => x.isValid);
+                    return valid;
+                }
+
+                return true;
+            }
         }
 
         public virtual void OnEnable()

source/FrameRecorder/Inputs/Adam/Editor/AdamBeautySourceEditor.cs

@@ -80,6 +80,12 @@ public override void OnInspectorGUI()
                 renderSize.intValue = m_FinalSize.intValue;
 
             serializedObject.ApplyModifiedProperties();
+
+            if (!(target as AdamBeautyInputSettings).isValid)
+            {
+                EditorGUILayout.HelpBox("Incomplete/Invalid settings", MessageType.Warning);
+            }
+
         }
     }
 

source/FrameRecorder/Inputs/Adam/Engine/AdamBeautyInputSettings.cs

@@ -11,5 +11,12 @@ public class AdamBeautyInputSettings : InputSettings<AdamBeautyInput>
         public float m_SuperKernelScale = 1f;
         public RenderTexture m_RenderTexture;
         public string m_CameraTag;
+
+        public override bool isValid {
+            get
+            {
+                return source == EImageSource.GameDisplay || source == EImageSource.MainCamera; 
+            }
+        }
     }
 }

source/FrameRecorder/Inputs/CBRenderTexture/Editor/CBRenderTextureInputSettingsEditor.cs

@@ -60,8 +60,13 @@ public override void OnInspectorGUI()
 
             EditorGUILayout.PropertyField(m_FlipVertically, new GUIContent("Flip image vertically"));
 
-
             serializedObject.ApplyModifiedProperties();
+
+            if (!(target as CBRenderTextureInputSettings).isValid)
+            {
+                EditorGUILayout.HelpBox("Incomplete/Invalid settings", MessageType.Warning);
+            }
+
         }
     }
 }

source/FrameRecorder/Inputs/CBRenderTexture/Engine/CBRenderTextureInputSettings.cs

@@ -8,5 +8,9 @@ public class CBRenderTextureInputSettings : InputSettings<CBRenderTextureInput>
         public string m_CameraTag;
         public bool m_FlipVertical = false;
         public bool m_PadSize = false;
+
+        public override bool isValid {
+            get { return source != EImageSource.TaggedCamera || !string.IsNullOrEmpty(m_CameraTag); }
+        }
     }
 }

source/FrameRecorder/Inputs/RenderTexture/Editor/RenderTextureInputSettingsEditor.cs

@@ -33,6 +33,11 @@ public override void OnInspectorGUI()
             }
 
             serializedObject.ApplyModifiedProperties();
+
+            if (!(target as RenderTextureInputSettings).isValid)
+            {
+                EditorGUILayout.HelpBox("Incomplete/Invalid settings", MessageType.Warning);
+            }
         }
     }
 }

source/FrameRecorder/Inputs/RenderTexture/Engine/RenderTextureInputSettings.cs

@@ -3,5 +3,13 @@
     public class RenderTextureInputSettings : InputSettings<RenderTextureInput>
     {
         public RenderTexture m_SourceRTxtr;
+
+        public override bool isValid {
+            get
+            {
+                return m_SourceRTxtr != null; 
+            }
+        }
+
     }
 }