refactor: snapshot. merge preparation. Removing old acks, removing unused varia… (#1013)

* snapshot: merge preparation. Removing old acks, removing unused variables

* feat: snapshot. merge preparation. Removing old acks, removing unused variables

Co-authored-by: M. Fatih MAR <[email protected]>

Author: jeffreyrainy

com.unity.multiplayer.mlapi/Runtime/Core/SnapshotSystem.cs

@@ -472,8 +472,6 @@ public void ReadSnapshot(ulong clientId, Stream snapshotStream)
                 snapshot.ReadIndex(reader);
                 snapshot.ReadBuffer(reader, snapshotStream);
             }
-
-            SendAck(clientId, snapshotTick);
         }
 
         public void ReadAck(ulong clientId, Stream snapshotStream)
@@ -485,21 +483,6 @@ public void ReadAck(ulong clientId, Stream snapshotStream)
             }
         }
 
-        public void SendAck(ulong clientId, int tick)
-        {
-            var context = m_NetworkManager.MessageQueueContainer.EnterInternalCommandContext(
-                MessageQueueContainer.MessageType.SnapshotAck, NetworkChannel.SnapshotExchange,
-                new[] { clientId }, NetworkUpdateLoop.UpdateStage);
-
-            if (context != null)
-            {
-                using (var nonNullContext = (InternalCommandContext)context)
-                {
-                    nonNullContext.NetworkWriter.WriteInt32Packed(tick);
-                }
-            }
-        }
-
         // todo --M1--
         // This is temporary debugging code. Once the feature is complete, we can consider removing it
         // But we could also leave it in in debug to help developers

com.unity.multiplayer.mlapi/Runtime/Messaging/InternalMessageHandler.cs

@@ -397,11 +397,6 @@ internal static void HandleSnapshot(ulong clientId, Stream messageStream)
             NetworkManager.Singleton.SnapshotSystem.ReadSnapshot(clientId, messageStream);
         }
 
-        internal static void HandleAck(ulong clientId, Stream messageStream)
-        {
-            NetworkManager.Singleton.SnapshotSystem.ReadAck(clientId, messageStream);
-        }
-
         public void HandleAllClientsSwitchSceneCompleted(ulong clientId, Stream stream)
         {
             using (var reader = PooledNetworkReader.Get(stream))

com.unity.multiplayer.mlapi/Runtime/Messaging/MessageQueue/MessageQueueContainer.cs

@@ -33,7 +33,6 @@ public enum MessageType
             NamedMessage,
             ServerLog,
             SnapshotData,
-            SnapshotAck,
             NetworkVariableDelta,
             SwitchScene,
             ClientSwitchSceneCompleted,

com.unity.multiplayer.mlapi/Runtime/Messaging/MessageQueue/MessageQueueProcessor.cs

@@ -120,9 +120,6 @@ public void ProcessMessage(in MessageFrameItem item)
                     case MessageQueueContainer.MessageType.SnapshotData:
                         InternalMessageHandler.HandleSnapshot(item.NetworkId, item.NetworkBuffer);
                         break;
-                    case MessageQueueContainer.MessageType.SnapshotAck:
-                        InternalMessageHandler.HandleAck(item.NetworkId, item.NetworkBuffer);
-                        break;
                     case MessageQueueContainer.MessageType.NetworkVariableDelta:
                         m_NetworkManager.MessageHandler.HandleNetworkVariableDelta(item.NetworkId, item.NetworkBuffer);
                         break;