fix: 2+ inheritance from network behaviour causes compilation exception (#1078) (#1079)

* fix: 2+ inheritance from network behaviour causes compilation exception (#1078)

* Update com.unity.netcode.gameobjects/Editor/CodeGen/NetworkBehaviourILPP.cs

Co-authored-by: M. Fatih MAR <[email protected]>

* updated comment based on feedback

Co-authored-by: M. Fatih MAR <[email protected]>

Author: becksebenius-unity

com.unity.netcode.gameobjects/Editor/CodeGen/NetworkBehaviourILPP.cs

@@ -595,8 +595,8 @@ private void ProcessNetworkBehaviour(TypeDefinition typeDefinition, string[] ass
 
             // override NetworkBehaviour.__getTypeName() method to return concrete type
             {
-                var baseType = typeDefinition.BaseType.Resolve();
-                var baseGetTypeNameMethod = baseType.Methods.First(p => p.Name.Equals(nameof(NetworkBehaviour.__getTypeName)));
+                var networkBehaviour_TypeDef = m_NetworkBehaviour_TypeRef.Resolve();
+                var baseGetTypeNameMethod = networkBehaviour_TypeDef.Methods.First(p => p.Name.Equals(nameof(NetworkBehaviour.__getTypeName)));
 
                 var newGetTypeNameMethod = new MethodDefinition(
                     nameof(NetworkBehaviour.__getTypeName),

com.unity.netcode.gameobjects/Tests/Editor/NetworkBehaviourTests.cs

@@ -47,14 +47,30 @@ public void AccessNetworkObjectTest()
         }
 
         [Test]
-        public void GetNetworkBehaviourNameTest()
+        public void GivenClassDerivesFromNetworkBehaviour_GetTypeNameReturnsCorrectValue()
         {
-            var gameObject = new GameObject(nameof(GetNetworkBehaviourNameTest));
+            var gameObject = new GameObject(nameof(GivenClassDerivesFromNetworkBehaviour_GetTypeNameReturnsCorrectValue));
             var networkBehaviour = gameObject.AddComponent<EmptyNetworkBehaviour>();
 
             Assert.AreEqual(nameof(EmptyNetworkBehaviour), networkBehaviour.__getTypeName());
         }
 
+        [Test]
+        public void GivenClassDerivesFromNetworkBehaviourDerivedClass_GetTypeNameReturnsCorrectValue()
+        {
+            var gameObject = new GameObject(nameof(GivenClassDerivesFromNetworkBehaviourDerivedClass_GetTypeNameReturnsCorrectValue));
+            var networkBehaviour = gameObject.AddComponent<DerivedNetworkBehaviour>();
+
+            Assert.AreEqual(nameof(DerivedNetworkBehaviour), networkBehaviour.__getTypeName());
+        }
+
+        // Note: in order to repro https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/issues/1078
+        // this child class must be defined before its parent to assure it is processed first by ILPP
+        public class DerivedNetworkBehaviour : EmptyNetworkBehaviour
+        {
+
+        }
+
         public class EmptyNetworkBehaviour : NetworkBehaviour
         {