refactor: BufferManager now uses internal NetworkManager (#746)

Author: TwoTenPvP

com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs

@@ -321,11 +321,11 @@ private void Init(bool server)
             SpawnManager = new NetworkSpawnManager(this);
 
             CustomMessagingManager = new CustomMessagingManager(this);
+            
+            BufferManager = new BufferManager(this);
 
             SceneManager = new NetworkSceneManager(this);
 
-            BufferManager = new BufferManager();
-
             if (MessageHandler == null)
             {
                 // Only create this if it's not already set (like in test cases)

com.unity.multiplayer.mlapi/Runtime/Messaging/Buffering/BufferManager.cs

@@ -24,6 +24,13 @@ internal struct BufferedMessage
             internal float BufferTime;
         }
 
+        private NetworkManager m_NetworkManager { get; }
+
+        internal BufferManager(NetworkManager networkManager)
+        {
+            m_NetworkManager = networkManager;
+        }
+
         internal Queue<BufferedMessage> ConsumeBuffersForNetworkId(ulong networkId)
         {
             if (m_BufferQueues.ContainsKey(networkId))
@@ -77,7 +84,7 @@ internal void CleanBuffer()
 #endif
             foreach (var pair in m_BufferQueues)
             {
-                while (pair.Value.Count > 0 && Time.realtimeSinceStartup - pair.Value.Peek().BufferTime >= NetworkManager.Singleton.NetworkConfig.MessageBufferTimeout)
+                while (pair.Value.Count > 0 && Time.realtimeSinceStartup - pair.Value.Peek().BufferTime >= m_NetworkManager.NetworkConfig.MessageBufferTimeout)
                 {
                     BufferedMessage message = pair.Value.Dequeue();