fix: remove optimization that breaks Unity Transport Adapter (#1205)

* This code breaks the Unity Transport Adapter and assumes specific behavior that wasn't present before, in UTA we assume that these kind of checks are not happening in the SDK. This is because its very possible that you're clientID on the server (which is synchronized via OwnerClientId) and your ServerId could indeed be the same and it shouldn't really matter if they are as one side should not impact the other side. So for this reason we have removed this check.

Author: andrews-unity

com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviour.cs

@@ -68,7 +68,19 @@ internal void __sendServerRpc(ref FastBufferWriter writer, uint rpcMethodId, Ser
                 },
                 RpcData = writer
             };
+
+            // If we are a server/host then we just no op and send to ourself
+            if (IsHost || IsServer)
+            {
+                var tempBuffer = new FastBufferReader(ref writer, Allocator.Temp);
+                message.Handle(ref tempBuffer, NetworkManager, NetworkBehaviourId);
+                tempBuffer.Dispose();
+
+                return;
+            }
+
             var rpcMessageSize = NetworkManager.SendMessage(message, networkDelivery, NetworkManager.ServerClientId, true);
+
 #if DEVELOPMENT_BUILD || UNITY_EDITOR
             if (NetworkManager.__rpc_name_table.TryGetValue(rpcMethodId, out var rpcMethodName))
             {

com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs

@@ -420,23 +420,6 @@ internal unsafe int SendMessage<TMessageType, TClientIdListType>(in TMessageType
                         MessageType = m_MessageTypes[typeof(TMessageType)],
                     };
 
-
-                    if (clientId == m_LocalClientId)
-                    {
-                        m_IncomingMessageQueue.Add(new ReceiveQueueItem
-                        {
-                            Header = header,
-                            Reader = new FastBufferReader(ref tmpSerializer, Allocator.TempJob),
-                            SenderId = clientId,
-                            Timestamp = Time.realtimeSinceStartup
-                        });
-                        for (var hookIdx = 0; hookIdx < m_Hooks.Count; ++hookIdx)
-                        {
-                            m_Hooks[hookIdx].OnAfterSendMessage(clientId, typeof(TMessageType), delivery, tmpSerializer.Length + sizeof(MessageHeader));
-                        }
-                        continue;
-                    }
-
                     writeQueueItem.Writer.WriteValue(header);
                     writeQueueItem.Writer.WriteBytes(tmpSerializer.GetUnsafePtr(), tmpSerializer.Length);
                     writeQueueItem.BatchHeader.BatchSize++;