feat: NetworkAnimator and ClientNetworkAnimator (#1191)

* Split NetworkAnimator into Client and Server auth versions

 - extracted the abstract base-class NetworkAnimator
 - ClientNetworkAnimator lives in Samples folder and is overriding NetworkAnimator to show client-authority
 - ServerNetworkAnimator lives in Components and is server-controlled.
 - updated the test scene to use two versions of the components
 - optimized unnecessary LINQ usage that caused GC pressure + caching the values to avoid invoking LINQ repeatedly
 - added capability for NetworkAnimator to be late-initialized by means of TryInitialize(Animator animator) method - it would allow to choose the Mecanim Animator component to sync later than on object spawn.

* This is a blank commit

* removed servernetworkanimator

* optimization pass

* #

* fixed NetowrkAnimator applying animatorstate to itself twice when when IsHost and dealing with ClientNetworkAnimator

* reverted a logic change in the order in which the synced animator parameters are applied to the animator

* standards.py fix

* Serializer api changed - updated the code accordingly

* Jeff's comments

* Luke's comments 1

* yamato standards

Author: pdeschain

com.unity.netcode.gameobjects/Components/NetworkAnimator.cs

@@ -0,0 +1,17 @@
+{
+    "name": "ClientNetworkAnimator",
+    "rootNamespace": "",
+    "references": [
+        "GUID:1491147abca9d7d4bb7105af628b223e",
+        "GUID:3b8ed52f1b5c64994af4c4e0aa4b6c4b"
+    ],
+    "includePlatforms": [],
+    "excludePlatforms": [],
+    "allowUnsafeCode": false,
+    "overrideReferences": false,
+    "precompiledReferences": [],
+    "autoReferenced": true,
+    "defineConstraints": [],
+    "versionDefines": [],
+    "noEngineReferences": false
+}

com.unity.netcode.gameobjects/Samples/ClientNetworkAnimator.meta

@@ -0,0 +1,13 @@
+using UnityEngine;
+
+namespace Unity.Netcode.Components
+{
+    /// <summary>
+    /// A prototype component for syncing Mecanim Animator state in a client-driven manner
+    /// </summary>
+    [AddComponentMenu("Netcode/" + nameof(ClientNetworkAnimator))]
+    public class ClientNetworkAnimator : NetworkAnimator
+    {
+        public override bool CanCommitToAnimator => IsClient && IsOwner;
+    }
+}

com.unity.netcode.gameobjects/Samples/ClientNetworkAnimator/Scripts.meta

@@ -24,11 +24,13 @@ public override void OnNetworkSpawn()
             {
                 enabled = false;
             }
+
+            transform.position += Vector3.up * NetworkObject.NetworkObjectId * 1.1f;
         }
 
         private void Update()
         {
-            if (m_NetworkAnimator.IsAuthorityOverAnimator)
+            if (m_NetworkAnimator.CanCommitToAnimator)
             {
                 if (Input.GetKeyDown(KeyCode.C))
                 {

com.unity.netcode.gameobjects/Samples/ClientNetworkAnimator/Scripts/ClientNetworkAnimator.asmdef

@@ -205,7 +205,7 @@ GameObject:
   - component: {fileID: 3078684836441782554}
   - component: {fileID: 3078684836448737212}
   - component: {fileID: 5295167410665083249}
-  - component: {fileID: 1923420541903188985}
+  - component: {fileID: 2947719363456079390}
   m_Layer: 0
   m_Name: NetworkAnimatedCube-Server
   m_TagString: Untagged
@@ -259,7 +259,7 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: b322be05414199349ae9d1aea28228a7, type: 3}
   m_Name: 
   m_EditorClassIdentifier: 
---- !u!114 &1923420541903188985
+--- !u!114 &2947719363456079390
 MonoBehaviour:
   m_ObjectHideFlags: 0
   m_CorrespondingSourceObject: {fileID: 0}
@@ -271,7 +271,6 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: e8d0727d5ae3244e3b569694d3912374, type: 3}
   m_Name: 
   m_EditorClassIdentifier: 
-  AnimatorAuthority: 0
   m_SendRate: 0.1
   m_Animator: {fileID: 3078684836448737212}
 --- !u!1 &3078684837583100501
@@ -285,7 +284,7 @@ GameObject:
   - component: {fileID: 3078684837582866037}
   - component: {fileID: 3078684837575715027}
   - component: {fileID: 5295167409644547614}
-  - component: {fileID: 1923420540885290134}
+  - component: {fileID: 3269142352356460003}
   m_Layer: 0
   m_Name: NetworkAnimatedCube-Owner
   m_TagString: Untagged
@@ -339,7 +338,7 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: b322be05414199349ae9d1aea28228a7, type: 3}
   m_Name: 
   m_EditorClassIdentifier: 
---- !u!114 &1923420540885290134
+--- !u!114 &3269142352356460003
 MonoBehaviour:
   m_ObjectHideFlags: 0
   m_CorrespondingSourceObject: {fileID: 0}
@@ -348,10 +347,9 @@ MonoBehaviour:
   m_GameObject: {fileID: 3078684837583100501}
   m_Enabled: 1
   m_EditorHideFlags: 0
-  m_Script: {fileID: 11500000, guid: e8d0727d5ae3244e3b569694d3912374, type: 3}
+  m_Script: {fileID: 11500000, guid: f839a28093074169908367d71e143570, type: 3}
   m_Name: 
   m_EditorClassIdentifier: 
-  AnimatorAuthority: 1
   m_SendRate: 0.1
   m_Animator: {fileID: 3078684837575715027}
 --- !u!1 &3214090167966542413
@@ -470,7 +468,7 @@ RectTransform:
   m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}
   m_AnchorMin: {x: 0, y: 0}
   m_AnchorMax: {x: 0, y: 0}
-  m_AnchoredPosition: {x: 0, y: 0}
+  m_AnchoredPosition: {x: 0, y: 3.14}
   m_SizeDelta: {x: 10, y: 10}
   m_Pivot: {x: 0.5, y: 0.5}
 --- !u!223 &3214090169133903738
@@ -612,7 +610,7 @@ MonoBehaviour:
     m_HorizontalOverflow: 0
     m_VerticalOverflow: 0
     m_LineSpacing: 1
-  m_Text: Owner Authority
+  m_Text: Client Authority
 --- !u!1 &3214090169675393154
 GameObject:
   m_ObjectHideFlags: 0

com.unity.netcode.gameobjects/Samples/ClientNetworkAnimator/Scripts/ClientNetworkAnimator.asmdef.meta

@@ -38,7 +38,7 @@ RenderSettings:
   m_ReflectionIntensity: 1
   m_CustomReflection: {fileID: 0}
   m_Sun: {fileID: 0}
-  m_IndirectSpecularColor: {r: 0.44657898, g: 0.4964133, b: 0.5748178, a: 1}
+  m_IndirectSpecularColor: {r: 0.44657874, g: 0.49641275, b: 0.5748172, a: 1}
   m_UseRadianceAmbientProbe: 0
 --- !u!157 &3
 LightmapSettings:
@@ -133,8 +133,8 @@ GameObject:
   m_Component:
   - component: {fileID: 57527693}
   - component: {fileID: 57527692}
-  - component: {fileID: 57527691}
   - component: {fileID: 57527694}
+  - component: {fileID: 57527691}
   m_Layer: 0
   m_Name: NetworkManager
   m_TagString: Untagged
@@ -151,11 +151,16 @@ MonoBehaviour:
   m_GameObject: {fileID: 57527690}
   m_Enabled: 1
   m_EditorHideFlags: 0
-  m_Script: {fileID: 11500000, guid: fc5ef7b69296d69458910681f29471e6, type: 3}
+  m_Script: {fileID: 11500000, guid: b84c2d8dfe509a34fb59e2b81f8e1319, type: 3}
   m_Name: 
   m_EditorClassIdentifier: 
-  Port: 7777
-  Address: 127.0.0.1
+  MessageBufferSize: 5120
+  MaxConnections: 100
+  MaxSentMessageQueueSize: 128
+  ConnectAddress: 127.0.0.1
+  ConnectPort: 7777
+  ServerListenPort: 7777
+  MessageSendMode: 0
 --- !u!114 &57527692
 MonoBehaviour:
   m_ObjectHideFlags: 0
@@ -174,9 +179,6 @@ MonoBehaviour:
   NetworkConfig:
     ProtocolVersion: 0
     NetworkTransport: {fileID: 57527691}
-    RegisteredScenes:
-    - NetworkAnimatorEnhancement
-    AllowRuntimeSceneChanges: 0
     PlayerPrefab: {fileID: 3214090169675393154, guid: 978fc8cd63a1294438ebf3b352814970,
       type: 3}
     NetworkPrefabs:
@@ -187,24 +189,19 @@ MonoBehaviour:
         type: 3}
       SourceHashToOverride: 0
       OverridingTargetPrefab: {fileID: 0}
-    ReceiveTickrate: 64
-    NetworkTickIntervalSec: 0.05
-    MaxReceiveEventsPerTickRate: 500
-    EventTickrate: 64
+    TickRate: 30
     ClientConnectionBufferTimeout: 10
     ConnectionApproval: 0
     ConnectionData: 
     EnableTimeResync: 0
     TimeResyncInterval: 30
-    EnableNetworkVariable: 1
     EnsureNetworkVariableLengthSafety: 0
     EnableSceneManagement: 1
     ForceSamePrefabs: 1
     RecycleNetworkIds: 1
     NetworkIdRecycleDelay: 120
     RpcHashSize: 0
     LoadSceneTimeOut: 120
-    EnableMessageBuffering: 1
     MessageBufferTimeout: 20
     EnableNetworkLogs: 1
 --- !u!4 &57527693