Remove monitor (#3372)

* Removing the monitor

* Editing the migrating docs

* Readding the Monitor in the examples folder

* Editing the Migrating doc

Author: vincentpierre

Project/Assets/ML-Agents/Examples/FoodCollector/Scripts/FoodCollectorAgent.cs

@@ -32,7 +32,6 @@ public override void InitializeAgent()
     {
         base.InitializeAgent();
         m_AgentRb = GetComponent<Rigidbody>();
-        Monitor.verticalOffset = 1f;
         m_MyArea = area.GetComponent<FoodCollectorArea>();
         m_FoodCollecterSettings = FindObjectOfType<FoodCollectorSettings>();
 

com.unity.ml-agents/Runtime/Monitor.cs renamed to Project/Assets/ML-Agents/Examples/SharedAssets/Scripts/Monitor.cs

@@ -1,4 +1,4 @@
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Linq;
 using UnityEngine;
 
@@ -561,4 +561,4 @@ void Initialize()
             s_RedStyle = s_ColorStyle[5];
         }
     }
-}
+}

com.unity.ml-agents/Runtime/Monitor.cs.meta renamed to Project/Assets/ML-Agents/Examples/SharedAssets/Scripts/Monitor.cs.meta

@@ -6,7 +6,7 @@ namespace MLAgentsExamples
     public class ProjectSettingsOverrides : MonoBehaviour
     {
         // Original values
-        float m_OriginalMonitorVerticalOffset;
+
         Vector3 m_OriginalGravity;
         float m_OriginalFixedDeltaTime;
         float m_OriginalMaximumDeltaTime;
@@ -16,9 +16,6 @@ public class ProjectSettingsOverrides : MonoBehaviour
         [Tooltip("Increase or decrease the scene gravity. Use ~3x to make things less floaty")]
         public float gravityMultiplier = 1.0f;
 
-        [Header("Display Settings")]
-        public float monitorVerticalOffset;
-
         [Header("Advanced physics settings")]
         [Tooltip("The interval in seconds at which physics and other fixed frame rate updates (like MonoBehaviour's FixedUpdate) are performed.")]
         public float fixedDeltaTime = .02f;
@@ -32,15 +29,13 @@ public class ProjectSettingsOverrides : MonoBehaviour
         public void Awake()
         {
             // Save the original values
-            m_OriginalMonitorVerticalOffset = Monitor.verticalOffset;
             m_OriginalGravity = Physics.gravity;
             m_OriginalFixedDeltaTime = Time.fixedDeltaTime;
             m_OriginalMaximumDeltaTime = Time.maximumDeltaTime;
             m_OriginalSolverIterations = Physics.defaultSolverIterations;
             m_OriginalSolverVelocityIterations = Physics.defaultSolverVelocityIterations;
 
             // Override
-            Monitor.verticalOffset = monitorVerticalOffset;
             Physics.gravity *= gravityMultiplier;
             Time.fixedDeltaTime = fixedDeltaTime;
             Time.maximumDeltaTime = maximumDeltaTime;
@@ -52,7 +47,6 @@ public void Awake()
 
         public void OnDestroy()
         {
-            Monitor.verticalOffset = m_OriginalMonitorVerticalOffset;
             Physics.gravity = m_OriginalGravity;
             Time.fixedDeltaTime = m_OriginalFixedDeltaTime;
             Time.maximumDeltaTime = m_OriginalMaximumDeltaTime;

Project/Assets/ML-Agents/Examples/SharedAssets/Scripts/ProjectSettingsOverrides.cs

@@ -15,7 +15,6 @@ public class DemonstrationRecorder : MonoBehaviour
     {
         public bool record;
         public string demonstrationName;
-        Agent m_RecordingAgent;
         string m_FilePath;
         DemonstrationStore m_DemoStore;
         public const int MaxNameLength = 16;
@@ -41,15 +40,13 @@ void Update()
         /// </summary>
         public void InitializeDemoStore(IFileSystem fileSystem = null)
         {
-            m_RecordingAgent = GetComponent<Agent>();
             m_DemoStore = new DemonstrationStore(fileSystem);
             var behaviorParams = GetComponent<BehaviorParameters>();
             demonstrationName = SanitizeName(demonstrationName, MaxNameLength);
             m_DemoStore.Initialize(
                 demonstrationName,
                 behaviorParams.brainParameters,
                 behaviorParams.fullyQualifiedBehaviorName);
-            Monitor.Log("Recording Demonstration of Agent: ", m_RecordingAgent.name);
         }
 
         /// <summary>

com.unity.ml-agents/Runtime/DemonstrationRecorder.cs

@@ -8,9 +8,13 @@ The versions can be found in
 # Migrating
 
 ## Migrating from 0.14 to latest
+
 ### Important changes
+* The `Monitor` class has been moved to the Examples Project. (It was prone to errors during testing)
+
 ### Steps to Migrate
 
+
 ## Migrating from 0.13 to 0.14
 
 ### Important changes