Skip to content

Commit c716328

Browse files
Removing the TODO from the committed code.
I made a note in ticket angular#2621 about the type mismatch.
1 parent 979932e commit c716328

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

src/ng/rootScope.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -416,17 +416,6 @@ function $RootScopeProvider(){
416416
return;
417417
}
418418

419-
/* TODO:
420-
*
421-
* - Find a way to stop calling listener for no damned reason:
422-
* - Try checking newChangeNumber against oldChangeNumber
423-
* - If that doesn't work, try setting a boolean in watchCollectionWatch and testing it in watchCollectionAction
424-
*
425-
* - Keep the types the same between oldCollection and newCollection. If you can't find a good way to do that
426-
* in Angular, try setting the prototypes to be the same. This isn't perfect (the objects won't have internal
427-
* state), but it's closer. If neither of these work, you can try casting newCollection to the same type as oldCollection
428-
* and comparing them before calling listener.
429-
*/
430419
var newLength, key, i;
431420

432421
listener(newValue, oldValue, self);

0 commit comments

Comments
 (0)