Skip to content

Commit 9d234fa

Browse files
author
Heather MacDonald
committed
Rename functions for clarity
1 parent 871b3d7 commit 9d234fa

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

deployment/promotion/promote.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -229,17 +229,17 @@ def commit_artifact_part(auth, model_version_id, artifact_key, etag):
229229
return post(auth, path, commit)
230230

231231

232-
def download_artifact(auth, model_version_id, artifact):
232+
def download_artifact_info(auth, model_version_id, artifact):
233233
key = artifact['key']
234234
url = signed_artifact_url(auth, model_version_id, artifact)
235-
print("Downloading artifact '%s'" % key)
235+
print("Downloading artifact info '%s'" % key)
236236
curl_cmd = "curl --cacert %s -o %s %s '%s'" % (
237237
os.environ['REQUESTS_CA_BUNDLE'], key, params['VERTA_CURL_OPTS'], url)
238238
os.system(curl_cmd)
239239

240240

241-
def download_artifacts(auth, model_version_id, artifacts, model_artifact):
242-
print("Downloading %d artifacts" % len(artifacts))
241+
def download_artifacts_info(auth, model_version_id, artifacts, model_artifact):
242+
print("Downloading %d artifacts info" % len(artifacts))
243243

244244
downloaded_artifacts = []
245245
for artifact in artifacts:
@@ -248,7 +248,7 @@ def download_artifacts(auth, model_version_id, artifacts, model_artifact):
248248
'model_version_id': model_version_id
249249
}
250250
copy_fields(['artifact_type', 'key'], artifact, artifact_request)
251-
download_artifact(auth, model_version_id, artifact_request)
251+
download_artifact_info(auth, model_version_id, artifact_request)
252252
downloaded_artifacts.append(
253253
{'key': artifact['key'], 'artifact_type': artifact['artifact_type']})
254254

@@ -257,16 +257,16 @@ def download_artifacts(auth, model_version_id, artifacts, model_artifact):
257257
'model_version_id': model_version_id
258258
}
259259
copy_fields(['artifact_type', 'key'], model_artifact, model_artifact_request)
260-
download_artifact(auth, model_version_id, model_artifact_request)
260+
download_artifact_info(auth, model_version_id, model_artifact_request)
261261

262262
return downloaded_artifacts
263263

264264

265-
def upload_artifact(auth, model_version_id, artifact):
265+
def upload_artifact_info(auth, model_version_id, artifact):
266266
key = artifact['key']
267-
print("Uploading artifact '%s'" % key)
267+
print("Uploading artifact info '%s'" % key)
268268
print(artifact)
269-
269+
270270
artifact_request = {
271271
'method': 'PUT',
272272
'model_version_id': model_version_id,
@@ -300,12 +300,12 @@ def upload_artifact(auth, model_version_id, artifact):
300300
return put_url
301301

302302

303-
def upload_artifacts(auth, model_version_id, artifacts):
304-
print("Uploading %d artifacts" % len(artifacts))
303+
def upload_artifacts_info(auth, model_version_id, artifacts):
304+
print("Uploading %d artifacts info" % len(artifacts))
305305
uploaded_artifacts = {}
306306

307307
for artifact in artifacts:
308-
uploaded_artifacts[artifact["key"]] = upload_artifact(auth, model_version_id, artifact)
308+
uploaded_artifacts[artifact["key"]] = upload_artifact_info(auth, model_version_id, artifact)
309309
return uploaded_artifacts
310310

311311

@@ -339,8 +339,8 @@ def get_promotion_data(_config):
339339
raise SystemExit(1)
340340

341341
model = get_registered_model(source_auth, model_version['registered_model_id'])
342-
artifacts = download_artifacts(source_auth, model_version_id, model_version['artifacts'],
343-
model_version['model'])
342+
artifacts = download_artifacts_info(source_auth, model_version_id, model_version['artifacts'],
343+
model_version['model'])
344344

345345
promotion = {
346346
'build': build,
@@ -433,7 +433,7 @@ def create_promotion(_config, promotion):
433433

434434
artifacts_and_model = promotion['artifacts']
435435
artifacts_and_model.append(model_version['model'])
436-
artifact_paths = upload_artifacts(dest_auth, model_version['id'], artifacts_and_model)
436+
artifact_paths = upload_artifacts_info(dest_auth, model_version['id'], artifacts_and_model)
437437

438438
# Standard RMVs will have artifact path 'model' while ER->RMVs will have artifact path 'model.pkl'
439439
model_artifact = model_version['model']

0 commit comments

Comments
 (0)