diff --git a/common/changes/@visactor/lark-vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-05.json b/common/changes/@visactor/lark-vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-05.json new file mode 100644 index 0000000000..e8af572625 --- /dev/null +++ b/common/changes/@visactor/lark-vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-05.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "fix: add global-scale updateDomain on chart updateData\n\n", + "type": "patch", + "packageName": "@visactor/lark-vchart" + } + ], + "packageName": "@visactor/lark-vchart", + "email": "lixuef1313@163.com" +} \ No newline at end of file diff --git a/common/changes/@visactor/react-vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-05.json b/common/changes/@visactor/react-vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-05.json new file mode 100644 index 0000000000..76c03a5472 --- /dev/null +++ b/common/changes/@visactor/react-vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-05.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "fix: add global-scale updateDomain on chart updateData\n\n", + "type": "patch", + "packageName": "@visactor/react-vchart" + } + ], + "packageName": "@visactor/react-vchart", + "email": "lixuef1313@163.com" +} \ No newline at end of file diff --git a/common/changes/@visactor/taro-vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-05.json b/common/changes/@visactor/taro-vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-05.json new file mode 100644 index 0000000000..c281b68db0 --- /dev/null +++ b/common/changes/@visactor/taro-vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-05.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "fix: add global-scale updateDomain on chart updateData\n\n", + "type": "patch", + "packageName": "@visactor/taro-vchart" + } + ], + "packageName": "@visactor/taro-vchart", + "email": "lixuef1313@163.com" +} \ No newline at end of file diff --git a/common/changes/@visactor/vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-05.json b/common/changes/@visactor/vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-05.json new file mode 100644 index 0000000000..a4ec918725 --- /dev/null +++ b/common/changes/@visactor/vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-05.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "fix: add global-scale updateDomain on chart updateData\n\n", + "type": "patch", + "packageName": "@visactor/vchart" + } + ], + "packageName": "@visactor/vchart", + "email": "lixuef1313@163.com" +} \ No newline at end of file diff --git a/common/changes/@visactor/vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-12.json b/common/changes/@visactor/vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-12.json new file mode 100644 index 0000000000..6845314a4e --- /dev/null +++ b/common/changes/@visactor/vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-09-12.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@visactor/vchart", + "comment": "fix(global-scale): add global-scale updateDomain on chart updateData", + "type": "patch" + } + ], + "packageName": "@visactor/vchart" +} \ No newline at end of file diff --git a/common/changes/@visactor/vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-11-12.json b/common/changes/@visactor/vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-11-12.json new file mode 100644 index 0000000000..d6acf7e798 --- /dev/null +++ b/common/changes/@visactor/vchart/fix-231-bug-after-updatedata-did-not-call-global-scale-update-domain_2023-07-19-11-12.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@visactor/vchart", + "comment": "fix(data): add miss params of data.parse in chart updateData", + "type": "patch" + } + ], + "packageName": "@visactor/vchart" +} \ No newline at end of file diff --git a/packages/vchart/src/chart/base-chart.ts b/packages/vchart/src/chart/base-chart.ts index e7417580c1..32ac326400 100644 --- a/packages/vchart/src/chart/base-chart.ts +++ b/packages/vchart/src/chart/base-chart.ts @@ -608,10 +608,13 @@ export class BaseChart extends CompilableBase implements IChart { } } - updateData(id: StringOrNumber, data: unknown, options?: IParserOptions) { + updateData(id: StringOrNumber, data: unknown, updateGlobalScale: boolean = true, options?: IParserOptions) { const dv = this._dataSet.getDataView(id as string); if (dv) { - dv.parseNewData(data); + dv.parseNewData(data, options); + } + if (updateGlobalScale) { + this.updateGlobalScaleDomain(); } this.getAllModels().forEach(model => model.onDataUpdate()); } diff --git a/packages/vchart/src/chart/interface/chart.ts b/packages/vchart/src/chart/interface/chart.ts index daa973ed64..7352a3c6ab 100644 --- a/packages/vchart/src/chart/interface/chart.ts +++ b/packages/vchart/src/chart/interface/chart.ts @@ -57,8 +57,9 @@ export interface IChart extends ICompilable { // 使用parse后的数据结构,直接更新数据 updateParseData: (id: string, data: Datum[], options?: IParserOptions) => void; // 使用parse前的原始数据结构更新数据 - updateData: (id: StringOrNumber, data: unknown, options?: IParserOptions) => void; - + updateData: (id: StringOrNumber, data: unknown, updateGlobalScale?: boolean, options?: IParserOptions) => void; + // update scale domain which in GlobalScale + updateGlobalScaleDomain: () => void; //生命周期 created: () => void; transformSpec: (spec: any) => void; diff --git a/packages/vchart/src/core/vchart.ts b/packages/vchart/src/core/vchart.ts index b9916e2482..7c634a56a0 100644 --- a/packages/vchart/src/core/vchart.ts +++ b/packages/vchart/src/core/vchart.ts @@ -511,7 +511,7 @@ export class VChart implements IVChart { return this as unknown as IVChart; } if (this._chart) { - this._chart.updateData(id, data, options); + this._chart.updateData(id, data, true, options); // after layout await this._compiler.renderAsync(); @@ -548,8 +548,9 @@ export class VChart implements IVChart { ): Promise { if (this._chart) { list.forEach(({ id, data, options }) => { - this._chart.updateData(id, data, options); + this._chart.updateData(id, data, false, options); }); + this._chart.updateGlobalScaleDomain(); await this._compiler.renderAsync(); return this as unknown as IVChart; } @@ -578,7 +579,7 @@ export class VChart implements IVChart { return this as unknown as IVChart; } if (this._chart) { - this._chart.updateData(id, data, options); + this._chart.updateData(id, data, true, options); // after layout this._compiler.renderSync(); return this as unknown as IVChart;