From 834fab3a759e492f2e523f7e9c226291667ac287 Mon Sep 17 00:00:00 2001 From: xiaoluoHe Date: Wed, 19 Jul 2023 17:10:27 +0800 Subject: [PATCH] fix: pickable shoule be false if label component is configured `interactive: false` --- ...interactive-pickable_2023-07-19-09-10.json | 10 ++++++++++ packages/vchart/src/component/label/label.ts | 20 ++++++++++++------- 2 files changed, 23 insertions(+), 7 deletions(-) create mode 100644 common/changes/@visactor/vchart/fix-label-interactive-pickable_2023-07-19-09-10.json diff --git a/common/changes/@visactor/vchart/fix-label-interactive-pickable_2023-07-19-09-10.json b/common/changes/@visactor/vchart/fix-label-interactive-pickable_2023-07-19-09-10.json new file mode 100644 index 0000000000..35716535f3 --- /dev/null +++ b/common/changes/@visactor/vchart/fix-label-interactive-pickable_2023-07-19-09-10.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@visactor/vchart", + "comment": "fix(label): pickable shoule be false if label component is configured `interactive: false`", + "type": "patch" + } + ], + "packageName": "@visactor/vchart" +} \ No newline at end of file diff --git a/packages/vchart/src/component/label/label.ts b/packages/vchart/src/component/label/label.ts index b081868881..ce8a9a816e 100644 --- a/packages/vchart/src/component/label/label.ts +++ b/packages/vchart/src/component/label/label.ts @@ -191,13 +191,19 @@ export class Label extends BaseComponent { const labelSpec = baseMark.getLabelSpec() ?? {}; const { smartInvert, offset, overlap, animation } = labelSpec; const interactive = this._interactiveConfig(labelSpec); - return merge({}, configFunc(labelInfo[baseMarks.findIndex(mark => mark === baseMark)]), { - smartInvert, - offset, - animation, - overlap, - ...interactive - }); + return merge( + { + textStyle: { pickable: labelSpec.interactive === true } + }, + configFunc(labelInfo[baseMarks.findIndex(mark => mark === baseMark)]), + { + smartInvert, + offset, + animation, + overlap, + ...interactive + } + ); } }) .encode((datum, element) => {