Rename wasm-delegations[-fields].h to def files (NFC) (#3941)

These files are special in that they use define symbols that are not
defined within those files or other files included in those files; they
are supposed to be defined in source files that include these headers.
This has caused clang-tidy to fail every time these files have changed
because they are not compilable per se.

This PR solves the problem by changing their extension to `def`, which
is also used in LLVM codebase. LLVM has dozens of files like this whose
extension is `def`, which makes these not checked by clang-tidy.

Author: aheejin

CMakeLists.txt

@@ -334,7 +334,7 @@ if(NOT (BUILD_STATIC_LIB AND BYN_INSTALL_TOOLS_ONLY))
     ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
 endif()
 if(NOT BYN_INSTALL_TOOLS_ONLY)
-  install(FILES src/binaryen-c.h src/wasm-delegations.h DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
+  install(FILES src/binaryen-c.h src/wasm-delegations.def DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
 endif()
 
 function(binaryen_add_executable name sources)

src/binaryen-c.cpp

@@ -185,7 +185,7 @@ BinaryenExpressionId BinaryenInvalidId(void) {
     return Expression::Id::CLASS_TO_VISIT##Id;                                 \
   }
 
-#include "wasm-delegations.h"
+#include "wasm-delegations.def"
 
 // External kinds
 

src/binaryen-c.h

@@ -130,7 +130,7 @@ BINARYEN_API BinaryenExpressionId BinaryenInvalidId(void);
 #define DELEGATE(CLASS_TO_VISIT)                                               \
   BINARYEN_API BinaryenExpressionId Binaryen##CLASS_TO_VISIT##Id(void);
 
-#include "wasm-delegations.h"
+#include "wasm-delegations.def"
 
 // External kinds (call to get the value of each; you can cache them)
 

src/ir/ExpressionAnalyzer.cpp

@@ -230,7 +230,7 @@ bool ExpressionAnalyzer::flexibleEqual(Expression* left,
     }                                                                          \
   }
 
-#include "wasm-delegations-fields.h"
+#include "wasm-delegations-fields.def"
 
       return true;
     }
@@ -322,7 +322,7 @@ size_t ExpressionAnalyzer::hash(Expression* curr) {
 
 #define DELEGATE_FIELD_SCOPE_NAME_USE(id, name) visitScopeName(cast->name);
 
-#include "wasm-delegations-fields.h"
+#include "wasm-delegations-fields.def"
     }
 
     void noteScopeName(Name curr) {

src/ir/ExpressionManipulator.cpp

@@ -101,7 +101,7 @@ flexibleCopy(Expression* original, Module& wasm, CustomCopier custom) {
 
 #define DELEGATE_FIELD_INT_ARRAY(id, name) COPY_ARRAY(name)
 
-#include "wasm-delegations-fields.h"
+#include "wasm-delegations-fields.def"
 
     // The type can be simply copied.
     copy->type = original->type;

src/ir/branch-utils.h

@@ -66,7 +66,7 @@ template<typename T> void operateOnScopeNameUses(Expression* expr, T func) {
 #define DELEGATE_FIELD_CHILD_VECTOR(id, name)
 #define DELEGATE_FIELD_INT_ARRAY(id, name)
 
-#include "wasm-delegations-fields.h"
+#include "wasm-delegations-fields.def"
 }
 
 // Similar to operateOnScopeNameUses, but also passes in the type that is sent
@@ -131,7 +131,7 @@ template<typename T> void operateOnScopeNameDefs(Expression* expr, T func) {
 #define DELEGATE_FIELD_SCOPE_NAME_USE(id, name)
 #define DELEGATE_FIELD_SCOPE_NAME_USE_VECTOR(id, name)
 
-#include "wasm-delegations-fields.h"
+#include "wasm-delegations-fields.def"
 }
 
 using NameSet = std::set<Name>;

src/ir/iteration.h

@@ -101,7 +101,7 @@ template<class Specific> class AbstractChildIterator {
 #define DELEGATE_FIELD_TYPE(id, name)
 #define DELEGATE_FIELD_ADDRESS(id, name)
 
-#include "wasm-delegations-fields.h"
+#include "wasm-delegations-fields.def"
   }
 
   Iterator begin() const { return Iterator(*this, 0); }

src/ir/utils.h

@@ -113,7 +113,7 @@ struct ReFinalize
 #define DELEGATE(CLASS_TO_VISIT)                                               \
   void visit##CLASS_TO_VISIT(CLASS_TO_VISIT* curr);
 
-#include "wasm-delegations.h"
+#include "wasm-delegations.def"
 
   void visitFunction(Function* curr);
 
@@ -139,7 +139,7 @@ struct ReFinalizeNode : public OverriddenVisitor<ReFinalizeNode> {
 #define DELEGATE(CLASS_TO_VISIT)                                               \
   void visit##CLASS_TO_VISIT(CLASS_TO_VISIT* curr) { curr->finalize(); }
 
-#include "wasm-delegations.h"
+#include "wasm-delegations.def"
 
   void visitExport(Export* curr) { WASM_UNREACHABLE("unimp"); }
   void visitGlobal(Global* curr) { WASM_UNREACHABLE("unimp"); }

src/wasm-delegations-fields.h renamed to src/wasm-delegations-fields.def

@@ -105,7 +105,7 @@ class BinaryInstWriter : public OverriddenVisitor<BinaryInstWriter> {
 #define DELEGATE(CLASS_TO_VISIT)                                               \
   void visit##CLASS_TO_VISIT(CLASS_TO_VISIT* curr);
 
-#include "wasm-delegations.h"
+#include "wasm-delegations.def"
 
   void emitResultType(Type type);
   void emitIfElse(If* curr);

src/wasm-delegations.h renamed to src/wasm-delegations.def

@@ -41,7 +41,7 @@ template<typename SubType, typename ReturnType = void> struct Visitor {
   ReturnType visit##CLASS_TO_VISIT(CLASS_TO_VISIT* curr) {                     \
     return ReturnType();                                                       \
   }
-#include "wasm-delegations.h"
+#include "wasm-delegations.def"
 
   // Module-level visitors
   ReturnType visitExport(Export* curr) { return ReturnType(); }
@@ -62,7 +62,7 @@ template<typename SubType, typename ReturnType = void> struct Visitor {
     return static_cast<SubType*>(this)->visit##CLASS_TO_VISIT(                 \
       static_cast<CLASS_TO_VISIT*>(curr))
 
-#include "wasm-delegations.h"
+#include "wasm-delegations.def"
 
       default:
         WASM_UNREACHABLE("unexpected expression type");
@@ -84,7 +84,7 @@ struct OverriddenVisitor {
     WASM_UNREACHABLE("Derived class must implement visit" #CLASS_TO_VISIT);    \
   }
 
-#include "wasm-delegations.h"
+#include "wasm-delegations.def"
 
   ReturnType visit(Expression* curr) {
     assert(curr);
@@ -95,7 +95,7 @@ struct OverriddenVisitor {
     return static_cast<SubType*>(this)->visit##CLASS_TO_VISIT(                 \
       static_cast<CLASS_TO_VISIT*>(curr))
 
-#include "wasm-delegations.h"
+#include "wasm-delegations.def"
 
       default:
         WASM_UNREACHABLE("unexpected expression type");
@@ -117,7 +117,7 @@ struct UnifiedExpressionVisitor : public Visitor<SubType, ReturnType> {
     return static_cast<SubType*>(this)->visitExpression(curr);                 \
   }
 
-#include "wasm-delegations.h"
+#include "wasm-delegations.def"
 };
 
 //
@@ -327,7 +327,7 @@ struct Walker : public VisitorType {
     self->visit##CLASS_TO_VISIT((*currp)->cast<CLASS_TO_VISIT>());             \
   }
 
-#include "wasm-delegations.h"
+#include "wasm-delegations.def"
 
   void setModule(Module* module) { currModule = module; }
 
@@ -377,7 +377,7 @@ struct PostWalker : public Walker<SubType, VisitorType> {
 #define DELEGATE_FIELD_TYPE(id, name)
 #define DELEGATE_FIELD_ADDRESS(id, name)
 
-#include "wasm-delegations-fields.h"
+#include "wasm-delegations-fields.def"
   }
 };
 

src/wasm-stack.h

@@ -110,7 +110,7 @@ const char* getExpressionName(Expression* curr) {
   case Expression::Id::CLASS_TO_VISIT##Id:                                     \
     return #CLASS_TO_VISIT;
 
-#include "wasm-delegations.h"
+#include "wasm-delegations.def"
 
     default:
       WASM_UNREACHABLE("invalid id");