Skip to content

Can we stop using PR diffs for discussions? #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kg opened this issue Jul 24, 2015 · 3 comments
Closed

Can we stop using PR diffs for discussions? #282

kg opened this issue Jul 24, 2015 · 3 comments
Milestone

Comments

@kg
Copy link
Contributor

kg commented Jul 24, 2015

The comments on diffs get really hard to follow since they go away when the PR changes, and I keep seeing super hosed megaquotes with broken formatting show up in my inbox in an unreadable format. When I try to find them in the PR I can't find them.

If we could stick to doing most of our threaded discussion in the issue section of the PR, or in issues, that problem will go away.

@creationix
Copy link

I was thinking about this today as well. I think inline comments in the diff are best for short-lived comments on that code. Like for example, pointing out a typo. We actually want our comment to go away once the typo is fixed.

@qwertie
Copy link

qwertie commented Jul 24, 2015

Ahh, I kept wondering why all those messages in my email weren't showing up on the web site!

@sunfishcode
Copy link
Member

It's a good suggestion. We should try to do this more.

I'm closing the issue now because it's served its purpose :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants