Skip to content

Commit 92fa2c7

Browse files
committed
Merge pull request #127 from WebAssembly/cleanups
Use underscores in token names
2 parents 396ce60 + 4789324 commit 92fa2c7

File tree

2 files changed

+34
-34
lines changed

2 files changed

+34
-34
lines changed

ml-proto/host/lexer.mll

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -136,26 +136,26 @@ rule token = parse
136136
| "case" { CASE }
137137
| "fallthrough" { FALLTHROUGH }
138138
| "call" { CALL }
139-
| "call_import" { CALLIMPORT }
140-
| "call_indirect" { CALLINDIRECT }
139+
| "call_import" { CALL_IMPORT }
140+
| "call_indirect" { CALL_INDIRECT }
141141
| "return" { RETURN }
142142

143-
| "get_local" { GETLOCAL }
144-
| "set_local" { SETLOCAL }
143+
| "get_local" { GET_LOCAL }
144+
| "set_local" { SET_LOCAL }
145145

146146
| (nxx as t)".load" { LOAD (memop t "") }
147147
| (nxx as t)".load/"(align as a) { LOAD (memop t a) }
148148
| (nxx as t)".store" { STORE (memop t "") }
149149
| (nxx as t)".store/"(align as a) { STORE (memop t a) }
150150

151151
| (ixx as t)".load"(mem_size as sz)"_"(sign as s)
152-
{ LOADEXTEND (extendop t sz s "") }
152+
{ LOAD_EXTEND (extendop t sz s "") }
153153
| (ixx as t)".load"(mem_size as sz)"_"(sign as s)"/"(align as a)
154-
{ LOADEXTEND (extendop t sz s a) }
154+
{ LOAD_EXTEND (extendop t sz s a) }
155155
| (ixx as t)".store"(mem_size as sz)
156-
{ STOREWRAP (wrapop t sz "") }
156+
{ STORE_WRAP (wrapop t sz "") }
157157
| (ixx as t)".store"(mem_size as sz)"/"(align as a)
158-
{ STOREWRAP (wrapop t sz a) }
158+
{ STORE_WRAP (wrapop t sz a) }
159159

160160
| (nxx as t)".switch" { SWITCH (value_type t) }
161161
| (nxx as t)".const" { CONST (value_type t) }
@@ -237,9 +237,9 @@ rule token = parse
237237
| "i32.reinterpret/f32" { CONVERT (Values.Int32 Int32Op.ReinterpretFloat) }
238238
| "i64.reinterpret/f64" { CONVERT (Values.Int64 Int64Op.ReinterpretFloat) }
239239

240-
| "page_size" { PAGESIZE }
241-
| "memory_size" { MEMORYSIZE }
242-
| "resize_memory" { RESIZEMEMORY }
240+
| "page_size" { PAGE_SIZE }
241+
| "memory_size" { MEMORY_SIZE }
242+
| "resize_memory" { RESIZE_MEMORY }
243243

244244
| "func" { FUNC }
245245
| "param" { PARAM }
@@ -252,10 +252,10 @@ rule token = parse
252252
| "export" { EXPORT }
253253
| "table" { TABLE }
254254

255-
| "assert_invalid" { ASSERTINVALID }
256-
| "assert_return" { ASSERTRETURN }
257-
| "assert_return_nan" { ASSERTRETURNNAN }
258-
| "assert_trap" { ASSERTTRAP }
255+
| "assert_invalid" { ASSERT_INVALID }
256+
| "assert_return" { ASSERT_RETURN }
257+
| "assert_return_nan" { ASSERT_RETURN_NAN }
258+
| "assert_trap" { ASSERT_TRAP }
259259
| "invoke" { INVOKE }
260260

261261
| name as s { VAR s }

ml-proto/host/parser.mly

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,12 @@ let anon_label c = {c with labels = VarMap.map ((+) 1) c.labels}
9595

9696
%token INT FLOAT TEXT VAR TYPE LPAR RPAR
9797
%token NOP BLOCK IF LOOP LABEL BREAK SWITCH CASE FALLTHROUGH
98-
%token CALL CALLIMPORT CALLINDIRECT RETURN
99-
%token GETLOCAL SETLOCAL LOAD STORE
98+
%token CALL CALL_IMPORT CALL_INDIRECT RETURN
99+
%token GET_LOCAL SET_LOCAL LOAD STORE
100100
%token CONST UNARY BINARY COMPARE CONVERT
101101
%token FUNC PARAM RESULT LOCAL MODULE MEMORY SEGMENT IMPORT EXPORT TABLE
102-
%token PAGESIZE MEMORYSIZE RESIZEMEMORY
103-
%token ASSERTINVALID ASSERTRETURN ASSERTRETURNNAN ASSERTTRAP INVOKE
102+
%token PAGE_SIZE MEMORY_SIZE RESIZE_MEMORY
103+
%token ASSERT_INVALID ASSERT_RETURN ASSERT_RETURN_NAN ASSERT_TRAP INVOKE
104104
%token EOF
105105

106106
%token<string> INT
@@ -116,8 +116,8 @@ let anon_label c = {c with labels = VarMap.map ((+) 1) c.labels}
116116
%token<Ast.cvt> CONVERT
117117
%token<Ast.memop> LOAD
118118
%token<Ast.memop> STORE
119-
%token<Ast.extop> LOADEXTEND
120-
%token<Ast.wrapop> STOREWRAP
119+
%token<Ast.extop> LOAD_EXTEND
120+
%token<Ast.wrapop> STORE_WRAP
121121

122122
%nonassoc LOW
123123
%nonassoc VAR
@@ -186,23 +186,23 @@ expr1 :
186186
fun c -> let c', l = $2 c in let cs, e = $4 c' in
187187
switch (l, $1 @@ at1, $3 c', List.map (fun a -> a $1) cs, e) }
188188
| CALL var expr_list { fun c -> call ($2 c func, $3 c) }
189-
| CALLIMPORT var expr_list { fun c -> call_import ($2 c import, $3 c) }
190-
| CALLINDIRECT var expr expr_list
189+
| CALL_IMPORT var expr_list { fun c -> call_import ($2 c import, $3 c) }
190+
| CALL_INDIRECT var expr expr_list
191191
{ fun c -> call_indirect ($2 c table, $3 c, $4 c) }
192-
| GETLOCAL var { fun c -> get_local ($2 c local) }
193-
| SETLOCAL var expr { fun c -> set_local ($2 c local, $3 c) }
192+
| GET_LOCAL var { fun c -> get_local ($2 c local) }
193+
| SET_LOCAL var expr { fun c -> set_local ($2 c local, $3 c) }
194194
| LOAD expr { fun c -> load ($1, $2 c) }
195195
| STORE expr expr { fun c -> store ($1, $2 c, $3 c) }
196-
| LOADEXTEND expr { fun c -> load_extend ($1, $2 c) }
197-
| STOREWRAP expr expr { fun c -> store_wrap ($1, $2 c, $3 c) }
196+
| LOAD_EXTEND expr { fun c -> load_extend ($1, $2 c) }
197+
| STORE_WRAP expr expr { fun c -> store_wrap ($1, $2 c, $3 c) }
198198
| CONST literal { fun c -> const (literal $2 $1) }
199199
| UNARY expr { fun c -> unary ($1, $2 c) }
200200
| BINARY expr expr { fun c -> binary ($1, $2 c, $3 c) }
201201
| COMPARE expr expr { fun c -> compare ($1, $2 c, $3 c) }
202202
| CONVERT expr { fun c -> convert ($1, $2 c) }
203-
| PAGESIZE { fun c -> page_size }
204-
| MEMORYSIZE { fun c -> memory_size }
205-
| RESIZEMEMORY expr { fun c -> resize_memory ($2 c) }
203+
| PAGE_SIZE { fun c -> page_size }
204+
| MEMORY_SIZE { fun c -> memory_size }
205+
| RESIZE_MEMORY expr { fun c -> resize_memory ($2 c) }
206206
;
207207
expr_opt :
208208
| /* empty */ { fun c -> None }
@@ -345,13 +345,13 @@ module_ :
345345
346346
cmd :
347347
| module_ { Define $1 @@ at () }
348-
| LPAR ASSERTINVALID module_ TEXT RPAR { AssertInvalid ($3, $4) @@ at () }
348+
| LPAR ASSERT_INVALID module_ TEXT RPAR { AssertInvalid ($3, $4) @@ at () }
349349
| LPAR INVOKE TEXT expr_list RPAR { Invoke ($3, $4 (c0 ())) @@ at () }
350-
| LPAR ASSERTRETURN LPAR INVOKE TEXT expr_list RPAR expr RPAR
350+
| LPAR ASSERT_RETURN LPAR INVOKE TEXT expr_list RPAR expr RPAR
351351
{ AssertReturn ($5, $6 (c0 ()), $8 (c0 ())) @@ at () }
352-
| LPAR ASSERTRETURNNAN LPAR INVOKE TEXT expr_list RPAR RPAR
352+
| LPAR ASSERT_RETURN_NAN LPAR INVOKE TEXT expr_list RPAR RPAR
353353
{ AssertReturnNaN ($5, $6 (c0 ())) @@ at () }
354-
| LPAR ASSERTTRAP LPAR INVOKE TEXT expr_list RPAR TEXT RPAR
354+
| LPAR ASSERT_TRAP LPAR INVOKE TEXT expr_list RPAR TEXT RPAR
355355
{ AssertTrap ($5, $6 (c0 ()), $8) @@ at () }
356356
;
357357
cmd_list :

0 commit comments

Comments
 (0)