Fix #1045

Author: abhinavsingh

proxy/core/connection/connection.py

@@ -50,7 +50,7 @@ def connection(self) -> Union[ssl.SSLSocket, socket.socket]:
 
     def send(self, data: bytes) -> int:
         """Users must handle BrokenPipeError exceptions"""
-        # logger.info(data)
+        logger.info(data)
         return self.connection.send(data)
 
     def recv(
@@ -64,7 +64,7 @@ def recv(
             'received %d bytes from %s' %
             (len(data), self.tag),
         )
-        # logger.info(data)
+        logger.info(data)
         return memoryview(data)
 
     def close(self) -> bool:

proxy/core/connection/server.py

@@ -43,7 +43,7 @@ def connect(
         )
         self.closed = False
 
-    def wrap(self, hostname: str, ca_file: Optional[str]) -> None:
+    def wrap(self, hostname: str, ca_file: Optional[str] = None) -> None:
         ctx = ssl.create_default_context(
             ssl.Purpose.SERVER_AUTH, cafile=ca_file,
         )

proxy/http/server/reverse.py

@@ -21,7 +21,7 @@
 from ...common.utils import text_
 from ...common.constants import (
     DEFAULT_HTTP_PORT, DEFAULT_HTTPS_PORT,
-    DEFAULT_REVERSE_PROXY_ACCESS_LOG_FORMAT,
+    DEFAULT_REVERSE_PROXY_ACCESS_LOG_FORMAT, HTTPS_PROTO,
 )
 
 
@@ -78,12 +78,18 @@ def handle_request(self, request: HttpParser) -> None:
         assert self.upstream
         try:
             self.upstream.connect()
-            if self.choice.scheme == b'https':
+            if self.choice.scheme == HTTPS_PROTO:
                 self.upstream.wrap(
                     text_(
                         self.choice.hostname,
-                    ), ca_file=str(self.flags.ca_file),
+                    ),
                 )
+            # Update Host header
+            if request.has_header(b'Host'):
+                request.del_header(b'Host')
+            request.add_header(
+                b'Host', ('%s:%d' % self.upstream.addr).encode('utf-8'),
+            )
             self.upstream.queue(memoryview(request.build()))
         except ConnectionRefusedError:
             raise HttpProtocolException(

tests/integration/test_integration.sh

@@ -165,7 +165,7 @@ VERIFIED5=$?
 rm downloaded2.whl downloaded2.hash
 
 read -r -d '' REVERSE_PROXY_RESPONSE << EOM
-"Host": "localhost"
+"Host": "httpbin.org"
 EOM
 
 echo "[Test Reverse Proxy Plugin]"