Skip to content

Commit 001602f

Browse files
committed
Don't minify symbols in production builds
This disables symbol renaming in production builds. The original variable and function names are preserved. All other forms of compression applied by Closure (dead code elimination, inlining, etc) are unchanged — the final program is identical to what we were producing before, just in a more readable form. The motivation is to make it easier to debug React issues that only occur in production — the same reason we decided to start shipping sourcemaps in facebook#28827 and facebook#28827. However, because most apps run their own minification step on their npm dependencies, it's not necessary for us to minify the symbols before publishing — it'll be handled the app, if desired. This is the same strategy Meta has used to ship React for years. The React build itself has unminified symbols, but they get minified as part of Meta's regular build pipeline. Even if an app does not minify their npm dependencies, gzip covers most of the cost of symbol renaming anyway. This saves us from having to ship sourcemaps, which means even apps that don't have sourcemaps configured will be able to debug the React build as easily as they would any other npm dependency.
1 parent 0e0b693 commit 001602f

File tree

84 files changed

+103
-262
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

84 files changed

+103
-262
lines changed

dangerfile.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ const SIGNIFICANCE_THRESHOLD = 0.002;
4343
const CRITICAL_ARTIFACT_PATHS = new Set([
4444
// We always report changes to these bundles, even if the change is
4545
// insignificant or non-existent.
46-
'oss-stable/react-dom/cjs/react-dom.production.min.js',
47-
'oss-experimental/react-dom/cjs/react-dom.production.min.js',
46+
'oss-stable/react-dom/cjs/react-dom.production.js',
47+
'oss-experimental/react-dom/cjs/react-dom.production.js',
4848
'facebook-www/ReactDOM-prod.classic.js',
4949
'facebook-www/ReactDOM-prod.modern.js',
5050
]);

fixtures/packaging/systemjs-builder/prod/config.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
System.config({
22
paths: {
3-
react:
4-
'../../../../build/oss-experimental/react/umd/react.production.min.js',
3+
react: '../../../../build/oss-experimental/react/umd/react.production.js',
54
'react-dom':
6-
'../../../../build/oss-experimental/react-dom/umd/react-dom.production.min.js',
5+
'../../../../build/oss-experimental/react-dom/umd/react-dom.production.js',
76
schedule:
87
'../../../../build/oss-experimental/scheduler/umd/schedule.development',
98
},

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@
9494
"shelljs": "^0.8.5",
9595
"signedsource": "^2.0.0",
9696
"targz": "^1.0.1",
97-
"terser": "^5.30.3",
9897
"through2": "^3.0.1",
9998
"tmp": "^0.1.0",
10099
"typescript": "^3.7.5",

packages/eslint-plugin-react-hooks/npm/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// TODO: this doesn't make sense for an ESLint rule.
44
// We need to fix our build process to not create bundles for "raw" packages like this.
55
if (process.env.NODE_ENV === 'production') {
6-
module.exports = require('./cjs/eslint-plugin-react-hooks.production.min.js');
6+
module.exports = require('./cjs/eslint-plugin-react-hooks.production.js');
77
} else {
88
module.exports = require('./cjs/eslint-plugin-react-hooks.development.js');
99
}

packages/jest-react/npm/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/jest-react.production.min.js');
4+
module.exports = require('./cjs/jest-react.production.js');
55
} else {
66
module.exports = require('./cjs/jest-react.development.js');
77
}

packages/react-art/npm/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-art.production.min.js');
4+
module.exports = require('./cjs/react-art.production.js');
55
} else {
66
module.exports = require('./cjs/react-art.development.js');
77
}

packages/react-cache/npm/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-cache.production.min.js');
4+
module.exports = require('./cjs/react-cache.production.js');
55
} else {
66
module.exports = require('./cjs/react-cache.development.js');
77
}

packages/react-client/npm/flight.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-client-flight.production.min.js');
4+
module.exports = require('./cjs/react-client-flight.production.js');
55
} else {
66
module.exports = require('./cjs/react-client-flight.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-debug-tools.production.min.js');
4+
module.exports = require('./cjs/react-debug-tools.production.js');
55
} else {
66
module.exports = require('./cjs/react-debug-tools.development.js');
77
}

packages/react-dom/npm/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ if (process.env.NODE_ENV === 'production') {
3232
// DCE check should happen before ReactDOM bundle executes so that
3333
// DevTools can report bad minification during injection.
3434
checkDCE();
35-
module.exports = require('./cjs/react-dom.production.min.js');
35+
module.exports = require('./cjs/react-dom.production.js');
3636
} else {
3737
module.exports = require('./cjs/react-dom.development.js');
3838
}

packages/react-dom/npm/profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ if (process.env.NODE_ENV === 'production') {
3232
// DCE check should happen before ReactDOM bundle executes so that
3333
// DevTools can report bad minification during injection.
3434
checkDCE();
35-
module.exports = require('./cjs/react-dom.profiling.min.js');
35+
module.exports = require('./cjs/react-dom.profiling.js');
3636
} else {
3737
module.exports = require('./cjs/react-dom.development.js');
3838
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-dom.react-server.production.min.js');
4+
module.exports = require('./cjs/react-dom.react-server.production.js');
55
} else {
66
module.exports = require('./cjs/react-dom.react-server.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-dom-server-rendering-stub.production.min.js');
4+
module.exports = require('./cjs/react-dom-server-rendering-stub.production.js');
55
} else {
66
module.exports = require('./cjs/react-dom-server-rendering-stub.development.js');
77
}

packages/react-dom/npm/server.browser.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
var l, s;
44
if (process.env.NODE_ENV === 'production') {
5-
l = require('./cjs/react-dom-server-legacy.browser.production.min.js');
6-
s = require('./cjs/react-dom-server.browser.production.min.js');
5+
l = require('./cjs/react-dom-server-legacy.browser.production.js');
6+
s = require('./cjs/react-dom-server.browser.production.js');
77
} else {
88
l = require('./cjs/react-dom-server-legacy.browser.development.js');
99
s = require('./cjs/react-dom-server.browser.development.js');

packages/react-dom/npm/server.bun.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
var b;
44
var l;
55
if (process.env.NODE_ENV === 'production') {
6-
b = require('./cjs/react-dom-server.bun.production.min.js');
7-
l = require('./cjs/react-dom-server-legacy.browser.production.min.js');
6+
b = require('./cjs/react-dom-server.bun.production.js');
7+
l = require('./cjs/react-dom-server-legacy.browser.production.js');
88
} else {
99
b = require('./cjs/react-dom-server.bun.development.js');
1010
l = require('./cjs/react-dom-server-legacy.browser.development.js');

packages/react-dom/npm/server.edge.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
var b;
44
var l;
55
if (process.env.NODE_ENV === 'production') {
6-
b = require('./cjs/react-dom-server.edge.production.min.js');
7-
l = require('./cjs/react-dom-server-legacy.browser.production.min.js');
6+
b = require('./cjs/react-dom-server.edge.production.js');
7+
l = require('./cjs/react-dom-server-legacy.browser.production.js');
88
} else {
99
b = require('./cjs/react-dom-server.edge.development.js');
1010
l = require('./cjs/react-dom-server-legacy.browser.development.js');

packages/react-dom/npm/server.node.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
var l, s;
44
if (process.env.NODE_ENV === 'production') {
5-
l = require('./cjs/react-dom-server-legacy.node.production.min.js');
6-
s = require('./cjs/react-dom-server.node.production.min.js');
5+
l = require('./cjs/react-dom-server-legacy.node.production.js');
6+
s = require('./cjs/react-dom-server.node.production.js');
77
} else {
88
l = require('./cjs/react-dom-server-legacy.node.development.js');
99
s = require('./cjs/react-dom-server.node.development.js');

packages/react-dom/npm/static.browser.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
var s;
44
if (process.env.NODE_ENV === 'production') {
5-
s = require('./cjs/react-dom-server.browser.production.min.js');
5+
s = require('./cjs/react-dom-server.browser.production.js');
66
} else {
77
s = require('./cjs/react-dom-server.browser.development.js');
88
}

packages/react-dom/npm/static.edge.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
var s;
44
if (process.env.NODE_ENV === 'production') {
5-
s = require('./cjs/react-dom-server.edge.production.min.js');
5+
s = require('./cjs/react-dom-server.edge.production.js');
66
} else {
77
s = require('./cjs/react-dom-server.edge.development.js');
88
}

packages/react-dom/npm/static.node.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
var s;
44
if (process.env.NODE_ENV === 'production') {
5-
s = require('./cjs/react-dom-server.node.production.min.js');
5+
s = require('./cjs/react-dom-server.node.production.js');
66
} else {
77
s = require('./cjs/react-dom-server.node.development.js');
88
}

packages/react-dom/npm/test-utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-dom-test-utils.production.min.js');
4+
module.exports = require('./cjs/react-dom-test-utils.production.js');
55
} else {
66
module.exports = require('./cjs/react-dom-test-utils.development.js');
77
}

packages/react-dom/npm/unstable_testing.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ if (process.env.NODE_ENV === 'production') {
3232
// DCE check should happen before ReactDOM bundle executes so that
3333
// DevTools can report bad minification during injection.
3434
checkDCE();
35-
module.exports = require('./cjs/react-dom-unstable_testing.production.min.js');
35+
module.exports = require('./cjs/react-dom-unstable_testing.production.js');
3636
} else {
3737
module.exports = require('./cjs/react-dom-unstable_testing.development.js');
3838
}

packages/react-is/npm/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-is.production.min.js');
4+
module.exports = require('./cjs/react-is.production.js');
55
} else {
66
module.exports = require('./cjs/react-is.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-noop-renderer-flight-client.production.min.js');
4+
module.exports = require('./cjs/react-noop-renderer-flight-client.production.js');
55
} else {
66
module.exports = require('./cjs/react-noop-renderer-flight-client.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-noop-renderer-flight-server.production.min.js');
4+
module.exports = require('./cjs/react-noop-renderer-flight-server.production.js');
55
} else {
66
module.exports = require('./cjs/react-noop-renderer-flight-server.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-noop-renderer.production.min.js');
4+
module.exports = require('./cjs/react-noop-renderer.production.js');
55
} else {
66
module.exports = require('./cjs/react-noop-renderer.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-noop-renderer-persistent.production.min.js');
4+
module.exports = require('./cjs/react-noop-renderer-persistent.production.js');
55
} else {
66
module.exports = require('./cjs/react-noop-renderer-persistent.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-noop-renderer-server.production.min.js');
4+
module.exports = require('./cjs/react-noop-renderer-server.production.js');
55
} else {
66
module.exports = require('./cjs/react-noop-renderer-server.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-reconciler-constants.production.min.js');
4+
module.exports = require('./cjs/react-reconciler-constants.production.js');
55
} else {
66
module.exports = require('./cjs/react-reconciler-constants.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-reconciler.production.min.js');
4+
module.exports = require('./cjs/react-reconciler.production.js');
55
} else {
66
module.exports = require('./cjs/react-reconciler.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-reconciler-reflection.production.min.js');
4+
module.exports = require('./cjs/react-reconciler-reflection.production.js');
55
} else {
66
module.exports = require('./cjs/react-reconciler-reflection.development.js');
77
}

packages/react-refresh/npm/babel.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-refresh-babel.production.min.js');
4+
module.exports = require('./cjs/react-refresh-babel.production.js');
55
} else {
66
module.exports = require('./cjs/react-refresh-babel.development.js');
77
}

packages/react-refresh/npm/runtime.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-refresh-runtime.production.min.js');
4+
module.exports = require('./cjs/react-refresh-runtime.production.js');
55
} else {
66
module.exports = require('./cjs/react-refresh-runtime.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-server-dom-esm-client.browser.production.min.js');
4+
module.exports = require('./cjs/react-server-dom-esm-client.browser.production.js');
55
} else {
66
module.exports = require('./cjs/react-server-dom-esm-client.browser.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-server-dom-esm-client.node.production.min.js');
4+
module.exports = require('./cjs/react-server-dom-esm-client.node.production.js');
55
} else {
66
module.exports = require('./cjs/react-server-dom-esm-client.node.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-server-dom-esm-server.node.production.min.js');
4+
module.exports = require('./cjs/react-server-dom-esm-server.node.production.js');
55
} else {
66
module.exports = require('./cjs/react-server-dom-esm-server.node.development.js');
77
}

packages/react-server-dom-esm/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"default": "./server.js"
3434
},
3535
"./server.node": "./server.node.js",
36-
"./node-loader": "./esm/react-server-dom-esm-node-loader.production.min.js",
36+
"./node-loader": "./esm/react-server-dom-esm-node-loader.production.js",
3737
"./src/*": "./src/*.js",
3838
"./package.json": "./package.json"
3939
},
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-server-dom-turbopack-client.browser.production.min.js');
4+
module.exports = require('./cjs/react-server-dom-turbopack-client.browser.production.js');
55
} else {
66
module.exports = require('./cjs/react-server-dom-turbopack-client.browser.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-server-dom-turbopack-client.edge.production.min.js');
4+
module.exports = require('./cjs/react-server-dom-turbopack-client.edge.production.js');
55
} else {
66
module.exports = require('./cjs/react-server-dom-turbopack-client.edge.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-server-dom-turbopack-client.node.production.min.js');
4+
module.exports = require('./cjs/react-server-dom-turbopack-client.node.production.js');
55
} else {
66
module.exports = require('./cjs/react-server-dom-turbopack-client.node.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-server-dom-turbopack-client.node.unbundled.production.min.js');
4+
module.exports = require('./cjs/react-server-dom-turbopack-client.node.unbundled.production.js');
55
} else {
66
module.exports = require('./cjs/react-server-dom-turbopack-client.node.unbundled.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-server-dom-turbopack-server.browser.production.min.js');
4+
module.exports = require('./cjs/react-server-dom-turbopack-server.browser.production.js');
55
} else {
66
module.exports = require('./cjs/react-server-dom-turbopack-server.browser.development.js');
77
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-server-dom-turbopack-server.edge.production.min.js');
4+
module.exports = require('./cjs/react-server-dom-turbopack-server.edge.production.js');
55
} else {
66
module.exports = require('./cjs/react-server-dom-turbopack-server.edge.development.js');
77
}

0 commit comments

Comments
 (0)