FIX LEB-4935 | Fix header getter in hasValidFetchResponse (#17)

Author: marc22alain

demo/ajax.app.js

@@ -579,7 +579,7 @@ var AcquiaHttpHmac = /*#__PURE__*/function () {
   }, {
     key: "hasValidFetchResponse",
     value: function hasValidFetchResponse(responseText, headers, nonce, timestamp) {
-      return _classPrivateFieldLooseBase(this, _hasValidResponse)[_hasValidResponse](responseText, headers['X-Server-Authorization-HMAC-SHA256'], nonce, timestamp);
+      return _classPrivateFieldLooseBase(this, _hasValidResponse)[_hasValidResponse](responseText, headers.get('X-Server-Authorization-HMAC-SHA256'), nonce, timestamp);
     }
   }], [{
     key: "isXMLHttpRequest",

demo/get.app.js

@@ -589,7 +589,7 @@ class AcquiaHttpHmac {
    *   TRUE if the request is valid; FALSE otherwise.
    */
   hasValidFetchResponse(responseText, headers, nonce, timestamp) {
-    return _classPrivateFieldLooseBase(this, _hasValidResponse)[_hasValidResponse](responseText, headers['X-Server-Authorization-HMAC-SHA256'], nonce, timestamp);
+    return _classPrivateFieldLooseBase(this, _hasValidResponse)[_hasValidResponse](responseText, headers.get('X-Server-Authorization-HMAC-SHA256'), nonce, timestamp);
   }
 
 }

demo/post.app.js

@@ -1,6 +1,6 @@
 {
   "name": "http-hmac-javascript",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "HTTP HMAC JavaScript Library",
   "main": "./lib/es5/hmac.js",
   "dependencies": {

lib/es5/hmac.js

@@ -21,6 +21,20 @@ Math.random = function () {
    return 0.123456789;
 };
 
+class Headers {
+  constructor() {
+    this.headers = {};
+  }
+
+  set(name, value) {
+    this.headers[name] = value;
+  }
+
+  get(name) {
+    return this.headers[name];
+  }
+}
+
 QUnit.module('HTTP HMAC JavaScript Library tests', {
   setup: function() {
     request = new MockHttpRequest();
@@ -439,13 +453,13 @@ QUnit.test('Test hasValidFetchResponse(), asserts pass.', function(assert) {
   expect(1);
   // A smoke test to confirm it's correctly hooked up. Logic is covered in tests of `hasValidResponse`.
   const responseText = 'correct response text';
-  const headers = {
-    'X-Server-Authorization-HMAC-SHA256': 'CU0ma6cbZ6wZAsjjKli8ukH8Nxx6kShpTQqxvw08Yns=',
-  };
   const nonce = '480b7e99-d558-4a59-e49a-228ae489561b';
   const timestamp = 1000000000;
+  const headers = new Headers();
+
+  headers.set('X-Server-Authorization-HMAC-SHA256', 'CU0ma6cbZ6wZAsjjKli8ukH8Nxx6kShpTQqxvw08Yns=');
 
-  var hasValidFetchResponse = HMAC.hasValidFetchResponse(responseText, headers, nonce, timestamp);
+  const hasValidFetchResponse = HMAC.hasValidFetchResponse(responseText, headers, nonce, timestamp);
   assert.ok(hasValidFetchResponse, 'hasValidFetchResponse() asserts pass.');
 });
 

lib/es5/hmac.min.js

@@ -539,7 +539,7 @@ class AcquiaHttpHmac {
     console.log('signature ', signature);
     console.log('server_signature', sha256Header);
 
-    return signature === sha256Header;    
+    return signature === sha256Header;
   }
 
   /**
@@ -576,7 +576,7 @@ class AcquiaHttpHmac {
   hasValidFetchResponse (responseText, headers, nonce, timestamp) {
     return this.#hasValidResponse(
       responseText,
-      headers['X-Server-Authorization-HMAC-SHA256'],
+      headers.get('X-Server-Authorization-HMAC-SHA256'),
       nonce,
       timestamp,
     );