Skip to content

Commit eaef294

Browse files
authored
fix: improve log messages for token creation (#226)
Updated log messages to provide clearer and more consistent information.
1 parent 86e2496 commit eaef294

File tree

3 files changed

+44
-28
lines changed

3 files changed

+44
-28
lines changed

lib/main.js

+15-16
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export async function main(
2121
core,
2222
createAppAuth,
2323
request,
24-
skipTokenRevoke,
24+
skipTokenRevoke
2525
) {
2626
let parsedOwner = "";
2727
let parsedRepositoryNames = [];
@@ -33,7 +33,7 @@ export async function main(
3333
parsedRepositoryNames = [repo];
3434

3535
core.info(
36-
`owner and repositories not set, creating token for the current repository ("${repo}")`,
36+
`Inputs 'owner' and 'repositories' are not set. Creating token for this repository (${owner}/${repo}).`
3737
);
3838
}
3939

@@ -42,7 +42,7 @@ export async function main(
4242
parsedOwner = owner;
4343

4444
core.info(
45-
`repositories not set, creating token for all repositories for given owner "${owner}"`,
45+
`Input 'repositories' is not set. Creating token for all repositories owned by ${owner}.`
4646
);
4747
}
4848

@@ -52,9 +52,9 @@ export async function main(
5252
parsedRepositoryNames = repositories;
5353

5454
core.info(
55-
`owner not set, creating owner for given repositories "${repositories.join(
56-
",",
57-
)}" in current owner ("${parsedOwner}")`,
55+
`No 'owner' input provided. Using default owner '${parsedOwner}' to create token for the following repositories:${repositories
56+
.map((repo) => `\n- ${parsedOwner}/${repo}`)
57+
.join("")}`
5858
);
5959
}
6060

@@ -64,9 +64,8 @@ export async function main(
6464
parsedRepositoryNames = repositories;
6565

6666
core.info(
67-
`owner and repositories set, creating token for repositories "${repositories.join(
68-
",",
69-
)}" owned by "${owner}"`,
67+
`Inputs 'owner' and 'repositories' are set. Creating token for the following repositories:
68+
${repositories.map((repo) => `\n- ${parsedOwner}/${repo}`).join("")}`
7069
);
7170
}
7271

@@ -87,18 +86,18 @@ export async function main(
8786
auth,
8887
parsedOwner,
8988
parsedRepositoryNames,
90-
permissions,
89+
permissions
9190
),
9291
{
9392
onFailedAttempt: (error) => {
9493
core.info(
9594
`Failed to create token for "${parsedRepositoryNames.join(
96-
",",
97-
)}" (attempt ${error.attemptNumber}): ${error.message}`,
95+
","
96+
)}" (attempt ${error.attemptNumber}): ${error.message}`
9897
);
9998
},
10099
retries: 3,
101-
},
100+
}
102101
));
103102
} else {
104103
// Otherwise get the installation for the owner, which can either be an organization or a user account
@@ -107,11 +106,11 @@ export async function main(
107106
{
108107
onFailedAttempt: (error) => {
109108
core.info(
110-
`Failed to create token for "${parsedOwner}" (attempt ${error.attemptNumber}): ${error.message}`,
109+
`Failed to create token for "${parsedOwner}" (attempt ${error.attemptNumber}): ${error.message}`
111110
);
112111
},
113112
retries: 3,
114-
},
113+
}
115114
));
116115
}
117116

@@ -157,7 +156,7 @@ async function getTokenFromRepository(
157156
auth,
158157
parsedOwner,
159158
parsedRepositoryNames,
160-
permissions,
159+
permissions
161160
) {
162161
// https://docs.github.com/rest/apps/apps?apiVersion=2022-11-28#get-a-repository-installation-for-the-authenticated-app
163162
const response = await request("GET /repos/{owner}/{repo}/installation", {

tests/snapshots/index.js.md

+29-12
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ Generated by [AVA](https://avajs.dev).
2222

2323
> stdout
2424
25-
`owner and repositories set, creating token for repositories "create-github-app-token" owned by "actions"␊
25+
`Inputs 'owner' and 'repositories' are set. Creating token for the following repositories:␊
26+
27+
- actions/create-github-app-token␊
2628
::add-mask::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
2729
2830
::set-output name=token::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
@@ -65,7 +67,7 @@ Generated by [AVA](https://avajs.dev).
6567

6668
> stdout
6769
68-
`owner and repositories not set, creating token for the current repository ("create-github-app-token")
70+
`Inputs 'owner' and 'repositories' are not set. Creating token for this repository (actions/create-github-app-token).
6971
::add-mask::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
7072
7173
::set-output name=token::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
@@ -89,7 +91,9 @@ Generated by [AVA](https://avajs.dev).
8991

9092
> stdout
9193
92-
`owner and repositories set, creating token for repositories "failed-repo" owned by "actions"␊
94+
`Inputs 'owner' and 'repositories' are set. Creating token for the following repositories:␊
95+
96+
- actions/failed-repo␊
9397
::add-mask::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
9498
9599
::set-output name=token::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
@@ -113,7 +117,7 @@ Generated by [AVA](https://avajs.dev).
113117

114118
> stdout
115119
116-
`repositories not set, creating token for all repositories for given owner "smockle"
120+
`Input 'repositories' is not set. Creating token for all repositories owned by smockle.
117121
Failed to create token for "smockle" (attempt 1): GitHub API not available␊
118122
::add-mask::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
119123
@@ -138,7 +142,9 @@ Generated by [AVA](https://avajs.dev).
138142

139143
> stdout
140144
141-
`owner and repositories set, creating token for repositories "failed-repo" owned by "actions"␊
145+
`Inputs 'owner' and 'repositories' are set. Creating token for the following repositories:␊
146+
147+
- actions/failed-repo␊
142148
Failed to create token for "failed-repo" (attempt 1): GitHub API not available␊
143149
::add-mask::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
144150
@@ -163,7 +169,11 @@ Generated by [AVA](https://avajs.dev).
163169

164170
> stdout
165171
166-
`owner and repositories set, creating token for repositories "create-github-app-token,toolkit,checkout" owned by "actions"␊
172+
`Inputs 'owner' and 'repositories' are set. Creating token for the following repositories:␊
173+
174+
- actions/create-github-app-token␊
175+
- actions/toolkit␊
176+
- actions/checkout␊
167177
::add-mask::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
168178
169179
::set-output name=token::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
@@ -186,7 +196,11 @@ Generated by [AVA](https://avajs.dev).
186196

187197
> stdout
188198
189-
`owner and repositories set, creating token for repositories "create-github-app-token,toolkit,checkout" owned by "actions"␊
199+
`Inputs 'owner' and 'repositories' are set. Creating token for the following repositories:␊
200+
201+
- actions/create-github-app-token␊
202+
- actions/toolkit␊
203+
- actions/checkout␊
190204
::add-mask::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
191205
192206
::set-output name=token::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
@@ -209,7 +223,9 @@ Generated by [AVA](https://avajs.dev).
209223

210224
> stdout
211225
212-
`owner and repositories set, creating token for repositories "create-github-app-token" owned by "actions"␊
226+
`Inputs 'owner' and 'repositories' are set. Creating token for the following repositories:␊
227+
228+
- actions/create-github-app-token␊
213229
::add-mask::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
214230
215231
::set-output name=token::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
@@ -232,7 +248,7 @@ Generated by [AVA](https://avajs.dev).
232248

233249
> stdout
234250
235-
`repositories not set, creating token for all repositories for given owner "actions"
251+
`Input 'repositories' is not set. Creating token for all repositories owned by actions.
236252
::add-mask::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
237253
238254
::set-output name=token::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
@@ -255,7 +271,8 @@ Generated by [AVA](https://avajs.dev).
255271

256272
> stdout
257273
258-
`owner not set, creating owner for given repositories "create-github-app-token" in current owner ("actions")␊
274+
`No 'owner' input provided. Using default owner 'actions' to create token for the following repositories:␊
275+
- actions/create-github-app-token␊
259276
::add-mask::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
260277
261278
::set-output name=token::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
@@ -278,7 +295,7 @@ Generated by [AVA](https://avajs.dev).
278295

279296
> stdout
280297
281-
`owner and repositories not set, creating token for the current repository ("create-github-app-token")
298+
`Inputs 'owner' and 'repositories' are not set. Creating token for this repository (actions/create-github-app-token).
282299
::add-mask::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
283300
284301
::set-output name=token::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
@@ -301,7 +318,7 @@ Generated by [AVA](https://avajs.dev).
301318

302319
> stdout
303320
304-
`owner and repositories not set, creating token for the current repository ("create-github-app-token")
321+
`Inputs 'owner' and 'repositories' are not set. Creating token for this repository (actions/create-github-app-token).
305322
::add-mask::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊
306323
307324
::set-output name=token::ghs_16C7e42F292c6912E7710c838347Ae178B4a␊

tests/snapshots/index.js.snap

43 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)