Simplify fix: track all join types in @joined_tables to prevent duplicates

Co-authored-by: scarroll32 <[email protected]>

Author: Copilot

lib/polyamorous/activerecord/join_dependency.rb

@@ -53,24 +53,6 @@ def construct_tables_for_association!(join_root, association)
       tables
     end
 
-    def populate_joined_tables_from_existing_joins(join_nodes, relation)
-      @joined_tables ||= {}
-      
-      join_nodes.each do |join|
-        next unless join.left.respond_to?(:name)
-        
-        table_name = join.left.name
-        
-        # Find reflections that correspond to this joined table
-        relation.klass.reflect_on_all_associations.each do |reflection|
-          if reflection.klass.table_name == table_name
-            # Mark this reflection as already joined with the existing table
-            @joined_tables[reflection] = [join.left, true]
-          end
-        end
-      end
-    end
-
     private
 
     def table_aliases_for(parent, node)
@@ -87,7 +69,7 @@ def table_aliases_for(parent, node)
             name = reflection.alias_candidate(parent.table_name)
             root ? name : "#{name}_join"
           end
-          @joined_tables[reflection] ||= [table, root] if join_type == Arel::Nodes::OuterJoin
+          @joined_tables[reflection] ||= [table, root]
           table
         end
       }

lib/ransack/adapters/active_record/context.rb

@@ -310,7 +310,7 @@ def build_joins(relation)
           join_dependency.instance_variable_set(:@alias_tracker, alias_tracker)
 
           # Track existing join nodes to prevent duplicate joins
-          join_dependency.send(:populate_joined_tables_from_existing_joins, join_nodes, relation)
+          join_dependency.populate_joined_tables_from_existing_joins(join_nodes, relation)
 
           join_nodes.each do |join|
             join_dependency.send(:alias_tracker).aliases[join.left.name.downcase] = 1