Merge pull request #102 from adafruit/use_ruff

change to ruff

Author: FoamyGuy

.gitattributes

@@ -0,0 +1,11 @@
+# SPDX-FileCopyrightText: 2024 Justin Myers for Adafruit Industries
+#
+# SPDX-License-Identifier: Unlicense
+
+.py text eol=lf
+.rst text eol=lf
+.txt text eol=lf
+.yaml text eol=lf
+.toml text eol=lf
+.license text eol=lf
+.md text eol=lf

.pre-commit-config.yaml

@@ -1,42 +1,21 @@
-# SPDX-FileCopyrightText: 2020 Diego Elio Pettenò
+# SPDX-FileCopyrightText: 2024 Justin Myers for Adafruit Industries
 #
 # SPDX-License-Identifier: Unlicense
 
 repos:
-  - repo: https://github.com/python/black
-    rev: 23.3.0
-    hooks:
-      - id: black
-  - repo: https://github.com/fsfe/reuse-tool
-    rev: v1.1.2
-    hooks:
-      - id: reuse
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v4.5.0
     hooks:
       - id: check-yaml
       - id: end-of-file-fixer
       - id: trailing-whitespace
-  - repo: https://github.com/pycqa/pylint
-    rev: v2.17.4
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.3.4
     hooks:
-      - id: pylint
-        name: pylint (library code)
-        types: [python]
-        args:
-          - --disable=consider-using-f-string
-        exclude: "^(docs/|examples/|tests/|setup.py$)"
-      - id: pylint
-        name: pylint (example code)
-        description: Run pylint rules on "examples/*.py" files
-        types: [python]
-        files: "^examples/"
-        args:
-          - --disable=missing-docstring,invalid-name,consider-using-f-string,duplicate-code
-      - id: pylint
-        name: pylint (test code)
-        description: Run pylint rules on "tests/*.py" files
-        types: [python]
-        files: "^tests/"
-        args:
-          - --disable=missing-docstring,consider-using-f-string,duplicate-code
+      - id: ruff-format
+      - id: ruff
+        args: ["--fix"]
+  - repo: https://github.com/fsfe/reuse-tool
+    rev: v3.0.1
+    hooks:
+      - id: reuse

.pylintrc

@@ -13,9 +13,9 @@ Introduction
     :target: https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal/actions
     :alt: Build Status
 
-.. image:: https://img.shields.io/badge/code%20style-black-000000.svg
-    :target: https://github.com/psf/black
-    :alt: Code Style: Black
+.. image:: https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/ruff/main/assets/badge/v2.json
+    :target: https://github.com/astral-sh/ruff
+    :alt: Code Style: Ruff
 
 CircuitPython helper for Adafruit MatrixPortal M4, Adafruit RGB Matrix Shield + Metro M4 Airlift Lite,
 and Adafruit RGB Matrix FeatherWings

README.rst

@@ -27,6 +27,7 @@
 """
 
 from adafruit_portalbase.graphics import GraphicsBase
+
 from adafruit_matrixportal.matrix import Matrix
 
 __version__ = "0.0.0+auto.0"
@@ -52,7 +53,6 @@ class Graphics(GraphicsBase):
 
     """
 
-    # pylint: disable=too-few-public-methods
     def __init__(
         self,
         **kwargs,

adafruit_matrixportal/graphics.py

@@ -27,11 +27,11 @@
 """
 
 import os
+
 import board
 import displayio
-import rgbmatrix
 import framebufferio
-
+import rgbmatrix
 
 __version__ = "0.0.0+auto.0"
 __repo__ = "https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal.git"
@@ -56,7 +56,6 @@ class Matrix:
                          Defaults to 0.
     """
 
-    # pylint: disable=too-few-public-methods,too-many-branches,too-many-statements,too-many-locals
     def __init__(
         self,
         *,
@@ -77,7 +76,7 @@ def __init__(
         red_index = color_order.find("r")
         green_index = color_order.find("g")
         blue_index = color_order.find("b")
-        if -1 in (red_index, green_index, blue_index):
+        if -1 in {red_index, green_index, blue_index}:
             raise ValueError("color_order should contain R, G, and B")
 
         if (
@@ -146,9 +145,7 @@ def __init__(
         else:
             # Metro/Grand Central Style Board
             if alt_addr_pins is None and height <= 16:
-                raise RuntimeError(
-                    "Pin A2 unavailable in this mode. Please specify alt_addr_pins."
-                )
+                raise RuntimeError("Pin A2 unavailable in this mode. Please specify alt_addr_pins.")
             addr_pins = [board.A0, board.A1, board.A2, board.A3]
             rgb_pins = [board.D2, board.D3, board.D4, board.D5, board.D6, board.D7]
             clock_pin = board.A4

adafruit_matrixportal/matrix.py

@@ -28,10 +28,12 @@
 
 import gc
 from time import sleep
+
 import terminalio
 from adafruit_portalbase import PortalBase
-from adafruit_matrixportal.network import Network
+
 from adafruit_matrixportal.graphics import Graphics
+from adafruit_matrixportal.network import Network
 
 __version__ = "0.0.0+auto.0"
 __repo__ = "https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal.git"
@@ -70,7 +72,6 @@ class MatrixPortal(PortalBase):
 
     """
 
-    # pylint: disable=too-many-locals
     def __init__(
         self,
         *,
@@ -133,7 +134,6 @@ def __init__(
 
         gc.collect()
 
-    # pylint: disable=too-many-arguments, arguments-differ
     def add_text(
         self,
         text_position=None,
@@ -204,8 +204,6 @@ def add_text(
 
         return index
 
-    # pylint: enable=too-many-arguments, arguments-differ
-
     def set_background(self, file_or_color, position=None):
         """The background image to a bitmap file.
 
@@ -267,7 +265,5 @@ def scroll_text(self, frame_delay=0.02):
                 sleep(frame_delay)
         else:
             raise RuntimeError(
-                "Please assign text to the label with index {} before scrolling".format(
-                    self._scrolling_index
-                )
+                f"Please assign text to the label with index {self._scrolling_index} before scrolling"  # noqa: E501
             )

adafruit_matrixportal/matrixportal.py

@@ -26,8 +26,9 @@
 
 """
 
-import os
 import gc
+import os
+
 import neopixel
 from adafruit_portalbase.network import NetworkBase
 

adafruit_matrixportal/network.py

@@ -1,5 +1,8 @@
 
 
+API Reference
+#############
+
 .. automodule:: adafruit_matrixportal.matrix
    :members:
 

docs/api.rst

@@ -1,12 +1,10 @@
-# -*- coding: utf-8 -*-
-
 # SPDX-FileCopyrightText: 2017 Scott Shawcroft, written for Adafruit Industries
 #
 # SPDX-License-Identifier: MIT
 
+import datetime
 import os
 import sys
-import datetime
 
 sys.path.insert(0, os.path.abspath(".."))
 
@@ -57,9 +55,7 @@
 creation_year = "2020"
 current_year = str(datetime.datetime.now().year)
 year_duration = (
-    current_year
-    if current_year == creation_year
-    else creation_year + " - " + current_year
+    current_year if current_year == creation_year else creation_year + " - " + current_year
 )
 copyright = year_duration + " Melissa LeBlanc-Williams"
 author = "Melissa LeBlanc-Williams"

docs/conf.py

@@ -4,9 +4,12 @@
 """
 This example checks the current Bitcoin price and scrolls it across the screen
 """
+
 import time
+
 import board
 import terminalio
+
 from adafruit_matrixportal.matrixportal import MatrixPortal
 
 # You can display in 'GBP', 'EUR' or 'USD'

examples/matrixportal_scrolling_bitcoin.py

@@ -4,9 +4,12 @@
 """
 This example checks the current Bitcoin price and displays it in the middle of the screen
 """
+
 import time
+
 import board
 import terminalio
+
 from adafruit_matrixportal.matrixportal import MatrixPortal
 
 # You can display in 'GBP', 'EUR' or 'USD'

examples/matrixportal_simpletest.py

@@ -0,0 +1,108 @@
+# SPDX-FileCopyrightText: 2024 Tim Cocks for Adafruit Industries
+#
+# SPDX-License-Identifier: MIT
+
+target-version = "py38"
+line-length = 100
+
+[lint]
+preview = true
+select = ["I", "PL", "UP"]
+
+extend-select = [
+  "D419",  # empty-docstring
+  "E501",  # line-too-long
+  "W291",  # trailing-whitespace
+  "PLC0414",  # useless-import-alias
+  "PLC2401",  # non-ascii-name
+  "PLC2801",  # unnecessary-dunder-call
+  "PLC3002",  # unnecessary-direct-lambda-call
+  "E999",  # syntax-error
+  "PLE0101",  # return-in-init
+  "F706",  # return-outside-function
+  "F704",  # yield-outside-function
+  "PLE0116",  # continue-in-finally
+  "PLE0117",  # nonlocal-without-binding
+  "PLE0241",  # duplicate-bases
+  "PLE0302",  # unexpected-special-method-signature
+  "PLE0604",  # invalid-all-object
+  "PLE0605",  # invalid-all-format
+  "PLE0643",  # potential-index-error
+  "PLE0704",  # misplaced-bare-raise
+  "PLE1141",  # dict-iter-missing-items
+  "PLE1142",  # await-outside-async
+  "PLE1205",  # logging-too-many-args
+  "PLE1206",  # logging-too-few-args
+  "PLE1307",  # bad-string-format-type
+  "PLE1310",  # bad-str-strip-call
+  "PLE1507",  # invalid-envvar-value
+  "PLE2502",  # bidirectional-unicode
+  "PLE2510",  # invalid-character-backspace
+  "PLE2512",  # invalid-character-sub
+  "PLE2513",  # invalid-character-esc
+  "PLE2514",  # invalid-character-nul
+  "PLE2515",  # invalid-character-zero-width-space
+  "PLR0124",  # comparison-with-itself
+  "PLR0202",  # no-classmethod-decorator
+  "PLR0203",  # no-staticmethod-decorator
+  "UP004",  # useless-object-inheritance
+  "PLR0206",  # property-with-parameters
+  "PLR0904",  # too-many-public-methods
+  "PLR0911",  # too-many-return-statements
+  "PLR0912",  # too-many-branches
+  "PLR0913",  # too-many-arguments
+  "PLR0914",  # too-many-locals
+  "PLR0915",  # too-many-statements
+  "PLR0916",  # too-many-boolean-expressions
+  "PLR1702",  # too-many-nested-blocks
+  "PLR1704",  # redefined-argument-from-local
+  "PLR1711",  # useless-return
+  "C416",  # unnecessary-comprehension
+  "PLR1733",  # unnecessary-dict-index-lookup
+  "PLR1736",  # unnecessary-list-index-lookup
+
+  # ruff reports this rule is unstable
+  #"PLR6301",  # no-self-use
+
+  "PLW0108",  # unnecessary-lambda
+  "PLW0120",  # useless-else-on-loop
+  "PLW0127",  # self-assigning-variable
+  "PLW0129",  # assert-on-string-literal
+  "B033",  # duplicate-value
+  "PLW0131",  # named-expr-without-context
+  "PLW0245",  # super-without-brackets
+  "PLW0406",  # import-self
+  "PLW0602",  # global-variable-not-assigned
+  "PLW0603",  # global-statement
+  "PLW0604",  # global-at-module-level
+
+  # fails on the try: import typing used by libraries
+  #"F401",  # unused-import
+
+  "F841",  # unused-variable
+  "E722",  # bare-except
+  "PLW0711",  # binary-op-exception
+  "PLW1501",  # bad-open-mode
+  "PLW1508",  # invalid-envvar-default
+  "PLW1509",  # subprocess-popen-preexec-fn
+  "PLW2101",  # useless-with-lock
+  "PLW3301",  # nested-min-max
+]
+
+ignore = [
+    "PLR2004", # magic-value-comparison
+    "UP030", # format literals
+    "PLW1514",  # unspecified-encoding
+    "PLR0913", # too-many-arguments
+    "PLR0915", # too-many-statements
+    "PLR0917", # too-many-positional-arguments
+    "PLR0904", # too-many-public-methods
+    "PLR0912", # too-many-branches
+    "PLR0916", # too-many-boolean-expressions
+    "PLR6301", # could-be-static no-self-use
+    "PLC0415", # import outside toplevel
+    "PLC2701", # private import
+]
+
+[format]
+line-ending = "lf"