Merge pull request #45 from adafruit/use_ruff

change to ruff

Author: FoamyGuy

.gitattributes

@@ -0,0 +1,11 @@
+# SPDX-FileCopyrightText: 2024 Justin Myers for Adafruit Industries
+#
+# SPDX-License-Identifier: Unlicense
+
+.py text eol=lf
+.rst text eol=lf
+.txt text eol=lf
+.yaml text eol=lf
+.toml text eol=lf
+.license text eol=lf
+.md text eol=lf

.pre-commit-config.yaml

@@ -1,42 +1,21 @@
-# SPDX-FileCopyrightText: 2020 Diego Elio Pettenò
+# SPDX-FileCopyrightText: 2024 Justin Myers for Adafruit Industries
 #
 # SPDX-License-Identifier: Unlicense
 
 repos:
-  - repo: https://github.com/python/black
-    rev: 23.3.0
-    hooks:
-      - id: black
-  - repo: https://github.com/fsfe/reuse-tool
-    rev: v1.1.2
-    hooks:
-      - id: reuse
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v4.5.0
     hooks:
       - id: check-yaml
       - id: end-of-file-fixer
       - id: trailing-whitespace
-  - repo: https://github.com/pycqa/pylint
-    rev: v3.3.1
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.3.4
     hooks:
-      - id: pylint
-        name: pylint (library code)
-        types: [python]
-        args:
-          - --disable=consider-using-f-string
-        exclude: "^(docs/|examples/|tests/|setup.py$)"
-      - id: pylint
-        name: pylint (example code)
-        description: Run pylint rules on "examples/*.py" files
-        types: [python]
-        files: "^examples/"
-        args:
-          - --disable=missing-docstring,invalid-name,consider-using-f-string,duplicate-code
-      - id: pylint
-        name: pylint (test code)
-        description: Run pylint rules on "tests/*.py" files
-        types: [python]
-        files: "^tests/"
-        args:
-          - --disable=missing-docstring,consider-using-f-string,duplicate-code
+      - id: ruff-format
+      - id: ruff
+        args: ["--fix"]
+  - repo: https://github.com/fsfe/reuse-tool
+    rev: v3.0.1
+    hooks:
+      - id: reuse

.pylintrc

@@ -17,9 +17,9 @@ Introduction
     :alt: Build Status
 
 
-.. image:: https://img.shields.io/badge/code%20style-black-000000.svg
-    :target: https://github.com/psf/black
-    :alt: Code Style: Black
+.. image:: https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/ruff/main/assets/badge/v2.json
+    :target: https://github.com/astral-sh/ruff
+    :alt: Code Style: Ruff
 
 Library for the Adafruit PyCamera
 

README.rst

@@ -4,7 +4,6 @@
 # SPDX-License-Identifier: MIT
 """Library for the Adafruit PyCamera with OV5640 autofocus module"""
 
-# pylint: disable=too-many-lines
 import gc
 import os
 import struct
@@ -19,10 +18,10 @@
 import adafruit_lis3dh
 import bitmaptools
 import board
-import displayio
-import fourwire
 import busdisplay
+import displayio
 import espcamera
+import fourwire
 import microcontroller
 import neopixel
 import pwmio
@@ -80,7 +79,7 @@
 _NVM_TIMELAPSE_SUBMODE = const(5)
 
 
-class PyCameraBase:  # pylint: disable=too-many-instance-attributes,too-many-public-methods
+class PyCameraBase:
     """Base class for PyCamera hardware
 
     Wrapper class for the PyCamera hardware with lots of smarts
@@ -201,14 +200,14 @@ class PyCameraBase:  # pylint: disable=too-many-instance-attributes,too-many-pub
     _INIT_SEQUENCE = (
         b"\x01\x80\x78"  # _SWRESET and Delay 120ms
         b"\x11\x80\x05"  # _SLPOUT and Delay 5ms
-        b"\x3A\x01\x55"  # _COLMOD
+        b"\x3a\x01\x55"  # _COLMOD
         b"\x21\x00"  # _INVON Hack
         b"\x13\x00"  # _NORON
-        b"\x36\x01\xA0"  # _MADCTL
+        b"\x36\x01\xa0"  # _MADCTL
         b"\x29\x80\x05"  # _DISPON and Delay 5ms
     )
 
-    def __init__(self) -> None:  # pylint: disable=too-many-statements
+    def __init__(self) -> None:
         displayio.release_displays()
         self._i2c = board.I2C()
         self._spi = board.SPI()
@@ -273,7 +272,7 @@ def make_debounced_expander_pin(pin_no):
             pin.switch_to_input()
             return Debouncer(make_expander_input(pin_no))
 
-        self.up = make_debounced_expander_pin(_AW_UP)  # pylint: disable=invalid-name
+        self.up = make_debounced_expander_pin(_AW_UP)
         self.left = make_debounced_expander_pin(_AW_LEFT)
         self.right = make_debounced_expander_pin(_AW_RIGHT)
         self.down = make_debounced_expander_pin(_AW_DOWN)
@@ -313,19 +312,15 @@ def check_for_update_needed(self):
 
     def make_camera_ui(self):
         """Create displayio widgets for the standard camera UI"""
-        self._sd_label = label.Label(
-            terminalio.FONT, text="SD ??", color=0x0, x=170, y=10, scale=2
-        )
+        self._sd_label = label.Label(terminalio.FONT, text="SD ??", color=0x0, x=170, y=10, scale=2)
         self._effect_label = label.Label(
             terminalio.FONT, text="EFFECT", color=0xFFFFFF, x=4, y=10, scale=2
         )
         self._mode_label = label.Label(
             terminalio.FONT, text="MODE", color=0xFFFFFF, x=170, y=10, scale=2
         )
         self._topbar = displayio.Group()
-        self._res_label = label.Label(
-            terminalio.FONT, text="", color=0xFFFFFF, x=0, y=10, scale=2
-        )
+        self._res_label = label.Label(terminalio.FONT, text="", color=0xFFFFFF, x=0, y=10, scale=2)
         self._topbar.append(self._res_label)
         self._topbar.append(self._sd_label)
 
@@ -365,9 +360,7 @@ def init_neopixel(self):
         neopix.deinit()
 
         # front bezel neopixels
-        self.pixels = neopixel.NeoPixel(
-            board.A1, 8, brightness=0.1, pixel_order=neopixel.RGBW
-        )
+        self.pixels = neopixel.NeoPixel(board.A1, 8, brightness=0.1, pixel_order=neopixel.RGBW)
         self.pixels.fill(0)
 
     def init_camera(self, init_autofocus=True) -> None:
@@ -470,9 +463,7 @@ def autofocus_init_from_bitstream(self, firmware: bytes):
                 reg = offset + 0x8000
                 arr[0] = reg >> 8
                 arr[1] = reg & 0xFF
-                arr[2 : 2 + num_firmware_bytes] = firmware[
-                    offset : offset + num_firmware_bytes
-                ]
+                arr[2 : 2 + num_firmware_bytes] = firmware[offset : offset + num_firmware_bytes]
                 i2c.write(arr, end=2 + num_firmware_bytes)
 
         self.write_camera_list(self._finalize_firmware_load)
@@ -486,9 +477,7 @@ def autofocus_init_from_bitstream(self, firmware: bytes):
     def autofocus_init(self):
         """Initialize the autofocus engine from ov5640_autofocus.bin"""
         if "/" in __file__:
-            binfile = (
-                __file__.rsplit("/", 1)[0].rsplit(".", 1)[0] + "/ov5640_autofocus.bin"
-            )
+            binfile = __file__.rsplit("/", 1)[0].rsplit(".", 1)[0] + "/ov5640_autofocus.bin"
         else:
             binfile = "ov5640_autofocus.bin"
         print(binfile)
@@ -499,7 +488,7 @@ def autofocus_status(self):
         """Read the camera autofocus status register"""
         return self.read_camera_register(_OV5640_CMD_FW_STATUS)
 
-    def _send_autofocus_command(self, command, msg):  # pylint: disable=unused-argument
+    def _send_autofocus_command(self, command, msg):
         self.write_camera_register(_OV5640_CMD_ACK, 0x01)  # clear command ack
         self.write_camera_register(_OV5640_CMD_MAIN, command)  # send command
         for _ in range(100):
@@ -519,18 +508,14 @@ def autofocus(self) -> list[int]:
             return [False] * 5
         if not self._send_autofocus_command(_OV5640_CMD_TRIGGER_AUTOFOCUS, "autofocus"):
             return [False] * 5
-        zone_focus = [
-            self.read_camera_register(_OV5640_CMD_PARA0 + i) for i in range(5)
-        ]
+        zone_focus = [self.read_camera_register(_OV5640_CMD_PARA0 + i) for i in range(5)]
         print(f"zones focused: {zone_focus}")
         return zone_focus
 
     @property
     def autofocus_vcm_step(self):
         """Get the voice coil motor step location"""
-        if not self._send_autofocus_command(
-            _OV5640_CMD_AF_GET_VCM_STEP, "get vcm step"
-        ):
+        if not self._send_autofocus_command(_OV5640_CMD_AF_GET_VCM_STEP, "get vcm step"):
             return None
         return self.read_camera_register(_OV5640_CMD_PARA4)
 
@@ -549,7 +534,7 @@ def select_setting(self, setting_name):
         self._effect_label.background_color = 0x0
         self._res_label.color = 0xFFFFFF
         self._res_label.background_color = 0x0
-        if self.mode_text in ("GIF", "GBOY"):
+        if self.mode_text in {"GIF", "GBOY"}:
             self._res_label.text = ""
         else:
             self._res_label.text = self.resolutions[self._resolution]
@@ -601,7 +586,7 @@ def mode(self, setting):
         self._mode_label.text = self.modes[setting]
         if self.modes[setting] == "STOP":
             self.stop_motion_frame = 0
-        if self.modes[setting] in ("GIF", "GBOY"):
+        if self.modes[setting] in {"GIF", "GBOY"}:
             self._res_label.text = ""
         else:
             self.resolution = self.resolution  # kick it to reset the display
@@ -656,9 +641,7 @@ def timelapse_rate(self, setting):
         if self.timelapse_rates[setting] < 60:
             self.timelapse_rate_label.text = "%d S" % self.timelapse_rates[setting]
         else:
-            self.timelapse_rate_label.text = "%d M" % (
-                self.timelapse_rates[setting] / 60
-            )
+            self.timelapse_rate_label.text = "%d M" % (self.timelapse_rates[setting] / 60)
         microcontroller.nvm[_NVM_TIMELAPSE_RATE] = setting
         self.display.refresh()
 
@@ -669,13 +652,9 @@ def timelapse_submode(self):
 
     @timelapse_submode.setter
     def timelapse_submode(self, setting):
-        setting = (setting + len(self.timelapse_submodes)) % len(
-            self.timelapse_submodes
-        )
+        setting = (setting + len(self.timelapse_submodes)) % len(self.timelapse_submodes)
         self._timelapse_submode = setting
-        self.timelapse_submode_label.text = self.timelapse_submodes[
-            self._timelapse_submode
-        ]
+        self.timelapse_submode_label.text = self.timelapse_submodes[self._timelapse_submode]
         microcontroller.nvm[_NVM_TIMELAPSE_SUBMODE] = setting
 
     def init_display(self):
@@ -800,9 +779,7 @@ def keys_debounce(self):
 
     def tone(self, frequency, duration=0.1):
         """Play a tone on the internal speaker"""
-        with pwmio.PWMOut(
-            board.SPEAKER, frequency=int(frequency), variable_frequency=False
-        ) as pwm:
+        with pwmio.PWMOut(board.SPEAKER, frequency=int(frequency), variable_frequency=False) as pwm:
             self.mute.value = True
             pwm.duty_cycle = 0x8000
             time.sleep(duration)
@@ -874,10 +851,9 @@ def overlay(self) -> str:
 
     @overlay.setter
     def overlay(self, new_overlay_file: str) -> None:
-        # pylint: disable=import-outside-toplevel
-        from displayio import ColorConverter, Colorspace
-        import ulab.numpy as np
         import adafruit_imageload
+        import ulab.numpy as np
+        from displayio import ColorConverter, Colorspace
 
         if self.overlay_bmp is not None:
             self.overlay_bmp.deinit()
@@ -891,7 +867,6 @@ def overlay(self, new_overlay_file: str) -> None:
         del arr
 
     def _init_jpeg_decoder(self):
-        # pylint: disable=import-outside-toplevel
         from jpegio import JpegDecoder
 
         """
@@ -908,10 +883,7 @@ def blit_overlay_into_last_capture(self):
         in a separate but similarly named .bmp file on the SDCard.
         """
         if self.overlay_bmp is None:
-            raise ValueError(
-                "Must set overlay before calling blit_overlay_into_last_capture"
-            )
-        # pylint: disable=import-outside-toplevel
+            raise ValueError("Must set overlay before calling blit_overlay_into_last_capture")
         from adafruit_bitmapsaver import save_pixels
         from displayio import Bitmap, ColorConverter, Colorspace
 
@@ -955,7 +927,7 @@ def last_saved_filename(self) -> str:
 
     def continuous_capture_start(self):
         """Switch the camera to continuous-capture mode"""
-        pass  # pylint: disable=unnecessary-pass
+        pass
 
     def capture_into_jpeg(self):
         """Captures an image and returns it in JPEG format.
@@ -997,7 +969,6 @@ def blit(self, bitmap, x_offset=0, y_offset=32):
         The default preview capture is 240x176, leaving 32 pixel rows at the top and bottom
         for status information.
         """
-        # pylint: disable=import-outside-toplevel
         from displayio import Bitmap
 
         if self.overlay_bmp is not None:
@@ -1025,9 +996,7 @@ def blit(self, bitmap, x_offset=0, y_offset=32):
         self._display_bus.send(
             42, struct.pack(">hh", 80 + x_offset, 80 + x_offset + bitmap.width - 1)
         )
-        self._display_bus.send(
-            43, struct.pack(">hh", y_offset, y_offset + bitmap.height - 1)
-        )
+        self._display_bus.send(43, struct.pack(">hh", y_offset, y_offset + bitmap.height - 1))
         self._display_bus.send(44, bitmap)
 
     @property
@@ -1066,8 +1035,7 @@ def get_camera_autosettings(self):
             + (self.read_camera_register(0x3502) >> 4)
         )
         white_balance = [
-            self.read_camera_register(x)
-            for x in (0x3400, 0x3401, 0x3402, 0x3403, 0x3404, 0x3405)
+            self.read_camera_register(x) for x in (0x3400, 0x3401, 0x3402, 0x3403, 0x3404, 0x3405)
         ]
 
         settings = {
@@ -1147,6 +1115,6 @@ def __init__(self, init_autofocus=True):
 
         try:
             self.mount_sd_card()
-        except Exception as exc:  # pylint: disable=broad-exception-caught
+        except Exception as exc:
             # No SD card inserted, it's OK
             print(exc)

adafruit_pycamera/__init__.py

@@ -84,7 +84,6 @@ def ironbow(bitmap, mask=None):
     return bitmapfilter.false_color(bitmap, ironbow_palette, mask=mask)
 
 
-# pylint: disable=invalid-name
 def alphablend_maker(frac, nfrac=None):
     """Create an alpha-blending function for a specific fractional value
 

adafruit_pycamera/imageprocessing.py

@@ -4,6 +4,9 @@
 .. If your library file(s) are nested in a directory (e.g. /adafruit_foo/foo.py)
 .. use this format as the module name: "adafruit_foo.foo"
 
+API Reference
+#############
+
 .. automodule:: adafruit_pycamera
     :members:
 .. automodule:: adafruit_pycamera.imageprocessing

docs/api.rst

@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 # SPDX-FileCopyrightText: 2017 Scott Shawcroft, written for Adafruit Industries
 #
 # SPDX-License-Identifier: MIT
@@ -75,9 +73,7 @@
 creation_year = "2023"
 current_year = str(datetime.datetime.now().year)
 year_duration = (
-    current_year
-    if current_year == creation_year
-    else creation_year + " - " + current_year
+    current_year if current_year == creation_year else creation_year + " - " + current_year
 )
 copyright = year_duration + " Jeff Epler for Adafruit Industries"
 author = "Jeff Epler for Adafruit Industries"

docs/conf.py

@@ -1,10 +1,11 @@
 # SPDX-FileCopyrightText: Copyright (c) 2023 john park for Adafruit Industries
 #
 # SPDX-License-Identifier: MIT
-""" simple point-and-shoot camera example. No bells! Zero whistles! """
+"""simple point-and-shoot camera example. No bells! Zero whistles!"""
 
 import time
-import adafruit_pycamera  # pylint: disable=import-error
+
+import adafruit_pycamera
 
 pycam = adafruit_pycamera.PyCamera()
 pycam.mode = 0  # only mode 0 (JPEG) will work in this example
@@ -36,11 +37,11 @@
             pycam.display_message("snap", color=0x00DD00)
             pycam.capture_jpeg()
             pycam.live_preview_mode()
-        except TypeError as exception:
+        except TypeError:
             pycam.display_message("Failed", color=0xFF0000)
             time.sleep(0.5)
             pycam.live_preview_mode()
-        except RuntimeError as exception:
+        except RuntimeError:
             pycam.display_message("Error\nNo SD Card", color=0xFF0000)
             time.sleep(0.5)
 

examples/basic_camera/code.py

@@ -6,6 +6,7 @@
 """Automatically create the /sd mount point at boot time"""
 
 import os
+
 import storage
 
 storage.remount("/", readonly=False)

examples/camera/boot.py

@@ -2,18 +2,19 @@
 # SPDX-FileCopyrightText: 2023 Limor Fried for Adafruit Industries
 #
 # SPDX-License-Identifier: Unlicense
-import ssl
 import os
+import ssl
 import time
-import socketpool
-import adafruit_requests
-import rtc
+
 import adafruit_ntp
-import wifi
+import adafruit_requests
 import bitmaptools
 import displayio
 import gifio
+import rtc
+import socketpool
 import ulab.numpy as np
+import wifi
 
 import adafruit_pycamera
 
@@ -31,9 +32,7 @@
 PASSWORD = os.getenv("CIRCUITPY_WIFI_PASSWORD")
 
 if SSID and PASSWORD:
-    wifi.radio.connect(
-        os.getenv("CIRCUITPY_WIFI_SSID"), os.getenv("CIRCUITPY_WIFI_PASSWORD")
-    )
+    wifi.radio.connect(os.getenv("CIRCUITPY_WIFI_SSID"), os.getenv("CIRCUITPY_WIFI_PASSWORD"))
     if wifi.radio.connected:
         print(f"Connected to {os.getenv('CIRCUITPY_WIFI_SSID')}!")
         print("My IP address is", wifi.radio.ipv4_address)
@@ -46,9 +45,7 @@
             UTC_OFFSET = response_as_json["raw_offset"] + response_as_json["dst_offset"]
             print(f"UTC_OFFSET: {UTC_OFFSET}")
 
-        ntp = adafruit_ntp.NTP(
-            pool, server="pool.ntp.org", tz_offset=UTC_OFFSET // 3600
-        )
+        ntp = adafruit_ntp.NTP(pool, server="pool.ntp.org", tz_offset=UTC_OFFSET // 3600)
 
         print(f"ntp time: {ntp.datetime}")
         rtc.RTC().datetime = ntp.datetime
@@ -103,13 +100,9 @@
         pycam.timelapse_submode_label.text = pycam.timelapse_submode_label.text
 
         # only in high power mode do we continuously preview
-        if (timelapse_remaining is None) or (
-            pycam.timelapse_submode_label.text == "HiPwr"
-        ):
+        if (timelapse_remaining is None) or (pycam.timelapse_submode_label.text == "HiPwr"):
             pycam.blit(pycam.continuous_capture())
-        if pycam.timelapse_submode_label.text == "LowPwr" and (
-            timelapse_remaining is not None
-        ):
+        if pycam.timelapse_submode_label.text == "LowPwr" and (timelapse_remaining is not None):
             pycam.display.brightness = 0.05
         else:
             pycam.display.brightness = 1
@@ -122,18 +115,16 @@
             try:
                 pycam.display_message("Snap!", color=0x0000FF)
                 pycam.capture_jpeg()
-            except TypeError as e:
+            except TypeError:
                 pycam.display_message("Failed", color=0xFF0000)
                 time.sleep(0.5)
-            except RuntimeError as e:
+            except RuntimeError:
                 pycam.display_message("Error\nNo SD Card", color=0xFF0000)
                 time.sleep(0.5)
             pycam.live_preview_mode()
             pycam.display.refresh()
             pycam.blit(pycam.continuous_capture())
-            timelapse_timestamp = (
-                time.time() + pycam.timelapse_rates[pycam.timelapse_rate] + 1
-            )
+            timelapse_timestamp = time.time() + pycam.timelapse_rates[pycam.timelapse_rate] + 1
     else:
         pycam.blit(pycam.continuous_capture())
     # print("\t\t", capture_time, blit_time)
@@ -153,18 +144,18 @@
             try:
                 pycam.display_message("Snap!", color=0x0000FF)
                 pycam.capture_jpeg()
-            except TypeError as e:
+            except TypeError:
                 pycam.display_message("Failed", color=0xFF0000)
                 time.sleep(0.5)
-            except RuntimeError as e:
+            except RuntimeError:
                 pycam.display_message("Error\nNo SD Card", color=0xFF0000)
                 time.sleep(0.5)
             pycam.live_preview_mode()
 
         if pycam.mode_text == "GBOY":
             try:
                 f = pycam.open_next_image("gif")
-            except RuntimeError as e:
+            except RuntimeError:
                 pycam.display_message("Error\nNo SD Card", color=0xFF0000)
                 time.sleep(0.5)
                 continue
@@ -181,13 +172,13 @@
         if pycam.mode_text == "GIF":
             try:
                 f = pycam.open_next_image("gif")
-            except RuntimeError as e:
+            except RuntimeError:
                 pycam.display_message("Error\nNo SD Card", color=0xFF0000)
                 time.sleep(0.5)
                 continue
             i = 0
             ft = []
-            pycam._mode_label.text = "RECORDING"  # pylint: disable=protected-access
+            pycam._mode_label.text = "RECORDING"
 
             pycam.display.refresh()
             with gifio.GifWriter(
@@ -207,7 +198,7 @@
                     ft.append(1 / (t1 - t0))
                     print(end=".")
                     t0 = t1
-            pycam._mode_label.text = "GIF"  # pylint: disable=protected-access
+            pycam._mode_label.text = "GIF"
             print(f"\nfinal size {f.tell()} for {i} frames")
             print(f"average framerate {i / (t1 - t00)}fps")
             print(f"best {max(ft)} worst {min(ft)} std. deviation {np.std(ft)}")
@@ -220,11 +211,11 @@
                 pycam.display_message("Snap!", color=0x0000FF)
                 pycam.capture_jpeg()
                 pycam.live_preview_mode()
-            except TypeError as e:
+            except TypeError:
                 pycam.display_message("Failed", color=0xFF0000)
                 time.sleep(0.5)
                 pycam.live_preview_mode()
-            except RuntimeError as e:
+            except RuntimeError:
                 pycam.display_message("Error\nNo SD Card", color=0xFF0000)
                 time.sleep(0.5)
 

examples/camera/code.py

@@ -11,16 +11,14 @@
 Otherwise, effects cycle every DISPLAY_INTERVAL milliseconds (default 2000 = 2 seconds)
 """
 
+import bitmapfilter
 import displayio
-from jpegio import JpegDecoder
 from adafruit_display_text.label import Label
-from adafruit_ticks import ticks_less, ticks_ms, ticks_add, ticks_diff
+from adafruit_ticks import ticks_add, ticks_diff, ticks_less, ticks_ms
 from font_free_mono_bold_24 import FONT
-import bitmapfilter
-
-from adafruit_pycamera import imageprocessing
-from adafruit_pycamera import PyCameraBase
+from jpegio import JpegDecoder
 
+from adafruit_pycamera import PyCameraBase, imageprocessing
 
 blend_50_50 = bitmapfilter.blend_precompute(imageprocessing.alphablend_maker(0.5))
 screen = bitmapfilter.blend_precompute(imageprocessing.screen_func)
@@ -130,9 +128,7 @@ def sketch(b):
     ("solarize", bitmapfilter.solarize),
     (
         "swap r/b",
-        lambda b: bitmapfilter.mix(
-            b, bitmapfilter.ChannelMixer(0, 0, 1, 0, 1, 0, 1, 0, 0)
-        ),
+        lambda b: bitmapfilter.mix(b, bitmapfilter.ChannelMixer(0, 0, 1, 0, 1, 0, 1, 0, 0)),
     ),
 ]
 

examples/filter/code.py

@@ -2,14 +2,16 @@
 # SPDX-FileCopyrightText: Copyright (c) 2024 Tim Cocks for Adafruit Industries
 #
 # SPDX-License-Identifier: MIT
-""" simple point-and-shoot camera example, with overly selecting using select button.
+"""simple point-and-shoot camera example, with overly selecting using select button.
 
 Place all overlay files inside /sd/overlays/ directory.
 """
+
 import os
 import time
 import traceback
-import adafruit_pycamera  # pylint: disable=import-error
+
+import adafruit_pycamera
 
 MODE_POSITION = 0
 MODE_SCALE = 1
@@ -57,19 +59,13 @@
 
     if CURRENT_MODE == MODE_POSITION:
         if not pycam.down.value:
-            pycam.overlay_position[1] += 1 * (
-                int(pycam.down.current_duration / 0.3) + 1
-            )
+            pycam.overlay_position[1] += 1 * (int(pycam.down.current_duration / 0.3) + 1)
         if not pycam.up.value:
             pycam.overlay_position[1] -= 1 * (int(pycam.up.current_duration / 0.3) + 1)
         if not pycam.left.value:
-            pycam.overlay_position[0] -= 1 * (
-                int(pycam.left.current_duration / 0.3) + 1
-            )
+            pycam.overlay_position[0] -= 1 * (int(pycam.left.current_duration / 0.3) + 1)
         if not pycam.right.value:
-            pycam.overlay_position[0] += 1 * (
-                int(pycam.right.current_duration / 0.3) + 1
-            )
+            pycam.overlay_position[0] += 1 * (int(pycam.right.current_duration / 0.3) + 1)
     if CURRENT_MODE == MODE_SCALE:
         if pycam.down.fell:
             int_scale -= 10
@@ -98,7 +94,7 @@
             pycam.display_message("Failed", color=0xFF0000)
             time.sleep(0.5)
             pycam.live_preview_mode()
-        except RuntimeError as exception:
+        except RuntimeError:
             pycam.display_message("Error\nNo SD Card", color=0xFF0000)
             time.sleep(0.5)
 

examples/overlay/code_select.py

@@ -2,11 +2,12 @@
 # SPDX-FileCopyrightText: Copyright (c) 2024 Tim Cocks for Adafruit Industries
 #
 # SPDX-License-Identifier: MIT
-""" simple point-and-shoot camera example, with an overlay frame image. """
+"""simple point-and-shoot camera example, with an overlay frame image."""
 
 import time
 import traceback
-import adafruit_pycamera  # pylint: disable=import-error
+
+import adafruit_pycamera
 
 pycam = adafruit_pycamera.PyCamera()
 pycam.mode = 0  # only mode 0 (JPEG) will work in this example
@@ -47,7 +48,7 @@
             pycam.display_message("Failed", color=0xFF0000)
             time.sleep(0.5)
             pycam.live_preview_mode()
-        except RuntimeError as exception:
+        except RuntimeError:
             pycam.display_message("Error\nNo SD Card", color=0xFF0000)
             time.sleep(0.5)
 

examples/overlay/code_simple.py

@@ -14,8 +14,8 @@
 from adafruit_pycamera import PyCamera
 
 pycam = PyCamera()
-pycam._mode_label.text = "QR SCAN"  # pylint: disable=protected-access
-pycam._res_label.text = ""  # pylint: disable=protected-access
+pycam._mode_label.text = "QR SCAN"
+pycam._res_label.text = ""
 pycam.effect = 0
 pycam.camera.hmirror = False
 pycam.display.refresh()

examples/qrio/code.py

@@ -1,18 +1,20 @@
 # SPDX-FileCopyrightText: Copyright (c) 2024 Tim Cocks for Adafruit Industries
 #
 # SPDX-License-Identifier: MIT
-""" simple point-and-shoot camera example. With NTP and internal RTC to
- add timestamp to photo filenames. Must install adafruit_ntp library!
- Example code assumes WIFI credentials are properly setup and web workflow
- enabled in settings.toml. If not, you'll need to add code to manually connect
- to your network."""
+"""simple point-and-shoot camera example. With NTP and internal RTC to
+add timestamp to photo filenames. Must install adafruit_ntp library!
+Example code assumes WIFI credentials are properly setup and web workflow
+enabled in settings.toml. If not, you'll need to add code to manually connect
+to your network."""
 
 import time
-import wifi
-import socketpool
-import rtc
+
 import adafruit_ntp
-import adafruit_pycamera  # pylint: disable=import-error
+import rtc
+import socketpool
+import wifi
+
+import adafruit_pycamera
 
 pool = socketpool.SocketPool(wifi.radio)
 ntp = adafruit_ntp.NTP(pool, tz_offset=0)
@@ -46,21 +48,14 @@
         pycam.tone(1600, 0.05)
         try:
             pycam.display_message("snap", color=0x00DD00)
-            timestamp = "img_{}-{}-{}_{:02}-{:02}-{:02}_".format(
-                time.localtime().tm_year,
-                time.localtime().tm_mon,
-                time.localtime().tm_mday,
-                time.localtime().tm_hour,
-                time.localtime().tm_min,
-                time.localtime().tm_sec,
-            )
+            timestamp = f"img_{time.localtime().tm_year}-{time.localtime().tm_mon}-{time.localtime().tm_mday}_{time.localtime().tm_hour:02}-{time.localtime().tm_min:02}-{time.localtime().tm_sec:02}_"  # noqa: E501
             pycam.capture_jpeg(filename_prefix=timestamp)
             pycam.live_preview_mode()
-        except TypeError as exception:
+        except TypeError:
             pycam.display_message("Failed", color=0xFF0000)
             time.sleep(0.5)
             pycam.live_preview_mode()
-        except RuntimeError as exception:
+        except RuntimeError:
             pycam.display_message("Error\nNo SD Card", color=0xFF0000)
             time.sleep(0.5)
 

examples/timestamp_filename/code.py

@@ -12,11 +12,13 @@
 Otherwise, images cycle every DISPLAY_INTERVAL milliseconds (default 8000 = 8 seconds)
 """
 
-import time
 import os
+import time
+
 import displayio
+from adafruit_ticks import ticks_add, ticks_diff, ticks_less, ticks_ms
 from jpegio import JpegDecoder
-from adafruit_ticks import ticks_less, ticks_ms, ticks_add, ticks_diff
+
 from adafruit_pycamera import PyCameraBase
 
 DISPLAY_INTERVAL = 8000  # milliseconds
@@ -83,9 +85,7 @@ def mount_sd():
         pycam.display_message("SD Card\nFailed!", color=0xFF0000)
         time.sleep(0.5)
     all_images = [
-        f"/sd/{filename}"
-        for filename in os.listdir("/sd")
-        if filename.lower().endswith(".jpg")
+        f"/sd/{filename}" for filename in os.listdir("/sd") if filename.lower().endswith(".jpg")
     ]
     pycam.display_message(f"Found {len(all_images)}\nimages", color=0xFFFFFF)
     time.sleep(0.5)
@@ -143,7 +143,7 @@ def main():
                 image_counter = (image_counter + 1) % len(all_images)
                 try:
                     load_resized_image(bitmap, filename)
-                except Exception as e:  # pylint: disable=broad-exception-caught
+                except Exception as e:
                     pycam.display_message(f"Failed to read\n{filename}", color=0xFF0000)
                     print(e)
                     deadline = ticks_add(now, 500)

examples/viewer/code.py

@@ -51,8 +51,7 @@ def body():
         request,
         body,
         headers={
-            "Content-Type": "multipart/x-mixed-replace; boundary=%s"
-            % BOUNDARY.decode("ascii")
+            "Content-Type": "multipart/x-mixed-replace; boundary=%s" % BOUNDARY.decode("ascii")
         },
     )
 

examples/web_camera/code.py

@@ -69,17 +69,13 @@ def lcd(request: Request) -> Response:
 def take_jpeg(request: Request) -> Response:
     pycam.camera.reconfigure(
         pixel_format=espcamera.PixelFormat.JPEG,
-        frame_size=pycam.resolution_to_frame_size[
-            pycam._resolution  # pylint: disable=protected-access
-        ],
+        frame_size=pycam.resolution_to_frame_size[pycam._resolution],
     )
     try:
         jpeg = pycam.camera.take(1)
         if jpeg is not None:
             return Response(request, bytes(jpeg), content_type="image/jpeg")
-        return Response(
-            request, "", content_type="text/plain", status=INTERNAL_SERVER_ERROR_500
-        )
+        return Response(request, "", content_type="text/plain", status=INTERNAL_SERVER_ERROR_500)
     finally:
         pycam.live_preview_mode()
 
@@ -109,13 +105,13 @@ def property_common(obj, request):
             try:
                 current_value = getattr(obj, propname, None)
                 return JSONResponse(request, current_value)
-            except Exception as exc:  # pylint: disable=broad-exception-caught
+            except Exception as exc:
                 return Response(request, {"error": str(exc)}, status=BAD_REQUEST_400)
         else:
             new_value = json.loads(value)
             setattr(obj, propname, new_value)
             return JSONResponse(request, {"status": "OK"})
-    except Exception as exc:  # pylint: disable=broad-exception-caught
+    except Exception as exc:
         return JSONResponse(request, {"error": str(exc)}, status=BAD_REQUEST_400)
 
 

examples/web_settings_explorer/code.py

@@ -0,0 +1,108 @@
+# SPDX-FileCopyrightText: 2024 Tim Cocks for Adafruit Industries
+#
+# SPDX-License-Identifier: MIT
+
+target-version = "py38"
+line-length = 100
+
+[lint]
+preview = true
+select = ["I", "PL", "UP"]
+
+extend-select = [
+  "D419",  # empty-docstring
+  "E501",  # line-too-long
+  "W291",  # trailing-whitespace
+  "PLC0414",  # useless-import-alias
+  "PLC2401",  # non-ascii-name
+  "PLC2801",  # unnecessary-dunder-call
+  "PLC3002",  # unnecessary-direct-lambda-call
+  "E999",  # syntax-error
+  "PLE0101",  # return-in-init
+  "F706",  # return-outside-function
+  "F704",  # yield-outside-function
+  "PLE0116",  # continue-in-finally
+  "PLE0117",  # nonlocal-without-binding
+  "PLE0241",  # duplicate-bases
+  "PLE0302",  # unexpected-special-method-signature
+  "PLE0604",  # invalid-all-object
+  "PLE0605",  # invalid-all-format
+  "PLE0643",  # potential-index-error
+  "PLE0704",  # misplaced-bare-raise
+  "PLE1141",  # dict-iter-missing-items
+  "PLE1142",  # await-outside-async
+  "PLE1205",  # logging-too-many-args
+  "PLE1206",  # logging-too-few-args
+  "PLE1307",  # bad-string-format-type
+  "PLE1310",  # bad-str-strip-call
+  "PLE1507",  # invalid-envvar-value
+  "PLE2502",  # bidirectional-unicode
+  "PLE2510",  # invalid-character-backspace
+  "PLE2512",  # invalid-character-sub
+  "PLE2513",  # invalid-character-esc
+  "PLE2514",  # invalid-character-nul
+  "PLE2515",  # invalid-character-zero-width-space
+  "PLR0124",  # comparison-with-itself
+  "PLR0202",  # no-classmethod-decorator
+  "PLR0203",  # no-staticmethod-decorator
+  "UP004",  # useless-object-inheritance
+  "PLR0206",  # property-with-parameters
+  "PLR0904",  # too-many-public-methods
+  "PLR0911",  # too-many-return-statements
+  "PLR0912",  # too-many-branches
+  "PLR0913",  # too-many-arguments
+  "PLR0914",  # too-many-locals
+  "PLR0915",  # too-many-statements
+  "PLR0916",  # too-many-boolean-expressions
+  "PLR1702",  # too-many-nested-blocks
+  "PLR1704",  # redefined-argument-from-local
+  "PLR1711",  # useless-return
+  "C416",  # unnecessary-comprehension
+  "PLR1733",  # unnecessary-dict-index-lookup
+  "PLR1736",  # unnecessary-list-index-lookup
+
+  # ruff reports this rule is unstable
+  #"PLR6301",  # no-self-use
+
+  "PLW0108",  # unnecessary-lambda
+  "PLW0120",  # useless-else-on-loop
+  "PLW0127",  # self-assigning-variable
+  "PLW0129",  # assert-on-string-literal
+  "B033",  # duplicate-value
+  "PLW0131",  # named-expr-without-context
+  "PLW0245",  # super-without-brackets
+  "PLW0406",  # import-self
+  "PLW0602",  # global-variable-not-assigned
+  "PLW0603",  # global-statement
+  "PLW0604",  # global-at-module-level
+
+  # fails on the try: import typing used by libraries
+  #"F401",  # unused-import
+
+  "F841",  # unused-variable
+  "E722",  # bare-except
+  "PLW0711",  # binary-op-exception
+  "PLW1501",  # bad-open-mode
+  "PLW1508",  # invalid-envvar-default
+  "PLW1509",  # subprocess-popen-preexec-fn
+  "PLW2101",  # useless-with-lock
+  "PLW3301",  # nested-min-max
+]
+
+ignore = [
+    "PLR2004", # magic-value-comparison
+    "UP030", # format literals
+    "PLW1514",  # unspecified-encoding
+    "PLR0913", # too-many-arguments
+    "PLR0915", # too-many-statements
+    "PLR0917", # too-many-positional-arguments
+    "PLR0904", # too-many-public-methods
+    "PLR0912", # too-many-branches
+    "PLR0916", # too-many-boolean-expressions
+    "PLR6301", # could-be-static no-self-use
+    "PLC0415", # import outside toplevel
+    "PLC2701", # private import
+]
+
+[format]
+line-ending = "lf"