From 14c311d3015b2563faf2a6904128012b9019e427 Mon Sep 17 00:00:00 2001 From: Zach Auclair Date: Fri, 3 Jul 2020 17:57:14 -0400 Subject: [PATCH 1/3] fix(definitions): feed name incorrectly small Grouped feeds can be a max of 258 characters long (128 for the group, a single dot, and another 128 for the feed name). --- src/AdafruitIO_Definitions.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/AdafruitIO_Definitions.h b/src/AdafruitIO_Definitions.h index 65f60365..a74a244b 100644 --- a/src/AdafruitIO_Definitions.h +++ b/src/AdafruitIO_Definitions.h @@ -124,7 +124,10 @@ class AdafruitIOGroupCallback { ///< SSL ///< Fingerprint -#define AIO_FEED_NAME_LENGTH 20 ///< Maximum length of an Adafruit IO Feed name +#define AIO_FEED_NAME_LENGTH \ + 258 ///< Maximum length of an Adafruit IO Feed \ + ///< Name; 128 + 1 + 128 for the group, a dot \ + ///< , and actual feed name. #define AIO_DATA_LENGTH \ 45 ///< Maximum length of data sent/recieved from Adafruit IO #define AIO_CSV_LENGTH \ From c74c56769a3cd6ced5b285418fe85de995265e11 Mon Sep 17 00:00:00 2001 From: Zach Auclair Date: Wed, 8 Jul 2020 22:34:33 -0400 Subject: [PATCH 2/3] fix(definitions): csv length incorrectly small The max csv length should be 4 characters larger than the max feed name, so update the definition accordingly. fixes #127 --- src/AdafruitIO_Definitions.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/AdafruitIO_Definitions.h b/src/AdafruitIO_Definitions.h index a74a244b..ea43b6a1 100644 --- a/src/AdafruitIO_Definitions.h +++ b/src/AdafruitIO_Definitions.h @@ -131,7 +131,8 @@ class AdafruitIOGroupCallback { #define AIO_DATA_LENGTH \ 45 ///< Maximum length of data sent/recieved from Adafruit IO #define AIO_CSV_LENGTH \ - 150 ///< Maximum comma-separated-value length from Adafruit IO + AIO_FEED_NAME_LENGTH + 4 ///< Maximum comma-separated-value length from \ + ///< Adafruit IO /** aio_status_t offers 13 status states */ typedef enum { From ec80bf783a06e62715df8fde592e97c3c382674c Mon Sep 17 00:00:00 2001 From: Zach Auclair Date: Wed, 8 Jul 2020 22:34:50 -0400 Subject: [PATCH 3/3] chore(build): version bump for release --- library.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library.properties b/library.properties index 9e2ef45c..ffaa739e 100644 --- a/library.properties +++ b/library.properties @@ -1,5 +1,5 @@ name=Adafruit IO Arduino -version=3.7.0 +version=3.7.1 author=Adafruit maintainer=Adafruit sentence=Arduino library to access Adafruit IO.