Skip to content

Multi-select with shift stopped working in v5 #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 11 tasks
JSoet opened this issue Jun 7, 2019 · 1 comment
Closed
4 of 11 tasks

Multi-select with shift stopped working in v5 #1686

JSoet opened this issue Jun 7, 2019 · 1 comment

Comments

@JSoet
Copy link

JSoet commented Jun 7, 2019

  • Have you already searched for similar issues? Please help us out and double-check first!

  • Also, please don't be that person who deletes this template. It's here for a reason.

  • Thanks!


Which version of React JS are you using?

✅ Officially supported ✅

  • v15.4.x

⚠️ Not officially supported, expect warnings ⚠️

  • v15.5.x
  • v15.6.x

☣️ Not officially supported, expect warnings and errors ☣️

  • v16.x.x

Which browser are you using?

✅ Officially supported ✅

  • IE 9 / IE 10 / IE 11
  • Edge
  • Chrome

⚠️ Not officially supported, but "should work" ⚠️

  • Firefox
  • Safari

I'm submitting a ...

  • 🐛 Bug Report
  • 💡 Feature Request

👋 Need general support? Not sure about how to use React itself, or how to get started with the Grid?
Please do not submit support request here. Instead see

https://github.com/adazzle/react-data-grid/blob/master/CONTRIBUTING.md


Issue Details

Please include:
- What the current behavior is
- What the desired behvaior is
- (If Bug) Steps to reproduce the issue
- (If Feature) The motivation / use case for the feature

We especially love screenshots / videos of problems, and remember
The Best Issue Is A Pull Request™
  • What the desired behaviour is
    Starting in v5 the shift select of multiple rows stopped working. Previously in v4 if you selected an item, and then hit shift and clicked on another item then it would select all the items in between. In v5 this functionality disappeared and I couldn't find any evidence in the changelog that this was done on purpose.

  • What the current behaviour is
    Now when you hit shift nothing happens, it works just like when you didn't hit shift

You can see this in the codesandboxes here... Here is the row selection sandbox example from the docs:
https://codesandbox.io/s/v0zj8qmw6y?from-embed
and here is a fork of it with the version of RDG changed to 4.0.8:
https://codesandbox.io/s/rdg-row-selection-y4m1b
There you can see how the shift select works
But you can try and upgrade to 5.0.0 and you'll see that the shift select is gone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants