refactored static string literal

Author: br-iosb

dataformat-uanodeset/src/main/java/io/adminshell/aas/v3/dataformat/i4aas/mappers/AssetAdministrationShellMapper.java

@@ -54,7 +54,7 @@ private void mapAsset() {
 	}
 
 	private void mapSubmodels() {
-		UAObject smFolder = createReferenceList(AAS_SUBMODELREFERENCES_LIST);
+		UAObject smFolder = createReferenceList(AAS_SUBMODELREFERENCES_LIST_BROWSENAME);
 		List<io.adminshell.aas.v3.model.Reference> submodels = source.getSubmodels();
 		for (int i = 0; i < submodels.size(); i++) {
 			io.adminshell.aas.v3.model.Reference reference = submodels.get(i);
@@ -67,7 +67,7 @@ private void mapSubmodels() {
 	private void mapDerivedFrom() {
 		io.adminshell.aas.v3.model.Reference derivedFrom = source.getDerivedFrom();
 		if (derivedFrom != null) {
-			UAObject uaDerivedFrom = new ReferenceMapper(derivedFrom, ctx, AAS_DERIVEDFROM).map();
+			UAObject uaDerivedFrom = new ReferenceMapper(derivedFrom, ctx, AAS_DERIVEDFROM_BROWSENAME).map();
 			attachAsComponent(target, uaDerivedFrom);
 		}
 	}

dataformat-uanodeset/src/main/java/io/adminshell/aas/v3/dataformat/i4aas/mappers/ReferenceMapper.java

@@ -59,8 +59,8 @@ protected UAObject createTargetObject() {
 	protected void mapAndAttachChildren() {
 		UAVariable UAKeyVariable = UAVariable.builder().withNodeId(ctx.newModelNodeIdAsString())
 				.withDataType(I4AASIdentifier.AASKeyDataType.getName()).withValueRank(1).withArrayDimensions("0")
-				.withAccessLevel(3L).withDisplayName(createLocalizedText("Keys"))
-				.withBrowseName(createI4AASBrowseName("Keys")).build();
+				.withAccessLevel(3L).withDisplayName(createLocalizedText(REFERENCE_KEYS_BROWSENAME))
+				.withBrowseName(createI4AASBrowseName(REFERENCE_KEYS_BROWSENAME)).build();
 		addTypeReferenceFor(UAKeyVariable, UaIdentifier.PropertyType);
 		attachAsProperty(target, UAKeyVariable);
 		addToNodeset(UAKeyVariable);

dataformat-uanodeset/src/main/java/io/adminshell/aas/v3/dataformat/i4aas/mappers/utils/I4AASConstants.java

@@ -41,8 +41,10 @@ public interface I4AASConstants {
 
 	public static final String DATASPECIFICATION_BROWSENAME = "DataSpecification";
 
-	public static final String AAS_SUBMODELREFERENCES_LIST = "Submodel";
-	public static final String AAS_DERIVEDFROM = "DerivedFrom";
+	public static final String AAS_SUBMODELREFERENCES_LIST_BROWSENAME = "Submodel";
+	public static final String AAS_DERIVEDFROM_BROWSENAME = "DerivedFrom";
+
+	public static final String REFERENCE_KEYS_BROWSENAME = "Keys";
 
 
 }

dataformat-uanodeset/src/main/java/io/adminshell/aas/v3/dataformat/i4aas/parsers/AssetAdministrationShellParser.java

@@ -40,9 +40,9 @@ protected AssetAdministrationShell createTargetObject() {
 	protected void parseAndAttachChildren() {
 		super.parseAndAttachChildren();
 
-		source.getI4AASComponent(AAS_SUBMODELREFERENCES_LIST).ifPresent(uanode -> {
+		source.getI4AASComponent(AAS_SUBMODELREFERENCES_LIST_BROWSENAME).ifPresent(uanode -> {
 			uanode.getComponentsOfType(I4AASIdentifier.AASReferenceType).forEach(uaref -> {
-				uaref.getI4AASProperty("Keys").ifPresent(uaKeys -> {
+				uaref.getI4AASProperty(REFERENCE_KEYS_BROWSENAME).ifPresent(uaKeys -> {
 					Reference parse = new ReferenceParser(uaKeys, ctx).parse();
 					target.getSubmodels().add(parse);					
 				});

dataformat-uanodeset/src/test/java/io/adminshell/aas/v3/dataformat/i4aas/TestUANodeset.java

@@ -21,8 +21,6 @@
 
 import org.opcfoundation.ua._2011._03.uanodeset.UANodeSet;
 
-import io.adminshell.aas.v3.dataformat.SerializationException;
-import io.adminshell.aas.v3.dataformat.i4aas.UANodeSetUnmarshaller;
 import io.adminshell.aas.v3.dataformat.i4aas.parsers.ParserContextTest;
 
 public class TestUANodeset {