Replies: 1 comment
-
I'm gonna close this as it seems most of our issues stemmed from some of our own code being lazy-loaded. Apologies for the noise in your repo! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Ever since adopting react-aria-components in Storybook, we've had recurring issues with interactive stories that use
react-aria-components
/react-aria
failing to render in our CI. We cannot reproduce those issues locally, though we occasionally can in Chromatic builds.Stroies that fail are those that use our Modal, Popover or Tooltip, all of which use
react-aria-components
or@react-aria/overlays
hooks.Those stories fail very often when run in CI all at the same time, but never when run individually. On Chromatic builds, we've seen cases where the same stories fail on the first page load, but then pass on every subsequent load. This leads me to believe that there's a performance issue with loading RAC for the first rendered component, or possibly an occasional first-render error.
At this stage I'm just fishing for information from the Spectrum team. Have you ever encountered issues with interactive stories in your own Storybook instances for overlay components? Are there known things we need to do when testing RAC components?
I've looked at https://react-spectrum.adobe.com/react-spectrum/testing.html#test-setup-and-common-gotchas, and am unsure if anything is relevant. Still, could this be a result of us not providing a
Provider
?Thanks in advance for any insights you might be able to provide 🙏
Beta Was this translation helpful? Give feedback.
All reactions