Skip to content

Cannot set properties of undefined (setting 'nodeToRestore') #3954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lingareddyvinitha opened this issue Jan 25, 2023 · 5 comments
Closed

Comments

@Lingareddyvinitha
Copy link

Lingareddyvinitha commented Jan 25, 2023

🐛 Bug Report

When we try to open useOverlays from @react-aria packages

🤔 Expected Behavior

When upgrading to React version 18 with strict mode enabled, some UI elements such as pickers and Overlays may display all items

😯 Current Behavior

When upgrading to React version 18 with strict mode enabled, some UI elements such as pickers and Overlays may experience crashes and errors.

image

Our packages

    "@react-aria/button": "3.6.1",
    "@react-aria/checkbox": "3.5.1",
    "@react-aria/combobox": "3.4.1",
    "@react-aria/dialog": "3.3.1",
    "@react-aria/focus": "3.8.0",
    "@react-aria/i18n": "3.6.0",
    "@react-aria/interactions": "3.12.0",
    "@react-aria/link": "3.3.3",
    "@react-aria/listbox": "3.6.1",
    "@react-aria/menu": "3.6.1",
    "@react-aria/overlays": "3.10.1",
    "@react-aria/radio": "3.3.1",
    "@react-aria/select": "3.8.1",
    "@react-aria/separator": "3.2.3",
    "@react-aria/table": "3.4.1",
    "@react-aria/tabs": "3.3.1",
    "@react-aria/textfield": "3.7.1",
    "@react-aria/tooltip": "3.3.1",
    "@react-aria/utils": "3.13.3",
    "@react-aria/virtualizer": "3.5.0",
    "@react-spectrum/progress": "3.3.1",
    "@react-spectrum/provider": "3.5.1",
    "@react-spectrum/text": "3.3.1",
    "@react-spectrum/theme-default": "3.3.3",
    "@react-spectrum/utils": "3.7.3",
    "@react-stately/collections": "3.4.3",
    "@react-stately/data": "^3.6.1",
    "@react-stately/menu": "3.4.1",
    "@react-stately/overlays": "3.4.1",
    "@react-stately/radio": "3.6.0",
    "@react-stately/select": "3.3.2",
    "@react-stately/table": "3.4.0",
    "@react-stately/tabs": "3.2.1",
    "@react-stately/tooltip": "3.2.1",
    "@react-stately/tree": "3.3.3"
    

devongovett
Tom Schindl
Aaron Hardy

@RajaTheKing826
Copy link

Yah, i'm also facing the same issue, is there any solution for this @devongovett

@devongovett
Copy link
Member

devongovett commented Jan 25, 2023

Strict mode is not yet supported but we are working on it. #779

@reidbarber
Copy link
Member

This got fixed in #3878 and should be in the next release. You can verify by testing the nightly build.

@Lingareddyvinitha
Copy link
Author

Lingareddyvinitha commented Jan 27, 2023

devongovett
reidbarber

Thanks for your update.

When will the final release of this issue be available?

Currently, we have removed the strict mode from our application, but some members of the community suggest it would be beneficial to reinstate it.

Could you provide suggestions for disabling strict mode for specific components or alternative solutions?

@snowystinger
Copy link
Member

We don't have a date yet for our next release, but we are in the midst of prepping for it. So likely next week or the one after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants