Skip to content

Commit a734108

Browse files
fix(progressbar,meter): default width responds to platform
1 parent 7042eb5 commit a734108

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

components/progressbar/index.css

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
/* --spectrum-global-dimension-static-size-2800 */
2929
--spectrum-progressbar-size-2800: 224px;
3030

31+
--spectrum-progressbar-inline-size: var(--spectrum-meter-default-width);
32+
3133
/* Size */
3234
--spectrum-progressbar-font-size: var(--spectrum-font-size-75);
3335
--spectrum-progressbar-line-height-cjk: var(--spectrum-cjk-line-height-100);
@@ -64,7 +66,7 @@
6466

6567
.spectrum-ProgressBar--sizeS,
6668
.spectrum-Meter--sizeS {
67-
--spectrum-progressbar-size-default: var(--spectrum-progressbar-size-2400);
69+
--spectrum-progressbar-size-default: var(--spectrum-progressbar-inline-size);
6870

6971
--spectrum-progressbar-font-size: var(--spectrum-font-size-75);
7072
--spectrum-progressbar-thickness: var(--spectrum-progress-bar-thickness-small);
@@ -73,7 +75,7 @@
7375
}
7476

7577
.spectrum-ProgressBar--sizeM {
76-
--spectrum-progressbar-size-default: var(--spectrum-progressbar-size-2400);
78+
--spectrum-progressbar-size-default: var(--spectrum-progressbar-inline-size);
7779

7880
--spectrum-progressbar-font-size: var(--spectrum-font-size-75);
7981
--spectrum-progressbar-thickness: var(--spectrum-progress-bar-thickness-large);
@@ -83,7 +85,7 @@
8385

8486
.spectrum-ProgressBar--sizeL,
8587
.spectrum-Meter--sizeL {
86-
--spectrum-progressbar-size-default: var(--spectrum-progressbar-size-2500);
88+
--spectrum-progressbar-size-default: var(--spectrum-progressbar-inline-size);
8789

8890
--spectrum-progressbar-font-size: var(--spectrum-font-size-100);
8991
--spectrum-progressbar-thickness: var(--spectrum-progress-bar-thickness-large);
@@ -92,7 +94,7 @@
9294
}
9395

9496
.spectrum-ProgressBar--sizeXL {
95-
--spectrum-progressbar-size-default: var(--spectrum-progressbar-size-2800);
97+
--spectrum-progressbar-size-default: var(--spectrum-progressbar-inline-size);
9698

9799
--spectrum-progressbar-font-size: var(--spectrum-font-size-200);
98100
--spectrum-progressbar-thickness: var(--spectrum-progress-bar-thickness-extra-large);

components/progressbar/metadata/metadata.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
".spectrum-ProgressBar--sizeS",
3232
".spectrum-ProgressBar--sizeXL",
3333
".spectrum-ProgressBar-track",
34+
".spectrum-ProgressBar.spectrum--large",
3435
".spectrum-ProgressBar.spectrum-ProgressBar--staticWhite .spectrum-ProgressBar-fill",
3536
".spectrum-ProgressBar.spectrum-ProgressBar--staticWhite .spectrum-ProgressBar-label",
3637
".spectrum-ProgressBar.spectrum-ProgressBar--staticWhite .spectrum-ProgressBar-percentage",

components/progressbar/stories/progressbar.stories.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ export default {
8787
label: "Loading",
8888
labelPosition: "top",
8989
value: 0,
90-
customWidth: 192,
9190
isIndeterminate: false,
9291
showValueLabel: true,
9392
},

components/progressbar/stories/template.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ export const Template = ({
3232
[`${rootClass}--indeterminate`]: isIndeterminate,
3333
...customClasses.reduce((a, c) => ({ ...a, [c]: true }), {}),
3434
})}
35-
style=${styleMap({
35+
style=${ifDefined(styleMap({
3636
"width": `${customWidth}px`,
3737
...customStyles,
3838
"--mod-progressbar-track-color": trackFill,
3939
"--mod-progressbar-fill-color": progressBarFill,
40-
})}
40+
}))}
4141
value=${ifDefined(value ? `${value}%` : undefined)}
4242
aria-valuenow=${ifDefined(value ? `${value}%` : undefined)}
4343
role="progressbar"

0 commit comments

Comments
 (0)